Re: Ctrl+f in manual

2013-12-26 Thread Dirk Hohndel
On Dec 26, 2013, at 4:39 PM, Lutz Vieweg wrote: > On 12/27/2013 01:26 AM, Dirk Hohndel wrote: >> Would you mind filing bugs on these things? > > Done. Thanks > Now it's good night for me, will have to get back to > the grindstone in the morning. > > Making progress on the v4 video is somewha

Re: Ctrl+f in manual

2013-12-26 Thread Lutz Vieweg
On 12/27/2013 01:26 AM, Dirk Hohndel wrote: Would you mind filing bugs on these things? Done. Now it's good night for me, will have to get back to the grindstone in the morning. Making progress on the v4 video is somewhat slower than I expected - very little can be re-used, and when I encount

Re: Ctrl+f in manual

2013-12-26 Thread Dirk Hohndel
On Dec 26, 2013, at 4:24 PM, Lutz Vieweg wrote: > Hi, > > I wondered whether a "find" function exists in the Manual display, > so I just tried: > When I pressed Ctrl+f, a small white entry field appeared - but in an > unexpected location - obscuring part of the dive list headline, not inside

Re: Selecting a trip + edit does not change attributes of all dives

2013-12-26 Thread Dirk Hohndel
On Dec 26, 2013, at 4:16 PM, Lutz Vieweg wrote: > Hi, > > I wonder whether this is intentional or an error: > > When you auto-group dives and then left-click on the "trip", all dives of > that trip are marked as if selected. > > In that situation, if I enter some value into e.g. the Equipmen

Ctrl+f in manual

2013-12-26 Thread Lutz Vieweg
Hi, I wondered whether a "find" function exists in the Manual display, so I just tried: When I pressed Ctrl+f, a small white entry field appeared - but in an unexpected location - obscuring part of the dive list headline, not inside the Manual display window. Also, entering characters into that

Selecting a trip + edit does not change attributes of all dives

2013-12-26 Thread Lutz Vieweg
Hi, I wonder whether this is intentional or an error: When you auto-group dives and then left-click on the "trip", all dives of that trip are marked as if selected. In that situation, if I enter some value into e.g. the Equipment/Cylinder Size field, the blue note states "trip is being edit

Re: dive table and pointers

2013-12-26 Thread Linus Torvalds
Maybe you could keep a plot_info around as a cache, and then associate that cache with a magic pointer. And if that magic pointer matches the current dive pointer (which you get with get_dive()) *and* that dive hasn't been marked modified, you could trust the current plot info. So you'd use that ma

Re: dive table and pointers

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 20:06, "Dirk Hohndel" escreveu: > > > Tomaz, > > you asked this on IRC while I was unavailable: > > There are good reasons why you can't keep pointers to dives around and > why you can't simply claim that the position in the dive table > represents a specific dive: > > Things move ar

dive table and pointers

2013-12-26 Thread Dirk Hohndel
Tomaz, you asked this on IRC while I was unavailable: There are good reasons why you can't keep pointers to dives around and why you can't simply claim that the position in the dive table represents a specific dive: Things move around. If you download dives from a dive computer or import dives

Re: Some recent change completely broke the DC import

2013-12-26 Thread Lutz Vieweg
On 12/26/2013 08:23 PM, Benjamin wrote: Probably a stupid question, but what are the permissions on the ~/subsurface folder when it exists? > ll -d ~/subsurface drwx-- 2 diver diver 64 Dec 26 15:52 /home/diver/subsurface Regards, Lutz Vieweg __

Re: Some recent change completely broke the DC import

2013-12-26 Thread Jef Driesen
On 26-12-13 20:19, Lutz Vieweg wrote: Does libdc store some state of its own? No. Jef ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Some recent change completely broke the DC import

2013-12-26 Thread Benjamin
Probably a stupid question, but what are the permissions on the ~/subsurface folder when it exists? On 26 Dec 2013 21:19, "Lutz Vieweg" wrote: > On 12/26/2013 07:32 PM, Dirk Hohndel wrote: > >> What's the significance of the ~/subsurface directory? >> > > The only thing I know for sure is that it

Re: Some recent change completely broke the DC import

2013-12-26 Thread Lutz Vieweg
On 12/26/2013 07:32 PM, Dirk Hohndel wrote: What's the significance of the ~/subsurface directory? The only thing I know for sure is that it contains the "diver.xml" file which is used for saving dives by subsurface (for the user named "diver"). Are you running different binaries in these two

Re: Some recent change completely broke the DC import

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 18:38 +0100, Lutz Vieweg wrote: > On 12/26/2013 06:12 PM, Dirk Hohndel wrote: > > So you can reproduce this by doing this: > > > > start Subsurface > > close current data file > > start download from DC > > pick your computer (which vendor / model? which device?) > > Suunto /

New branch on personal repo

2013-12-26 Thread Tomaz Canabrava
People, Dirk, I'm working insanely on a new branch in my personal repo 'newProfileSystem', that will try to share code between the profile and planner, and also make it better, safer, faster, stronger. so, this is my meta for now. :) Tomaz ___ subsurfa

Re: Some recent change completely broke the DC import

2013-12-26 Thread Lutz Vieweg
On 12/26/2013 06:12 PM, Dirk Hohndel wrote: So you can reproduce this by doing this: start Subsurface close current data file start download from DC pick your computer (which vendor / model? which device?) Suunto / D9 / /dev/ttyUSB0 start download nothing in the dive list Correct? Hmm...

Re: Some recent change completely broke the DC import

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 18:05 +0100, Lutz Vieweg wrote: > On 12/26/2013 05:48 PM, Dirk Hohndel wrote: > > That's 45 commits. Any chance you could bisect this? > > Not a good time to do this for me, as it's hard to retain > "continuity" when doing completely different things in between > screen-recor

Re: Some recent change completely broke the DC import

2013-12-26 Thread Lutz Vieweg
On 12/26/2013 05:48 PM, Dirk Hohndel wrote: That's 45 commits. Any chance you could bisect this? Not a good time to do this for me, as it's hard to retain "continuity" when doing completely different things in between screen-recording... Oh - reading these commits again. If you turn on the du

Re: Some recent change completely broke the DC import

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 16:08 +0100, Lutz Vieweg wrote: > Hi, > > I was just in the process of recording the "DC import process" > for the v4 video tutorial when I noticed that precisely that > import does not work anymore (at least with the Suunto D9, > but I suspect a generic issue). > > The bug

Re: [patch] Small code simplification

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 15:02 +0100, Patrick Valsecchi wrote: > Usage of QStringList::contains instead of iterating the list. Thanks, Patrick. That's much simpler and easier to read. /D ___ subsurface mailing list subsurface@hohndel.org http://lists

Some recent change completely broke the DC import

2013-12-26 Thread Lutz Vieweg
Hi, I was just in the process of recording the "DC import process" for the v4 video tutorial when I noticed that precisely that import does not work anymore (at least with the Suunto D9, but I suspect a generic issue). The bug must have been introduced somewhen between commit a351bbde24d4a51a54

[patch] Small code simplification

2013-12-26 Thread Patrick Valsecchi
Usage of QStringList::contains instead of iterating the list. >From 55816b141f06fd9a74e5e4ab01e36d9219e75206 Mon Sep 17 00:00:00 2001 From: Patrick Valsecchi Date: Thu, 26 Dec 2013 14:59:06 +0100 Subject: [PATCH] Usage of QStringList::contains instead of iterating the list. Signed-off-by: Patr

Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 09:45, "Patrick Valsecchi" escreveu: > > Early optimization is root to all evil. > > Anyway this question is eluded by my one liner replacement. Yes, it is. I do prefer your version. Can you send a patch ( with a sob line)? > > Tomaz Canabrava a écrit : >> >> Em 26/12/2013 08:23,

Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 08:23, "Tomaz Canabrava" escreveu: > Hy > Em 26/12/2013 07:03, "Patrick Valsecchi" escreveu: > > > > Hi, > > > > About the patch 0001: > > http://qt-project.org/doc/qt-4.8/qstringlist.html#contains > > > > So that would be shorter: > > > > const bool foundGoogleMap = > list.contain

Re: christmas patches.

2013-12-26 Thread Patrick Valsecchi
Hi, About the patch 0001: http://qt-project.org/doc/qt-4.8/qstringlist.html#contains So that would be shorter: const bool foundGoogleMap = list.contains("earth/googlesat/googlesat.dgml"); And, for your information, QString is copy on write. So a copy by value is nearly costless. CU On 24.