[PATCH] Adding shortcut key sequence to the worldmap exporter

2014-04-02 Thread Gehad
The key sequence ctrl + H for HTML, I think this is a convenient key sequence for exporting HTML and can be used for exporting all different HTML files later. -- Regards, Gehad Elrobey >From 69b40f4a7f57a28f0e46c4a8197c503cec242583 Mon Sep 17 00:00:00 2001 From: Gehad elrobey Date: Wed, 2 Apr

Re: [PATCH] windows.c: prevent an undefined warning

2014-04-02 Thread Lubomir I. Ivanov
On 2 April 2014 22:42, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > [PATCH] windows.c: prevent an undefined warning should have said "unused", rather. lubomir -- ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/c

[PATCH] windows.c: prevent an undefined warning

2014-04-02 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" When building with WIN32_CONSOLE_APP (or CONFIG += console) we need to fake-use console_desc or a warning will pop out. __attribute__((unused)) is available, but is GCC only. Signed-off-by: Lubomir I. Ivanov --- windows.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: Update Checking

2014-04-02 Thread Joshua Joseph
On Wed, Apr 2, 2014 at 10:38 PM, Lubomir I. Ivanov wrote: > > > > > hello, > parts of the patch uses spaces instead of tabs for indentation. > > lubomir > -- > Thanks for the correction, Lubomir. I forgot to reformat the source. New patch attached. From d9c248531c970af8afb32edd02f6624ea6965df5 Mo

Re: Update Checking

2014-04-02 Thread Lubomir I. Ivanov
On 2 April 2014 22:33, Joshua Joseph wrote: > On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote: >> >> I'm willing to take a version of the patch before you and Thiago figure >> out the OS detection. But the current version still needs some work :-) >> > Hi Dirk, > > Attached is the updated pat

Re: Update Checking

2014-04-02 Thread Joshua Joseph
On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote: > > I'm willing to take a version of the patch before you and Thiago figure > out the OS detection. But the current version still needs some work :-) > > Hi Dirk, Attached is the updated patch. From 491b96a76b3e0eef413bd17a0c0ecd83e870eda9 Mon

[PATCH] Make divelist header corrections Mac specific

2014-04-02 Thread Anton Lundin
The +10 pixels fix was introduced to fix some layout issue on Mac ways back, but it breaks things on Android. This makes sure this only gets applied when build for mac. Signed-off-by: Anton Lundin --- qt-ui/divelistview.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui/divelistvie

Re: Update Checking

2014-04-02 Thread Joshua Joseph
On Wed, Apr 2, 2014 at 10:05 PM, Joshua Joseph wrote: > > > See the attached updated patch. > > Here is the patch. From 0a5b483c81fd5820bfc3263750c2a21083338559 Mon Sep 17 00:00:00 2001 From: "Joseph W. Joshua" Date: Wed, 2 Apr 2014 21:59:36 +0300 Subject: [PATCH] Add "Check for updates" Feature

Re: Update Checking

2014-04-02 Thread Joshua Joseph
On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote: > > I'm willing to take a version of the patch before you and Thiago figure > out the OS detection. But the current version still needs some work :-) > > Hi, See the attached updated patch. -- Joshua W Joseph ___

Re: Update Checking

2014-04-02 Thread Thiago Macieira
Em qua 02 abr 2014, às 20:37:58, Joshua Joseph escreveu: > I had used SubsurfaceWebServices::manager(). Are they different? They're the same. I had missed this, sorry about it. You're using the right solution now. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software A

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-02 Thread Linus Torvalds
On Wed, Apr 2, 2014 at 11:04 AM, Venkatesh Shukla IIT BHU wrote: > This is my first patch in Main Subsurface code. I am eager to receive your > feedbacks for any kind of improvements. That can't work. Nothing parses it from the xml, so it may get "saved", but it will never get loaded and thus re-

[PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-02 Thread Venkatesh Shukla IIT BHU
This is my first patch in Main Subsurface code. I am eager to receive your feedbacks for any kind of improvements. Changes Made: 1. Choose if User ID is to be saved during import of divelogs from subsurface webservice. Save function must be called once for change to take effect. 2. Dialogbox reta

Re: Update Checking

2014-04-02 Thread Dirk Hohndel
On Wed, 2014-04-02 at 09:56 +0300, Joshua Joseph wrote: > On Thu, Mar 6, 2014 at 10:03 PM, Dirk Hohndel > wrote: > BTW: is there a QT function that gives us a nice "OS Version"? > I looked at QSysInfo and that's not all that useful. > > I was thinking of something

Re: Update Checking

2014-04-02 Thread Joshua Joseph
> > Hi Josh > > We'll work on the OS detection feature together. I need to finish the > patches > for Qt 5.4. Once that is done, we can backport the changes into subsurface. > > Ok > On the patch itself, it looks good, except that it leaks memory: you never > delete the UpdateManager object and yo

Re: [PATCH] First row visibility fix in Dive List

2014-04-02 Thread Dirk Hohndel
On Wed, 2014-04-02 at 11:51 +0200, Anton Lundin wrote: > > > I've looked at the tables in both Qt4 and Qt5 on Linux and Qt5 on > > > Android and all the tables looks still sane without this adjustment. > > > > As it is stated in ticket #360, it is only mac problem. > > > > We should then make t

Re: Update Checking

2014-04-02 Thread Thiago Macieira
Em qua 02 abr 2014, às 09:56:08, Joshua Joseph escreveu: > Hi Dirk, > > See the attached updated patch, I hope it is OK. I am still working on the > OS detection feature. Hi Josh We'll work on the OS detection feature together. I need to finish the patches for Qt 5.4. Once that is done, we can

Re: [PATCH] Include REMOVE slot

2014-04-02 Thread Lakshman
On Wed, Apr 2, 2014 at 9:18 AM, Tomaz Canabrava wrote: > why did you removed that ? :) > I didn't remove it, I forgot to include it in the derived class, now corrected the mistake. Didn't read the comment properly in tableview. my bad :) Thanks, Lakshman __

Re: [PATCH] Include REMOVE slot

2014-04-02 Thread Tomaz Canabrava
why did you removed that ? :) On Wed, Apr 2, 2014 at 10:51 AM, Lakshman wrote: > Before someone shouts at me, here is the patch that resolves the > 'remove' slot warning, because of my stupid mistake of ignoring the > comment in tableview class. > > Thank you, > Lakshman > > ___

[PATCH] Include REMOVE slot

2014-04-02 Thread Lakshman
Before someone shouts at me, here is the patch that resolves the 'remove' slot warning, because of my stupid mistake of ignoring the comment in tableview class. Thank you, Lakshman From 928a763f2283d8680830e35977f0fd2ea60c6d2b Mon Sep 17 00:00:00 2001 From: Lakshman Anumolu Date: Tue, 1 Apr 2014

Re: Problems while using divecomputer-simulator for linux

2014-04-02 Thread Jef Driesen
On 2014-03-31 16:38, Dirk Hohndel wrote: On Mon, 2014-03-31 at 10:36 +0200, Jef Driesen wrote: To be honest, I don't feel comfortable removing the error checking for the syscalls, and not just because omitting error checking is usually the wrong thing to do. But instead of making the error fat

Re: [PATCH] First row visibility fix in Dive List

2014-04-02 Thread Anton Lundin
On 02 April, 2014 - Andrey Zhdanov wrote: > > > Why do we got this adjustment of the header hight to begin with? > > First row is too close to header. > > > Its this adjustment in header height that hides the first trip marker in > > the Android port, because the first trip row ends up behind

Re: [PATCH] First row visibility fix in Dive List

2014-04-02 Thread Andrey Zhdanov
> Why do we got this adjustment of the header hight to begin with? First row is too close to header. > Its this adjustment in header height that hides the first trip marker in > the Android port, because the first trip row ends up behind the header. Can you show screenshot how it looks in the

Re: [PATCH] First row visibility fix in Dive List

2014-04-02 Thread Anton Lundin
Why do we got this adjustment of the header hight to begin with? The only reason i can find is: "I took the opportunity to fix the header height as well." Its this adjustment in header height that hides the first trip marker in the Android port, because the first trip row ends up behind the head