>
> Hi Josh
>
> We'll work on the OS detection feature together. I need to finish the
> patches
> for Qt 5.4. Once that is done, we can backport the changes into subsurface.
>
> Ok

> On the patch itself, it looks good, except that it leaks memory: you never
> delete the UpdateManager object and you'll recreate it whenever you try to
> check again. I also recommend using the QNetworkAccessManager singleton you
> can access via WebServices::manager().
>
> I had used SubsurfaceWebServices::manager(). Are they different?
_______________________________________________
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to