Re: [PATCH] HTML export fixes

2014-08-16 Thread Paul-Erik Törrönen
One thing that should have been done differently is bugs and enhancement requests. We should have created tickets on bugtracker of all the issues instead of just listing them on emails. I haven't been able to follow all the issues I have mentioned and I am sure it is even harder for Gehad...

Re: [PATCH] HTML export fixes

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 10:20:47AM +0300, Paul-Erik Törrönen wrote: One thing that should have been done differently is bugs and enhancement requests. We should have created tickets on bugtracker of all the issues instead of just listing them on emails. I haven't been able to follow all

Re: [PATCH] HTML export fixes

2014-08-16 Thread Gehad Elrobey
On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel d...@hohndel.org wrote: I just pushed out the latest changes. I like the progress, but there are a couple of small things that I find odd... - naming of export: I think it would make much more sense to name the exports filename_given.html

Re: [PATCH] HTML export fixes

2014-08-16 Thread Miika Turkia
On Sat, Aug 16, 2014 at 4:00 PM, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel d...@hohndel.org wrote: - Gas list While air gets '0' as O₂ value (for reasons Linus has explained many times), we should show Air and not an O₂ of -- I don't

Re: [PATCH] HTML export fixes

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 04:00:08PM +0300, Gehad Elrobey wrote: - units speaking of which: no imperial units? That's not a requirement for GSOC, of course, but would be nice to have. That was one of my Todos after GSOC. Cool. - Acronyms SAC, OTU, and CNS should be uppercase

[PATCH] HTML export fixes

2014-08-14 Thread Miika Turkia
Here are some new fixes on HTML export from Gehad. I did quite a few white space fixes and some typo corrections as well when adding my SOB. Gehad, you could hide the trip 'Other' when it is empty. And similarly the weight under the equipment info (and probably some other empty data as well).

Re: [PATCH] HTML export fixes

2014-08-14 Thread Dirk Hohndel
I just pushed out the latest changes. I like the progress, but there are a couple of small things that I find odd... - naming of export: I think it would make much more sense to name the exports filename_given.html filename_given_files So if the user gives a filename with a suffix,

Re: [PATCH] HTML export fixes

2014-08-14 Thread Miika Turkia
On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel d...@hohndel.org wrote: - mouse hover overlay: the lack of units for time is a bit confusing, at first I wondered why I had 2,185bar in my tank at the beginning of the dive (and was briefly wondering about a bar/psi mixup). Totally agree,