Re: RFC: Initial git save format

2014-03-07 Thread Tomaz Canabrava
#define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20 save-git.c: In function 'create_new_commit': save-git.c:580:3: error: too many arguments to function 'git_branch_create' if (git_branch_create(ref, repo, branch, commit, 0, author, Create branch)) ^ can anybody recheck this for me?

Re: RFC: Initial git save format

2014-03-07 Thread Cristian Ionescu-Idbohrn
On Fri, 7 Mar 2014, Tomaz Canabrava wrote: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20 Debian has a 0.19.0-2 package in 'experimental', which means unavailable for 'unstable', 'testing', 'stable'. So most people will need to build it locally. Cheers, -- Cristian

Re: RFC: Initial git save format

2014-03-07 Thread Tomaz Canabrava
On Fri, Mar 7, 2014 at 11:34 AM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: On Fri, 7 Mar 2014, Tomaz Canabrava wrote: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20 Debian has a 0.19.0-2 package in 'experimental', which means unavailable for

Re: RFC: Initial git save format

2014-03-07 Thread Linus Torvalds
On Mar 7, 2014 5:42 AM, Tomaz Canabrava tcanabr...@kde.org wrote: can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had to extend his macro to check the libgitversion to be = 20. You are probably right that it should be = 20. I only tested 0.19

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 08:12 -0800, Linus Torvalds wrote: On Mar 7, 2014 5:42 AM, Tomaz Canabrava tcanabr...@kde.org wrote: can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had to extend his macro to check the libgitversion to be = 20.

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 08:30 -0800, Dirk Hohndel wrote: On Fri, 2014-03-07 at 08:12 -0800, Linus Torvalds wrote: On Mar 7, 2014 5:42 AM, Tomaz Canabrava tcanabr...@kde.org wrote: can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had to

Re: RFC: Initial git save format

2014-03-07 Thread Cristian Ionescu-Idbohrn
On Fri, 7 Mar 2014, Tomaz Canabrava wrote: On Fri, Mar 7, 2014 at 11:34 AM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.commailto:cristian.ionescu-idbo...@axis.com wrote: On Fri, 7 Mar 2014, Tomaz Canabrava wrote: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 20

Re: RFC: Initial git save format

2014-03-07 Thread Robert C. Helling
On 07 Mar 2014, at 01:20, Linus Torvalds torva...@linux-foundation.org wrote: Hi everyone, just a few comments. - turn the current subsurface directory into a git repository (~/subsurface/ on Linux, ~/Library/Application Support/Subsurface on MacOS, and CSIDL_APPDATA/Subsurface/ on Windows)

Re: RFC: Initial git save format

2014-03-07 Thread Linus Torvalds
On Fri, Mar 7, 2014 at 12:45 PM, Robert C. Helling hell...@atdotde.de wrote: I hope you mean something like ~/.subsurface or even ~/.subsurfacerc . At least for me ~/subsurface is already a git repository and is my subsurface working directory (containing the source). I actually did mean

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 13:03 -0800, Linus Torvalds wrote: On Fri, Mar 7, 2014 at 12:45 PM, Robert C. Helling hell...@atdotde.de wrote: I hope you mean something like ~/.subsurface or even ~/.subsurfacerc . At least for me ~/subsurface is already a git repository and is my subsurface

Re: RFC: Initial git save format

2014-03-07 Thread Thiago Macieira
Em sex 07 mar 2014, às 13:28:20, Dirk Hohndel escreveu: I hope you mean something like ~/.subsurface or even ~/.subsurfacerc . At least for me ~/subsurface is already a git repository and is my subsurface working directory (containing the source). I actually did mean ~/subsurface.

Re: RFC: Initial git save format

2014-03-06 Thread Tomaz Canabrava
Linus, I can probably do the Qt UI in about 2h ( learning what need to be done on the UI, of course, never played with libgit. ) So, if this enters on subsurface master, I'll do the UI this weekend. Tomaz On Thu, Mar 6, 2014 at 6:28 PM, Linus Torvalds torva...@linux-foundation.org wrote: So

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 13:28 -0800, Linus Torvalds wrote: So Dirk knows about this effort, and it's been rattling around in my head for a long while, but it took some time for me to digest how to actually do it. When I saw your G+ post I was trying to remember when we first started talking

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:03 PM, Dirk Hohndel d...@hohndel.org wrote: compiling save-git.c save-git.c: In function ‘create_new_commit’: save-git.c:569:3: error: too many arguments to function ‘git_branch_create’ save-git.c:572:2: error: too many arguments to function

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:29 PM, Linus Torvalds torva...@linux-foundation.org wrote: I'll have to figure out the versioning, it is not obvious where that happens. Damn library authors that don't get the whole you need to get versioning right This patch on top of the earlier one seems to make

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 14:29 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 2:03 PM, Dirk Hohndel d...@hohndel.org wrote: compiling save-git.c save-git.c: In function ‘create_new_commit’: save-git.c:569:3: error: too many arguments to function ‘git_branch_create’ save-git.c:572:2:

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
If you don't mind I'd add this to your previous commit - this way I have one fewer possible doesn't compile point when doing a git bisect in the future. You also forgot a commit message and SOB... /D On Thu, 2014-03-06 at 14:40 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 2:29 PM,

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 1:54 PM, Dirk Hohndel d...@hohndel.org wrote: how do you intend the actual UI to work? Ideally this would be a no user interaction UI in most cases. I don't want divers to have to wonder what we might mean by branch and other strange terminology... So my expectation is

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:51 PM, Dirk Hohndel d...@hohndel.org wrote: If you don't mind I'd add this to your previous commit - this way I have one fewer possible doesn't compile point when doing a git bisect in the future. You also forgot a commit message and SOB... I actually intended for

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 15:03 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 1:54 PM, Dirk Hohndel d...@hohndel.org wrote: how do you intend the actual UI to work? Ideally this would be a no user interaction UI in most cases. I don't want divers to have to wonder what we might mean by

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 3:20 PM, Dirk Hohndel d...@hohndel.org wrote: The problem with that is that it exposes terminology to Joe and Jane Diver that I'd prefer to hide from them. Actually, with the git save-file, my *preference* would be that the default filename configuration would basically

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 16:20 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 3:20 PM, Dirk Hohndel d...@hohndel.org wrote: The problem with that is that it exposes terminology to Joe and Jane Diver that I'd prefer to hide from them. Actually, with the git save-file, my *preference*

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 4:29 PM, Dirk Hohndel d...@hohndel.org wrote: So what about 'trip membership' - is the location in the tree relevant for that? Yes, it would nest like the XML thing nests (ie one level only), but would be the only actual nesting. And from an implementation standpoint,