adding more data for people to collect

So far Subsurface has been primarily designed around the idea that it would collect the data from a divecomputer, visualize it in a compelling way and add a few more items that seemed interesting to the initial developers. Reading through feedback, feature requests and reflecting on conversations

Re: [CCR PATCH] reorganise po2 calculations

Robert, I took the patch with tiny cleanups as it looked sane to me, but I think I the last couple of days have shown that you are much better than me in spotting issues in that code :-) Would you please take a look? Willem is leaving tonight and I want to make sure we get this figured out in the

Re: DiveShare patch

On Monday 13 October 2014 21:23:59 Salvo Tomaselli wrote: > How about now? > > I used astyle and I think I've addressed all the comments. Thanks Salvo. This looks better. I haven't run your code yet, but it looks like it does what you're proposing to do. I only have one issue: your code leaks

[CCR PATCH] reorganise po2 calculations

CCR patch. Reorganise the oxygen partial pressure calculations. This patch responds to the side effects that the CCR code has had with respect to ceilings in OC dives and dive plans. Dive ceilings are now calculated apparently correctly. The following were performed: 1) remove the oxygen sensor a

[PATCH] Ignore pictures when parsing divelogs.de import

Do not do XML parse on pictures. Currently just ignore them, in the future we might want to save them somewhere and include them in Subsurface logs. Signed-off-by: Miika Turkia --- file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/file.c b/file.c index 1859e39..b1e258b 100644 --- a/f

Re: Some styles might look bad

my fault. I need a windows machine to test this code on. I'll try to fix this in another way than I'm doing right now. On Mon, Oct 13, 2014 at 3:08 PM, Salvo Tomaselli wrote: > A friend of mine sent me a screenshot of what he sees. > > The "+" buttons are placed in an odd way on his style. > > _

Some styles might look bad

A friend of mine sent me a screenshot of what he sees. The "+" buttons are placed in an odd way on his style. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[PATCH v2] Check that the model is a supported one

This code adds some crude checks to verify that the device is a supported one before we actually read/write from it. This is to white/black-list devices so we don't write or read memory that we don't know anything about. Signed-off-by: Anton Lundin --- configuredivecomputerthreads.cpp | 69 +

Re: Problems with ceiling for CCR dive

On 13.10.2014, at 16:12, Willem Ferguson wrote: Willem, > Please give me comment? I would strongly prefer option one as add_segment is called from different places in the code, some being in the planner and thus not having valid plot_data (Creator tells we it gets called in 12 different pla

Re: Problems with ceiling for CCR dive

On 13/10/2014 12:27, Robert Helling wrote: What I can do is this: Create a function in profile.c that does the voting. It will reside in profile.c, be plot_info aware, and return a double, being the calculated po2 value. Now we can remove the sensor values from the pressures structure and r

Re: Use of o2 cell data in CCR dive logs

Hi Willem, On Oct 13, 2014, at 11:37 AM, Willem Ferguson wrote: Hope you do not mind me changing the topic title. No problem. Thank you very much for your response. The philosophy here is to get the system working for a fully logged CCR system and then to expand this foundation to others.

Re: Problems with ceiling for CCR dive

On Mon, Oct 13, 2014 at 12:19 PM, Paul Sargent wrote: > I hope everyone will forgive a recent subscriber and lurker stating an > opinion, but I wonder if this is going down the wrong road. I promised Dirk > I'd get involved a while back and never did - so here goes nothing. Hi Paul, Welocme on b

[PATCH] Check that the model is a supported one

This code adds some crude checks to verify that the device is a supported one before we actually read/write from it. This is to white/black-list devices so we don't write or read memory that we don't know anything about. Signed-off-by: Anton Lundin --- configuredivecomputerthreads.cpp | 69 +

Re: Problems with ceiling for CCR dive

On 13 October, 2014 - Robert Helling wrote: > > On 13.10.2014, at 11:53, Willem Ferguson > wrote: > > Willem, > > > If I execute calculate_deco_information() AFTER get_pressures(), then, for > > OC as well as CCR dives, the ceilings appear correct because, now, there > > are calculated po2

Re: FTBFS on freebsd

On Monday 13 October 2014 09:16:06 Salvo Tomaselli wrote: > Hello, > > I need some debian related help. > > Basically, subsurface.pro doesn't have a case for freebsd, (it > should just compile with linux.c) so there it fails to link > because subsurface_open is missing. > > If someone knows how

Re: DiveShare patch

Hi Salvo Thanks for the patch. The idea looks good and the networking part per se looks correct (even if I haven't run the code), but like Dirk said, it needs a couple of fixes before it goes in. Here are a couple of suggestions from me: On Sunday 12 October 2014 19:41:41 Salvo Tomaselli wrote:

Re: Use of o2 cell data in CCR dive logs

Paul, On 13/10/2014 12:19, Paul Sargent wrote: I hope everyone will forgive a recent subscriber and lurker stating an opinion, but I wonder if this is going down the wrong road. I promised Dirk I'd get involved a while back and never did - so here goes nothing. You're assuming that the cell d

Re: Problems with ceiling for CCR dive

On 13.10.2014, at 11:53, Willem Ferguson wrote: Willem, > If I execute calculate_deco_information() AFTER get_pressures(), then, for OC > as well as CCR dives, the ceilings appear correct because, now, there are > calculated po2 values to work from, allowing calculation of pn2 values and >

Re: [PATCH 5/7] This adds read/write of Suunto Vyper configs

On 2014-10-13 11:44, Anton Lundin wrote: On 13 October, 2014 - Jef Driesen wrote: On 2014-10-12 16:51, Anton Lundin wrote: >This implements the reading and writing of the configuration varables >from the Suunto Vyper family devices. > >Everything here is implemented based on the excellent infor

Re: Problems with ceiling for CCR dive

I hope everyone will forgive a recent subscriber and lurker stating an opinion, but I wonder if this is going down the wrong road. I promised Dirk I'd get involved a while back and never did - so here goes nothing. (Quick Intro: rEvo CCR Trimix Diver + Sidemount Diver + General OC - Guy who s

Re: Problems with ceiling for CCR dive

Robert, On 13/10/2014 11:25, Robert Helling wrote: On 13.10.2014, at 08:49, Willem Ferguson > wrote: Willem, 1) Your sensor data never reaches fill_pressures: You make the pressures struct (and I would like to add that using one structure to both pas

Re: [PATCH 5/7] This adds read/write of Suunto Vyper configs

On Mon, Oct 13, 2014 at 11:44:06AM +0200, Anton Lundin wrote: > I'm thinking about starting out by reading 0x24,1 > SUUNTO_VYPER_COMPUTER_TYPE , and matching that against the > device-model-list to verify that the computer reports a model that we > know how to handle, and instead of calling it "UNK

Re: [PATCH 5/7] This adds read/write of Suunto Vyper configs

On 13 October, 2014 - Jef Driesen wrote: > On 2014-10-12 16:51, Anton Lundin wrote: > >This implements the reading and writing of the configuration varables > >from the Suunto Vyper family devices. > > > >Everything here is implemented based on the excellent information on: > >http://www.sarnau.in

Re: Problems with ceiling for CCR dive

On 13.10.2014, at 08:49, Willem Ferguson wrote: Willem, > I think we have different understandings of the logic. I have just tried to fix the partial pressure calculation but stopped since I found it is missing more than I thought. As it turns out your patch breaks the ceiling calculation

Re: [PATCH 5/7] This adds read/write of Suunto Vyper configs

On 2014-10-12 16:51, Anton Lundin wrote: This implements the reading and writing of the configuration varables from the Suunto Vyper family devices. Everything here is implemented based on the excellent information on: http://www.sarnau.info/papers:suunto_vyper Most of the info on that page is

FTBFS on freebsd

Hello, I need some debian related help. Basically, subsurface.pro doesn't have a case for freebsd, (it should just compile with linux.c) so there it fails to link because subsurface_open is missing. If someone knows how to fix it quickly, please send me a patch for the .pro file. Thanks --

Re: Problems with ceiling for CCR dive

On 13.10.2014, at 08:49, Willem Ferguson wrote: Willem, > I think we have different understandings of the logic. whatever. The po2 argument of that function was never meant to be any measured or calculated value, it is the set-point of the rebreather and as long as there is no sensor data