Re: Beta 3 Testing

2015-10-04 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 12:21:56AM +, John Smith wrote: > Running Win7 SP1 > > Installed ok, no issues seen. Well, except for the warning that this package is from an unknown developer. A warning that is getting pretty annoying with Windows 10. Not quite as bad as on a Mac, but still. I

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 09:22:07AM +1100, Rick Walsh wrote: > Hi Willem, > > On 5 October 2015 at 09:17, Willem Ferguson > wrote: > > > Rick, > > Thanks very much. > > > > Currently I have > >

Re: Fix for #934

2015-10-04 Thread Miika Turkia
On Fri, Oct 2, 2015 at 6:59 PM, Sander M. Kleijwegt wrote: > see attached patch. Looks good to me on initial glance. However, you should prefix the emails that include patches with [PATCH] on the subject line. This way it is easier for Dirk to recognize the patches that

[Patch] dive_site notes displays like a single, long, long line

2015-10-04 Thread Salvador Cuñat
Good morning. I had noticed that Dive Site notes are displayed like a very long, single line. This is pretty annoying if one tries to give some format to the stored text (e.g. \n or \t). I initially thought it was a QT thing on showing the text, as I could see the chars in the XML file, but it

Re: freedive mode

2015-10-04 Thread Dirk Hohndel
Hi Giorgio, thanks for the excellent bug report including a sample file. I found and fixed the bug and also added another feature that you asked for: when the dive computer reports your dive as "freedive" we now split the dives with only 10 seconds at the surface (otherwise the threshold stays

[PATCH] Correct sign on Divesoft Freedom timestamps

2015-10-04 Thread Anton Lundin
I managed somehow to miss-read and by accident told Linus that the timestamp was signed. It is a unsigned uint32_t, so this corrects the mistake i tricked Linus into making. Signed-off-by: Anton Lundin --- parse-xml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Patch] dive_site notes displays like a single, long, long line

2015-10-04 Thread Linus Torvalds
On Sun, Oct 4, 2015 at 6:51 AM, Salvador Cuñat wrote: > > If the use of the XML attribute was, for some reason, intentional, please, > simply drop the attached patch. I think the patch is correct. We already use an XML element (not attribute) for the *dive* notes (and

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Rick Walsh
Hi Willem, On 3 October 2015 at 07:22, Willem Ferguson wrote: > | > | I'd say so - assuming you are building in ~*/src/*... > | > > Yes, I build in ~/src/ > > willem~ cd src > willem~/src$ ls > build.log grantlee install-root libdivecomputer libgit2

Re: [Patch] dive_site notes displays like a single, long, long line

2015-10-04 Thread Salvador Cuñat
Hi again. For obvious reasons, this doesn't affect git storage, just XML files. Regards. Salva. 2015-10-04 12:51 GMT+02:00 Salvador Cuñat : > Good morning. > > I had noticed that Dive Site notes are displayed like a very long, single > line. This is pretty annoying

Re: Fwd: [PATCH] Windows binary saga

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 01:45:43PM +0200, Robert C. Helling wrote: > Dirk, > > did you miss this patch or do you want to postpone it or simply don’t like it? I didn't see it. Sorry. I like it mostly, I'll remove the comment about modifying things at your own risk - that doesn't seem to make

Re: freedive mode

2015-10-04 Thread Giorgio Marzano
Ok. Understand (kind of...). See you on the mailing list. Dirk, about 4.5 I am fine. Split dive and collect them in a trip fit my actual needs. In the near future I would like to tweak how some data is represented. E.g. in freedive mode seconds are relevant, while I understand that for scuba

4.5 Beta 3

2015-10-04 Thread Dirk Hohndel
Tag is pushed, Windows and Mac installers are in place, Linux packages are building. As I said in the other email, I intend for this to be the last beta prior to 4.5 and I hope to cut 4.5 by mid week unless serious bugs are found. My usual plea. Please test. It's really quite frustrating when

Re: [PATCH] Restructure preferences UI

2015-10-04 Thread Dirk Hohndel
Ui changes? Didn't even look at it -- Sent from my phone > On Oct 4, 2015, at 17:40, Joakim Bygdell wrote: > > Bump for a missed patch. > >> On 03 Oct 2015, at 17:44, Joakim Bygdell wrote: >> >> Change the layout of the UI for improved clarity. >>

Re: [PATCH] Restructure preferences UI

2015-10-04 Thread Joakim Bygdell
Bump for a missed patch. > On 03 Oct 2015, at 17:44, Joakim Bygdell wrote: > > Change the layout of the UI for improved clarity. > Fixes #922 > > Signed-off-by: Joakim Bygdell > --- > qt-ui/preferences.ui | 544

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 09:15:22PM +1100, Rick Walsh wrote: > Hi Willem, > > On 3 October 2015 at 07:22, Willem Ferguson > wrote: > > > | > > | I'd say so - assuming you are building in ~*/src/*... > > | > > > > Yes, I build in ~/src/ > > > > willem~ cd src >

Re: Fix for #934

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 07:59:05AM -0400, Miika Turkia wrote: > On Fri, Oct 2, 2015 at 6:59 PM, Sander M. Kleijwegt > wrote: > > see attached patch. > > Looks good to me on initial glance. However, you should prefix the > emails that include patches with [PATCH] on the

Re: freedive mode

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 02:14:33PM +0200, Giorgio Marzano wrote: > Ok. Understand (kind of...). See you on the mailing list. > > Dirk, about 4.5 I am fine. Split dive and collect them in a trip fit my > actual needs. Good. > In the near future I would like to tweak how some data is

Translations

2015-10-04 Thread Dirk Hohndel
Hello dear translators. I am amazed how many languages are nearly complete (apparently 99% is now complete - I have not been able to find out what the one non-existand string is). Of the top 12 languages in use (from what I can tell tracking the checkins with my server) we have seven in excellent

Re: 4.5 Beta 3

2015-10-04 Thread Giorgio Marzano
Just noticed that split dives seems to have max depth (and i guess some other field) inherited from original dives. If the original dive max depth is 20m, then all the resulting "subdives" seems to be 20m deep in the list and in the "Info" tab, while the plot is correct. G 2015-10-04 18:18

Re: freedive mode

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 05:00:02AM -0700, Giorgio Marzano wrote: > Hi, all > > could someone please explain me the workflow to propose, discuss and > implement a change? I'd strongly suggest doing that on the developer mailing list, not in the user forum. > Let's say I have a change to

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Anton Lundin
On 04 October, 2015 - Dirk Hohndel wrote: > On Sun, Oct 04, 2015 at 09:15:22PM +1100, Rick Walsh wrote: > > Hi Willem, > > > > On 3 October 2015 at 07:22, Willem Ferguson > > wrote: > > > > > | > > > | I'd say so - assuming you are building in ~*/src/*... >

Re: 4.5 Beta 3

2015-10-04 Thread Salvador Cuñat
Good evening. 2015-10-04 18:18 GMT+02:00 Dirk Hohndel : > > Willem, are we OK on the user manual? > > Those of you translating the manual, how close are you to being caught up? > > Have just sent a patch for user-manual_es.txt refered to latest Willem's changes. If there are no

[PATCH] Update spanish translation of user manual to english b74809b

2015-10-04 Thread Salvador Cuñat
Changes to Bluetooth download section. Signed-off-by: Salvador Cuñat --- Documentation/user-manual_es.txt | 56 +++- 1 file changed, 26 insertions(+), 30 deletions(-) diff --git a/Documentation/user-manual_es.txt

Re: 4.5 Beta 3

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 07:56:21PM +0200, Salvador Cuñat wrote: > Good evening. > > 2015-10-04 18:18 GMT+02:00 Dirk Hohndel : > > > > > Willem, are we OK on the user manual? > > > > Those of you translating the manual, how close are you to being caught up? > > > > > Have just

Re: 4.5 Beta 3

2015-10-04 Thread Dirk Hohndel
On Sun, Oct 04, 2015 at 07:30:39PM +0200, Giorgio Marzano wrote: > Just noticed that split dives seems to have max depth (and i guess some > other field) inherited from original dives. I clearly didn't look closely enough. But that's easy enough to fix. > If the original dive max depth is 20m,

Re: Translations

2015-10-04 Thread Tim Wootton
Transifex support reckon string 584 is the offending item, but I'm not sure exactly what needs to be done to fix it. cheers, Tim On 04/10/15 16:52, Dirk Hohndel wrote: > Hello dear translators. > > I am amazed how many languages are nearly complete (apparently 99% is now > complete - I have

Re: Translations

2015-10-04 Thread Lubomir I. Ivanov
On 5 October 2015 at 00:05, Tim Wootton wrote: > Transifex support reckon string 584 is the offending item, but I'm not > sure exactly what needs to be done to fix it. > quite odd as there is nothing wrong with that particular string ("Location: "). also Qt Linguist does not

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Rick Walsh
Hi Willem, On 5 October 2015 at 09:17, Willem Ferguson wrote: > Rick, > Thanks very much. > > Currently I have > /home/willem/src/subsurface/marbledata/maps/earth/googlesat/googlesat.dgml > > My subsurface directory does not contain a: >

Trip header format in dive list

2015-10-04 Thread Willem Ferguson
On Sun, Oct 04, 2015 at 05:00:02AM -0700, Giorgio Marzano wrote: Hi, all could someone please explain me the workflow to propose, discuss and implement a change? I'd strongly suggest doing that on the developer mailing list, not in the user forum. Let's say I have a change to propose: to

Beta 3 Testing

2015-10-04 Thread John Smith
Running Win7 SP1 Installed ok, no issues seen. I had done an uninstall prior to installing but some of the logs were kept from the last installation and loaded at startup. Deleted the logs and used the reset all settings button in preferences. Most of the settings went back to default except

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Willem Ferguson
Rick, Thanks very much. Currently I have /home/willem/src/subsurface/marbledata/maps/earth/googlesat/googlesat.dgml My subsurface directory does not contain a: build/marble/data/earth/googlesat/ Do you imply that I should create a directory:

Re: Marble problem (was Coordinates and dive mapping)

2015-10-04 Thread Miika Turkia
On Mon, Oct 5, 2015 at 5:13 AM, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 09:22:07AM +1100, Rick Walsh wrote: >> Hi Willem, >> >> On 5 October 2015 at 09:17, Willem Ferguson > > wrote: >> >> > Rick, >> > Thanks very much. >> > >> > Currently

Re: Translations

2015-10-04 Thread Tim Wootton
On 04/10/15 22:43, Lubomir I. Ivanov wrote: > On 5 October 2015 at 00:05, Tim Wootton wrote: >> Transifex support reckon string 584 is the offending item, but I'm not >> sure exactly what needs to be done to fix it. >> > quite odd as there is nothing wrong with that