Error when executing on Ubuntu

2015-10-13 Thread Willem Ferguson
I still get a single error message when running Subsurface in Ubuntu 15.04. It seems this relates to some of the changes discussed during the last week. Is this due to the code or due to my specific setup? Thank you for solving the long list of errors and warnings generated until now!

Re: [PATCH] Re: Allow replanning of logged dives

2015-10-13 Thread Davide DB
On Tue, Oct 13, 2015 at 12:28 AM, Dirk Hohndel wrote: >> >> This displays the TTS as 121 minutes for the maximum. Changing this for a >> string like „TTS: long“ would of course introduce a new string so I left it >> out. To be added later. > > I think "TTS > 120min" would be

Re: Allow replanning of logged dives

2015-10-13 Thread Anton Lundin
On 13 October, 2015 - Davide DB wrote: > On Mon, Oct 12, 2015 at 4:36 PM, Anton Lundin wrote: > > > > Currently it doesn't do any gas-switches in its calculations, because > > thats a quite big rabbit-hole to go down. IE, when should it switch gas? > > At mod? 1.6, 1.5 or 1.4?

Re: [PATCH] Re: Allow replanning of logged dives

2015-10-13 Thread Anton Lundin
On 12 October, 2015 - Dirk Hohndel wrote: > On Mon, Oct 12, 2015 at 11:16:09PM +0200, Robert C. Helling wrote: > > Hi, > > > > > On 12 Oct 2015, at 16:36, Anton Lundin wrote: > > > > > > But still a upper limit of the TTS is anyhow a good idea. > > > I'll clobber up a patch

Re: Is anyone working on an iOS app?

2015-10-13 Thread Anton Lundin
On 12 October, 2015 - Lubomir I. Ivanov wrote: > On 12 October 2015 at 22:20, Guido Lerch wrote: > > > > Forgot ... > > Which of the Android components for QT do I need to install ? > > > > > > i think it installs different compiler toolchains depending on the > picks you

Re: Allow replanning of logged dives

2015-10-13 Thread Davide DB
On Mon, Oct 12, 2015 at 4:36 PM, Anton Lundin wrote: > > Currently it doesn't do any gas-switches in its calculations, because > thats a quite big rabbit-hole to go down. IE, when should it switch gas? > At mod? 1.6, 1.5 or 1.4? Configurable? > > So when i wrote that i just

Re: Image management, bug fix

2015-10-13 Thread Miika Turkia
Hello Guido, there is buffer overflow situation with this patch as you concatenate two strings of arbitrary length to a fixed size array. I suggest validating the lengths and making sure the end result fits to the target buffer. You should probably also use PATH_MAX for the size instead of the

Re: Managed Images

2015-10-13 Thread Robert Helling
Guido, > On 13.10.2015, at 11:41, Guido Lerch wrote: > > removal of a picture if the user removes it from the dive > if managed location is enabled. this sounds dangerous to me: So far, the image management (i.e. copy all images to a specified folder before adding

Re: [PATCH] Re: [PATCH] Re: Allow replanning of logged dives

2015-10-13 Thread Anton Lundin
On 13 October, 2015 - Robert C. Helling wrote: > From 4847d1a16483ac4208ca86f5157abebb4d67a164 Mon Sep 17 00:00:00 2001 > From: "Robert C. Helling" > Date: Tue, 13 Oct 2015 11:21:14 +0200 > Subject: [PATCH] Say in infobox if NDL or TTS calculation was cut-off > >

[PATCH] Re: [PATCH] Re: Allow replanning of logged dives

2015-10-13 Thread Robert C. Helling
Hi,On 13 Oct 2015, at 10:27, Anton Lundin wrote:For the TTS I think its really important to be clear that its somewhereabove that number. For the ndl calculations it really didn't matter thatit was capped at 120min, because a NDL of 120 min means just "LOTS", buta TTS you

Managed Images

2015-10-13 Thread Guido Lerch
Big fix and adding the removal of a picture if the user removes it from the dive if managed location is enabled. -- Best regards, Guido From 62aa6f0a3f8333d0b4f6969fbecace1e50b23869 Mon Sep 17 00:00:00 2001 From: Guido Lerch Date: Tue, 13 Oct 2015 11:39:02 +0200 Subject:

Re: Allow replanning of logged dives

2015-10-13 Thread Davide DB
On Tue, Oct 13, 2015 at 10:24 AM, Anton Lundin wrote: > > Maybe you would like to sum this discussion up into something > understandable in the manual, so others thinking about this would be > able to get their answers there? Argh! Tough task :) I saw Willem warned about user

User manual status

2015-10-13 Thread Willem Ferguson
The user manual is, as far as I can see, ready for release with V4.5. There are a few small items but this will be followed up after the release. This message is to: 1) the **translators** to indicate that the last patch to update the manual was "User manual update: Facebook". Many images

Re: Is anyone working on an iOS app?

2015-10-13 Thread Guido Lerch
Thanks Anton 2015-10-13 10:34 GMT+02:00 Anton Lundin : > On 12 October, 2015 - Lubomir I. Ivanov wrote: > > > On 12 October 2015 at 22:20, Guido Lerch wrote: > > > > > > Forgot ... > > > Which of the Android components for QT do I need to install ? > >

Re: Managed Images

2015-10-13 Thread Tomaz Canabrava
You need to override contextMenuEvent on the view that displays the images. Now, I think that is a common qlistview, so you can create an event filter. Grep for contextMenuEvent on the code for examples. Em 13 de out de 2015 08:53, "Robert Helling" escreveu: > > On

Fwd: User manual status

2015-10-13 Thread Sergey Starosek
Willem, On Tue, Oct 13, 2015 at 2:36 PM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > The user manual is, as far as I can see, ready for release with V4.5. > There are a few small items but this will be followed up after the release. > > One note on geo-lookup functionality. Upon

Re: Fwd: User manual status

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 06:06:47PM +0300, Sergey Starosek wrote: > Dirk, > > On Tue, Oct 13, 2015 at 5:55 PM, Dirk Hohndel wrote: > > > > > > One note on geo-lookup functionality. Upon performing lookup, name of the > > > found location does not populate Name field but instead

Re: [PATCH] usermanual.cpp: use default QWidget theme colors for text selections

2015-10-13 Thread Willem Ferguson
On 13/10/2015 17:06, Lubomir I. Ivanov wrote: From: "Lubomir I. Ivanov" The default selection text/background colors (also when seaching) are black/light-grey in QWebView, for some reason. To solve the issue we pass a stylesheet that makes use of the default palette's

Re: [PATCH] usermanual.cpp: use default QWidget theme colors for text selections

2015-10-13 Thread Miika Turkia
On Tue, Oct 13, 2015 at 6:24 PM, Willem Ferguson wrote: > On 13/10/2015 17:06, Lubomir I. Ivanov wrote: > > From: "Lubomir I. Ivanov" > > The default selection text/background colors (also when seaching) > are black/light-grey in QWebView,

Re: [PATCH] Parse html links in the Notes section.

2015-10-13 Thread Dirk Hohndel
On Mon, Oct 12, 2015 at 10:08:35PM -0700, K. "pestophagous" Heller wrote: > In the spirit of "Do the simplest thing that could > possibly work": capture Ctrl+leftclick mouse events > in the Notes area. If the string under the clicked > position is a valid url, then launch it. > > Many common URI

Re: Fwd: User manual status

2015-10-13 Thread Sergey Starosek
Dirk, On Tue, Oct 13, 2015 at 5:55 PM, Dirk Hohndel wrote: > > > One note on geo-lookup functionality. Upon performing lookup, name of the > > found location does not populate Name field but instead Tags label (not > > sure about the purpose of this one). > > I'm not sure what

[PATCH] usermanual.cpp: use default QWidget theme colors for text selections

2015-10-13 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" The default selection text/background colors (also when seaching) are black/light-grey in QWebView, for some reason. To solve the issue we pass a stylesheet that makes use of the default palette's highlight() and highlightedText() from QWidget.

Re: [PATCH] User manual: last-minute changes before V4.5

2015-10-13 Thread Dirk Hohndel
> On Oct 13, 2015, at 8:43 AM, Willem Ferguson > wrote: > > [PATCH] User manual: last changes before V4.5 > > 1) Run a spell checker through the user manual. Only three >outright typos found!! > 2) Correct sentence about reverse name

Re: Image management, bug fix

2015-10-13 Thread Dirk Hohndel
> On Oct 13, 2015, at 8:48 AM, Guido Lerch wrote: > > Hi Robert > Before I comment point by point let me mention that is is exploratory and > that I do not have all the answers yet. > Yes I am a photographer and my intent is to have the images available > regardless off

[PATCH] User manual: last-minute changes before V4.5

2015-10-13 Thread Willem Ferguson
[PATCH] User manual: last changes before V4.5 1) Run a spell checker through the user manual. Only three outright typos found!! 2) Correct sentence about reverse name lookup that results in dive site name reported in tags field, not in Location field. (Sergey,

Re: [PATCH] User manual: last-minute changes before V4.5

2015-10-13 Thread Davide DB
Hi Willem, Do not forget last minute clarification about TTS On Oct 13, 2015 5:43 PM, "Willem Ferguson" wrote: > [PATCH] User manual: last changes before V4.5 > > 1) Run a spell checker through the user manual. Only three >outright typos found!! >

Re: Image management, bug fix

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 06:58:03PM +0200, Guido Lerch wrote: > Hi Dirk > > > Am 13.10.2015 um 17:50 schrieb Dirk Hohndel : > >> > >> Hi Robert > >> Before I comment point by point let me mention that is is exploratory and > >> that I do not have all the answers yet. > >> Yes I

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 07:46:54PM +0300, Miika Turkia wrote: > On Sun, Oct 11, 2015 at 10:10 PM, Miika Turkia wrote: > > On Sun, Oct 11, 2015 at 8:30 PM, Dirk Hohndel wrote: > >> On Sun, Oct 11, 2015 at 12:04:11PM +0300, Lubomir I. Ivanov wrote: > >>>

Fwd: Re: [PATCH] User manual: last-minute changes before V4.5

2015-10-13 Thread Willem Ferguson
Forwarded Message From: 12 2015 <> X-Mozilla-Status: 0001 X-Mozilla-Status2: 0080 X-Mozilla-Keys: Reply-To: willemfergu...@zoology.up.ac.za Subject:Re: [PATCH] User manual: last-minute changes before V4.5 References:

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Miika Turkia
On Tue, Oct 13, 2015 at 7:52 PM, Dirk Hohndel wrote: > On Tue, Oct 13, 2015 at 07:46:54PM +0300, Miika Turkia wrote: >> On Sun, Oct 11, 2015 at 10:10 PM, Miika Turkia >> wrote: >> > On Sun, Oct 11, 2015 at 8:30 PM, Dirk Hohndel wrote:

Re: Image management, bug fix

2015-10-13 Thread Guido Lerch
Hi Dirk Regards, Guido +41 79 3217739 > Am 13.10.2015 um 17:50 schrieb Dirk Hohndel : > > >> On Oct 13, 2015, at 8:48 AM, Guido Lerch wrote: >> >> Hi Robert >> Before I comment point by point let me mention that is is exploratory and >> that I do not

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 10:10:08AM -0700, Dirk Hohndel wrote: > > > cannot open "/home/mturkia/.subsurface/hashes" > > ---8<--- > > > > The last line is the only one related to the change to .subsurface > > directory. Apparently .subsurface is not created even though it is > > used for

Re: Image management, bug fix

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 07:10:19PM +0200, Guido Lerch wrote: > > > > Yes. And you can test this locally as you can store to local git > > repositories as well. And yes, the git storage is set up to store pictures > > as part of the git storage. Exactly so that you could have them show up on > >

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Miika Turkia
On Sun, Oct 11, 2015 at 10:10 PM, Miika Turkia wrote: > On Sun, Oct 11, 2015 at 8:30 PM, Dirk Hohndel wrote: >> On Sun, Oct 11, 2015 at 12:04:11PM +0300, Lubomir I. Ivanov wrote: >>> On 11 October 2015 at 11:28, Lubomir I. Ivanov

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 08:06:42PM +0300, Miika Turkia wrote: > > Let's see. My configuration is quit old, as yours should be. I have > not tried to clear anything. But I would think that someone else > should run into this when upgrading. > > I have configured Subsurface to use local file as

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Miika Turkia
On Tue, Oct 13, 2015 at 10:05 PM, Robert C. Helling wrote: > Dirk, > > On 13 Oct 2015, at 19:38, Dirk Hohndel wrote: > > Robert, can you make sure that what I did to the hashes makes sense? > > > Indeed, it does. I have to admit I had wondered why my

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Lubomir I. Ivanov
On 13 October 2015 at 20:59, Lubomir I. Ivanov wrote: > On 13 October 2015 at 20:38, Dirk Hohndel wrote: >> On Tue, Oct 13, 2015 at 10:10:08AM -0700, Dirk Hohndel wrote: >>> >>> > cannot open "/home/mturkia/.subsurface/hashes" >>> > ---8<--- >>> > >>> > The

[PATCH] Revert 50421f1f and create the default path in main.cpp

2015-10-13 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" This patch reverts commit 50421f1f. Expose subsurface_mkdir() in qthelper.h as main.cpp already includes it. Once 'default_directory' is obtained call subsurface_mkdir() on it. subsurface_mkdir() will not throw an error if the directory exists

Re: [PATCH] Revert 50421f1f and create the default path in main.cpp

2015-10-13 Thread Dirk Hohndel
> > new patch with fixed typo. :-) > please test! > only tested on Windows 7. This seems obviously correct :-) Tested on Linux. /D ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Dirk Hohndel
On Tue, Oct 13, 2015 at 09:02:34PM +0300, Lubomir I. Ivanov wrote: > On 13 October 2015 at 20:59, Lubomir I. Ivanov wrote: > > On 13 October 2015 at 20:38, Dirk Hohndel wrote: > >> On Tue, Oct 13, 2015 at 10:10:08AM -0700, Dirk Hohndel wrote: > >>> > >>> >

[PATCH] Revert 50421f1f and create the default path in main.cpp

2015-10-13 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" This patch reverts commit 50421f1f. Expose subsurface_mkdir() in qthelper.h as main.cpp already includes it. Once 'default_directory' is obtained call subsurface_mkdir() on it. default_directory() will not throw an error if the directory exists

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Lubomir I. Ivanov
On 13 October 2015 at 20:38, Dirk Hohndel wrote: > On Tue, Oct 13, 2015 at 10:10:08AM -0700, Dirk Hohndel wrote: >> >> > cannot open "/home/mturkia/.subsurface/hashes" >> > ---8<--- >> > >> > The last line is the only one related to the change to .subsurface >> > directory.

Re: Image management, bug fix

2015-10-13 Thread Tomaz Canabrava
Hullo, Since this escalated a bit ( and since I'm the one that will probably code the interfaces ) :) I think that the image handling system should: 1 - send all images to the git server when in idle or upon request This is the only way to make sure that all images will appear in all devices

Re: [PATCH 1/1] Use ~/.subsurface as default directory on Linux

2015-10-13 Thread Robert C. Helling
Dirk, > On 13 Oct 2015, at 19:38, Dirk Hohndel wrote: > > Robert, can you make sure that what I did to the hashes makes sense? Indeed, it does. I have to admit I had wondered why my divelist was always marked changed when opening but did not have the time to track this down.

Re: [PATCH] Parse html links in the Notes section.

2015-10-13 Thread K. "pestophagous" Heller
On Tue, Oct 13, 2015 at 7:32 AM, Dirk Hohndel wrote: > > Neat. I have a few concerns with the code, but the idea itself is a cool > addition. Obviously post-4.5 :-) Yes :) I half-expected to not see any reply to this until after 4.5. I do not want to be a distraction from that

[PATCH] Update spanish translation of user manual to english 8d546bc

2015-10-13 Thread Salvador Cuñat
Signed-off-by: Salvador Cuñat --- Documentation/user-manual_es.txt | 113 ++- 1 file changed, 76 insertions(+), 37 deletions(-) diff --git a/Documentation/user-manual_es.txt b/Documentation/user-manual_es.txt index 9b923cc..579990b

Re: towards 4.5

2015-10-13 Thread Salvador Cuñat
Good night. 2015-10-13 22:44 GMT+02:00 Dirk Hohndel : > Here's what's on my list > > - user manual translation updates for ES, RU > > Have just send a patch for user-manual_es.txt with latest updates. Spanish in transifex is 100% at this time. Regards. Salva.