Re: Crash Mobile build 758 on Android 5.1.1

> On 31 Jan 2016, at 21:02, Dirk Hohndel wrote: > > >> On Jan 31, 2016, at 11:55 AM, Willem Ferguson >> wrote: >> >> On 31/01/2016 21:29, Dirk Hohndel wrote: >>> On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: Ok, 675 works and 676 crashes. Hope this helps a bit? >

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, 31 Jan 2016 13:24:30 -0800 Dirk Hohndel wrote: > > Files in the attached, created with 758 (a clean re-install, and > > still behaving the same way.) A quick look through the files > > doesn't reveal anything that I can see, but there's obviously > > something odd somewhere in there. > >

Re: Crash Mobile build 758 on Android 5.1.1

On 31 January 2016 at 23:24, Dirk Hohndel wrote: > On Sun, Jan 31, 2016 at 11:12:36PM +0200, Lubomir I. Ivanov wrote: >> >> 763 Working perfectly. >> > >> > Excellent. So now we need to figure out how to move the dive # up again so >> > we don't run out of space... >> > Patches welcome :-) >> > >

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, Jan 31, 2016 at 11:12:36PM +0200, Lubomir I. Ivanov wrote: > >> 763 Working perfectly. > > > > Excellent. So now we need to figure out how to move the dive # up again so > > we don't run out of space... > > Patches welcome :-) > > > > i've tried to find the regression commit in qtbase/gui

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, Jan 31, 2016 at 09:08:44PM +, David Tillotson wrote: > > On Sun, Jan 31, 2016 at 07:40:35PM +, David Tillotson wrote: > > > > > > This version fixes my issue of consistent crashes when opening ths > > > quarry dives. > > > > Or even better, could you (on the desktop) export one of

Re: Crash Mobile build 758 on Android 5.1.1

On 31 January 2016 at 22:02, Dirk Hohndel wrote: > >> On Jan 31, 2016, at 11:55 AM, Willem Ferguson >> wrote: >> >> On 31/01/2016 21:29, Dirk Hohndel wrote: >>> On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: Ok, 675 works and 676 crashes. Hope this helps a bit? >>> It

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, 31 Jan 2016 11:46:04 -0800 Dirk Hohndel wrote: > On Sun, Jan 31, 2016 at 07:40:35PM +, David Tillotson wrote: > > > > This version fixes my issue of consistent crashes when opening ths > > quarry dives. > > Or even better, could you (on the desktop) export one of those dives > as XM

Re: [PATCH] Separate download code sharable between desktop & mobile

On Sun, Jan 31, 2016 at 10:27:01PM +0200, Willem Ferguson wrote: > The object here was just to get the desktop version to work normally, given > the removal of some code. > Filtering is certainly a priority, but probably implementing another method > of the same class. That seems like a sensible p

Fwd: Re: [PATCH] Separate download code sharable between desktop & mobile

On 31/01/2016 20:36, Dirk Hohndel wrote: I'm not sure why you say that. The issue that I see is the filtering that's missing (i.e., just shoing the support DCs), but the models should work in QML with very little modification. These comments are very valuable to me. The object here was just

Re: Crash Mobile build 758 on Android 5.1.1

> On Jan 31, 2016, at 11:55 AM, Willem Ferguson > wrote: > > On 31/01/2016 21:29, Dirk Hohndel wrote: >> On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: >>> Ok, 675 works and 676 crashes. >>> Hope this helps a bit? >> It should. >> >> Please try -763 >> > 763 Working perfectl

Re: Crash Mobile build 758 on Android 5.1.1

On 31/01/2016 21:40, David Tillotson wrote: Please try -763 This version fixes my issue of consistent crashes when opening ths quarry dives. Oddly, the edit button is now non-functional, rather than randomly functional. Looks like edit works ok with me. Have not tested extensively. Kind rega

Re: Crash Mobile build 758 on Android 5.1.1

On 31/01/2016 21:29, Dirk Hohndel wrote: On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: Ok, 675 works and 676 crashes. Hope this helps a bit? It should. Please try -763 /D 763 Working perfectly. wf ___ subsurface mailing list su

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, Jan 31, 2016 at 07:40:35PM +, David Tillotson wrote: > > This version fixes my issue of consistent crashes when opening ths > quarry dives. Can you show a screen shot of one of the dives that crash with 758 but don't crash with 763? Or even better, could you (on the desktop) export o

Re: Crash Mobile build 758 on Android 5.1.1

On 31 January 2016 19:29:38 GMT+00:00, Dirk Hohndel wrote: >On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: >> Ok, 675 works and 676 crashes. >> Hope this helps a bit? > >It should. > >Please try -763 > >/D >___ >subsurface mailing list

Re: Crash Mobile build 758 on Android 5.1.1

On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote: > Ok, 675 works and 676 crashes. > Hope this helps a bit? It should. Please try -763 /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/c

Re: Crash Mobile build 758 on Android 5.1.1

Ok, 675 works and 676 crashes. Hope this helps a bit? Kind regards, willem ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Crash Mobile build 758 on Android 5.1.1

On Mon, Feb 01, 2016 at 06:15:21AM +1100, Rick Walsh wrote: > > If our build environments are similar enough. The offending commit will be > mine, 1030cb2. Oops. That build (of mine) failed for Willem. The thing is I > thought it was the same as 675, which worked for him. We should know in a few

Re: Crash Mobile build 758 on Android 5.1.1

On 1 Feb 2016 06:07, "Dirk Hohndel" wrote: > > > > On Jan 31, 2016, at 11:05 AM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > > > > On 31/01/2016 20:49, Dirk Hohndel wrote: > >> 1030cb2 is -676 > >> 464b88f is -675 > >> > >> But as Lubomir points out, between different Qt and potent

Re: Crash Mobile build 758 on Android 5.1.1

> On Jan 31, 2016, at 11:05 AM, Willem Ferguson > wrote: > Rick's rationale is to track down the specific patch that causes the crash. > It is later than build 675 and earlier than 689. So I have been running > various builds of Subsurface-mobile, checking which builds run as expected > and w

Re: Crash Mobile build 758 on Android 5.1.1

> On Jan 31, 2016, at 11:05 AM, Willem Ferguson > wrote: > > On 31/01/2016 20:49, Dirk Hohndel wrote: >> 1030cb2 is -676 >> 464b88f is -675 >> >> But as Lubomir points out, between different Qt and potentially different >> mobile-components, there is some risk that your builds aren't consiste

Re: Crash Mobile build 758 on Android 5.1.1

On 31/01/2016 20:49, Dirk Hohndel wrote: 1030cb2 is -676 464b88f is -675 But as Lubomir points out, between different Qt and potentially different mobile-components, there is some risk that your builds aren't consistent with mine. Especially when it comes to such odd crashes. I have actually

Re: Crash Mobile build 758 on Android 5.1.1

> On Jan 31, 2016, at 2:29 AM, Rick Walsh wrote: > That is interesting. Either there's something your phone doesn't like about > my builds (work fine on my phone), or I was wrong about 675 being commit > 1030cb2. I assumed 758 was built from the curreny git master and I counted > back. But may

Re: [PATCH] Separate download code sharable between desktop & mobile

On Sun, Jan 31, 2016 at 07:47:40PM +0200, Willem Ferguson wrote: > [PATCH] Separate download code sharable between desktop & mobile > > This is a very first step that extracts code from > downloadfromdivecomputer into a separate class called > "downloadmanager". The purpose of this

[PATCH] Separate download code sharable between desktop & mobile

[PATCH] Separate download code sharable between desktop & mobile This is a very first step that extracts code from downloadfromdivecomputer into a separate class called "downloadmanager". The purpose of this patch is to do some separation of sharable code without affecting the

Re: Crash Mobile build 758 on Android 5.1.1

On 31 January 2016 at 15:19, Lubomir I. Ivanov wrote: > > *) to get the XXX digit of a commit: >> git describe HEAD --tags --abbrev=12 > v4.5.2-758-g0eae59bcd29b >> git describe 1030cb2 --tags --abbrev=12 > v4.5.2-676-g1030cb265a46 > for the full list: $ git rev-list v4.5.3..HEAD | while read -r

Re: Crash Mobile build 758 on Android 5.1.1

On 31 January 2016 at 12:29, Rick Walsh wrote: > > That is interesting. Either there's something your phone doesn't like about > my builds (work fine on my phone), or I was wrong about 675 being commit > 1030cb2. I assumed 758 was built from the curreny git master and I counted > back. But maybe 7

[PATCH 2/2] Attempt to detect time format on CSV import

This attempts to detect the time format when initially importing a CSV file. Well, only the minutes:seconds notation is detected currently. Signed-off-by: Miika Turkia --- desktop-widgets/divelogimportdialog.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/desktop-widgets/divelogimp

[PATCH 1/2] Attempt to detect date format on CSV import

This tries to detect the date format when initially reading a CSV file for importing. Signed-off-by: Miika Turkia --- desktop-widgets/divelogimportdialog.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/desktop-widgets/divelogimportdialog.cpp b/desktop-widgets/divelogimp

Re: Crash Mobile build 758 on Android 5.1.1

On 31 Jan 2016 20:54, "Willem Ferguson" wrote: > > On 31/01/2016 10:49, Rick Walsh wrote: >> >> >> >> On 31 January 2016 at 19:37, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: >>> >>> Rick, unfortunately both of the two experimental builds crash on my phone. >>> Kind regards >>> Will

Re: Crash Mobile build 758 on Android 5.1.1

On 31/01/2016 10:49, Rick Walsh wrote: On 31 January 2016 at 19:37, Willem Ferguson > wrote: Rick, unfortunately both of the two experimental builds crash on my phone. Kind regards Willem That's not all bad - it should mean that the s