Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-17 Thread Dirk Hohndel
> On Nov 17, 2015, at 6:50 AM, Sebastian Kügler wrote: > > On Tuesday, November 17, 2015 04:43:41 PM Lubomir I. Ivanov wrote: >> On 17 November 2015 at 16:35, Lubomir I. Ivanov wrote: >>> On 16 November 2015 at 23:47, Sebastian Kügler wrote:

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-17 Thread Sebastian Kügler
On Tuesday, November 17, 2015 04:43:41 PM Lubomir I. Ivanov wrote: > On 17 November 2015 at 16:35, Lubomir I. Ivanov wrote: > > On 16 November 2015 at 23:47, Sebastian Kügler wrote: > >> On Friday, November 13, 2015 23:59:09 Lubomir I. Ivanov wrote: > >

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-17 Thread Lubomir I. Ivanov
On 17 November 2015 at 16:35, Lubomir I. Ivanov wrote: > On 16 November 2015 at 23:47, Sebastian Kügler wrote: >> On Friday, November 13, 2015 23:59:09 Lubomir I. Ivanov wrote: > > changing ApplicationWindow to Window and keeping everything else makes it >

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-16 Thread Lubomir I. Ivanov
On 16 November 2015 at 23:47, Sebastian Kügler wrote: > On Friday, November 13, 2015 23:59:09 Lubomir I. Ivanov wrote: >> > Do I make sense to you? If not, proof-of-concept attached. It's quite >> > minimal >> > and only shows the very basic mechanism. >> > >> >> nice...so

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-16 Thread Miika Turkia
On Tue, Nov 17, 2015 at 12:47 AM, Sebastian Kügler wrote: > On Tuesday, November 17, 2015 00:35:49 Lubomir I. Ivanov wrote: >> >> nice...so ListView pretty much does what's required here out of the >> >> box. also Flickable and MouseAreas in the delegate item *just work* - >> >>

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Joakim Bygdell
> On 12 Nov 2015, at 13:22, Sebastian Kügler wrote: > > On Wednesday, November 11, 2015 20:45:53 Dirk Hohndel wrote: >> On Thu, Nov 12, 2015 at 01:27:54AM +, Sebastian Kügler wrote: >>> Heya, >>> >>> Some more work on the mobile version, especially on the divelist and >

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Sebastian Kügler
On Thursday, November 12, 2015 19:56:41 Linus Torvalds wrote: > On Nov 12, 2015 19:34, "Dirk Hohndel" wrote: > > > >> On Nov 12, 2015, at 3:12 PM, Lubomir I. Ivanov wrote: > >> > >> so here is the visual of the working POC: > >>

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Lubomir I. Ivanov
On 13 November 2015 at 23:14, Sebastian Kügler wrote: > Hah, nice! > > For my taste, the code especially in SwipeArea is a bit low-level, making it > hard to maintain. The javascript running on the change notifier signals may > also slow down the whole thing. In my experience,

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Sebastian Kügler
On Friday, November 13, 2015 14:32:34 Lubomir I. Ivanov wrote: > It's coming along. How hard will it be to swipe sideways from dive to > dive > when in dive detail mode? So I tap on one of the dives and I just swipe > left and right to get to the previous / next dive instead of

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Linus Torvalds
On Fri, Nov 13, 2015 at 1:16 PM, Sebastian Kügler wrote: > On Thursday, November 12, 2015 19:56:41 Linus Torvalds wrote: >> >> I never even knew before this masterpiece that I needed sharks in my >> profile. But now that I have seen them, nothing else will ever do. >> >> The only

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Dirk Hohndel
> On Nov 13, 2015, at 3:26 PM, Linus Torvalds > wrote: > > On Fri, Nov 13, 2015 at 1:16 PM, Sebastian Kügler wrote: >> On Thursday, November 12, 2015 19:56:41 Linus Torvalds wrote: >>> >>> I never even knew before this masterpiece that I needed

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-13 Thread Dirk Hohndel
> On Nov 13, 2015, at 1:59 PM, Lubomir I. Ivanov wrote: > >> I quite like what you have done in the delegate. I'd like to split viewing >> and >> editing dives into separate UIs, one optimized for viewing, one optimized for >> editing (e.g. showing the profile in the

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-11 Thread Dirk Hohndel
On Thu, Nov 12, 2015 at 01:27:54AM +, Sebastian Kügler wrote: > Heya, > > Some more work on the mobile version, especially on the divelist and details. Great! > - bugfix for label overflow in dive list > - don't create the expensive profilewidget for every frame painted by the item > - kill

Re: [PATCH] mobile: divedetails page etc. improvements

2015-11-11 Thread Sebastian Kügler
On Thursday, November 12, 2015 01:27:54 Sebastian Kügler wrote: > Some more work on the mobile version, especially on the divelist and > details. I just noticed that a new file CloudStorage.qml slipped in, which isn't used yet. I suggest to leave that in, it will be used shortly, even if it's

[PATCH] mobile: divedetails page etc. improvements

2015-11-11 Thread Sebastian Kügler
Heya, Some more work on the mobile version, especially on the divelist and details. - bugfix for label overflow in dive list - don't create the expensive profilewidget for every frame painted by the item - kill warnings due to conditional build of subsurface-mobile (#0006) - other cleanups