Re: [PATCH 0/3] Misc smaller patches

On Sat, Jul 22, 2017 at 09:35:49PM +0300, Miika Turkia wrote: > On Sat, Jul 22, 2017 at 8:56 PM, Dirk Hohndel <d...@hohndel.org> wrote: > > On Sat, Jul 22, 2017 at 08:50:33AM -0700, Linus Torvalds wrote: > >> > >> > >> This is a set of three sm

Re: [PATCH 0/3] Misc smaller patches

On Sat, Jul 22, 2017 at 8:56 PM, Dirk Hohndel <d...@hohndel.org> wrote: > On Sat, Jul 22, 2017 at 08:50:33AM -0700, Linus Torvalds wrote: >> >> >> This is a set of three small patches that fix some particular issue that >> came up while looking at the gas pressur

Re: [PATCH 0/3] Misc smaller patches

On Sat, Jul 22, 2017 at 08:50:33AM -0700, Linus Torvalds wrote: > > > This is a set of three small patches that fix some particular issue that > came up while looking at the gas pressure handling for multiple cylinders. Those all look good. I notice that we now reliably fa

[PATCH 0/3] Misc smaller patches

This is a set of three small patches that fix some particular issue that came up while looking at the gas pressure handling for multiple cylinders. The first one is really entirely independent of the others, and fixes the gas use reporting issue that Davide has had. The second one

patches for user manual

I re-sent three patches to the user manual to Dirk. It seems these three might have been missed. Kind regards, willem ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo

Re: [PATCHES] Two minor planner improvements

rface-divelog.org, d...@hohndel.org, "Robert C. > Helling" > *Subject:* Re: [PATCHES] Two minor planner improvements > > Hallo Dirk, hallo Robert, > > would it be possible to get another windows test version with Roberts > latest fixes for the planner? > > > Best reg

Re: [PATCHES] Two minor planner improvements

elling" <hell...@atdotde.de> Subject: Re: [PATCHES] Two minor planner improvements Hallo Dirk, hallo Robert, would it be possible to get another windows test version with Roberts latest fixes for the planner? Best regards Stefan -- Stefan Fuchs Banzhaldenstr. 66 70469 Stuttgart E-Mail:

Re: [PATCHES] Two minor planner improvements

Hallo Dirk, hallo Robert, would it be possible to get another windows test version with Roberts latest fixes for the planner? Best regards Stefan -- Stefan Fuchs Banzhaldenstr. 66 70469 Stuttgart E-Mail: sfu...@gmx.de ___

Re: [PATCHES] Two minor planner improvements

On Mon, Dec 26, 2016 at 07:06:40PM +0100, Robert Helling wrote: > It seems these two were forgotten. Sorry. Just added them. /D ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: [PATCHES] Two minor planner improvements

It seems these two were forgotten. > On 15 Dec 2016, at 23:25, Robert Helling <hell...@atdotde.de> wrote: > > These two patches implement suggestions from trac. > > Best > Robert > > <0001-Set-surface-pressure-and-salinity-correctly-when-repla.txt

[PATCHES] Two minor planner improvements

These two patches implement suggestions from trac. Best Robert From 040b804c1c451963531db6d0da31e61b853747ae Mon Sep 17 00:00:00 2001 From: "Robert C. Helling" <hell...@atdotde.de> Date: Thu, 15 Dec 2016 23:02:32 +0100 Subject: [PATCH 1/2] Set surface pressure and salinit

Re: [PATCH] Re: Two patches for dive plan

On 27 November 2016 at 21:35, Robert Helling wrote: > > Am 26.11.2016 um 23:24 schrieb Anton Lundin : > > > It depends if i step to +1 from +0 or from +2. Timing issue somewhere? > Weird numeric instability? > > Anton, I got even weirder numeric instability

[PATCH] Re: Two patches for dive plan

Am 26.11.2016 um 23:24 schrieb Anton Lundin :It depends if i step to +1 from +0 or from +2. Timing issue somewhere?Weird numeric instability? Excellent spot! It first compiled the planner notes before computing the new gradient factors.Here is a patch.BestRobertFrom

Re: [PATCHES] Two patches for dive plan

On 23 November, 2016 - Robert Helling wrote: > From 404205c8f1aa37be374c2ba17acceb3541620bce Mon Sep 17 00:00:00 2001 > From: "Robert C. Helling" > Date: Wed, 23 Nov 2016 11:50:50 +0100 > Subject: [PATCH 2/2] Show effective gradient factors for VPMB-plans > To:

Re: [PATCHES] Two patches for dive plan

Rick, > Am 24.11.2016 um 04:10 schrieb Rick Walsh : > > One question: is there a reason why we can't access > displayed_dive.dc.duration.seconds instead of creating a new function to > iterate through all the data points to get the runtime? I found that

Re: [PATCHES] Two patches for dive plan

Hi Robert, On 23 November 2016 at 22:05, Robert Helling <hell...@atdotde.de> wrote: > > Hi, > > here are two patches to improve the dive plan. The first simply shows the > total runtime on top of the plan. This is one of the most important data of > a plan and should be

[PATCHES] Two patches for dive plan

6,11 @@ bool plan(struct diveplan *diveplan, char **cached_datap, bool is_planner, bool add_plan_to_notes(diveplan, _dive, show_disclaimer, error); fixup_dc_duration(_dive.dc); + if(prefs.deco_mode == VPMB) { + diveplan->eff_gfhigh = rint(100.0 * regressionb()); +

[PATCHES] Deco mode preferences

Hi, here are two patches, the first fixed a typo of Tomaz’, the second greys out labels of settings not in use. Best Robert From 28bebc9abcd440f69f9bce87e218bcca4d2afff0 Mon Sep 17 00:00:00 2001 From: "Robert C. Helling" <hell...@atdotde.de> Date: Wed, 2 Nov 2016 09:54:

Re: final patches for the preferences unittests

Tomaz, Thanks for this long series of patches. Most of them I was able to validate by reading the code, a couple will need more testing (especially this last one that I'm responding to). But a big THANKS for your work here, this was a big part of what I was waiting for before continuing towards

Re: final patches for the preferences unittests

This last patch should fix robert's issues with the different deco models for display and plan. Robert issues should be fixed with this path. The issue was that the preferences wasn't hoocked up (it was actually partially hoocked in the wrong pref) On Tue, Nov 1, 2016 at 3:45 PM, Tomaz

Re: final patches for the preferences unittests

On Tue, Nov 1, 2016 at 3:25 PM, Tomaz Canabrava wrote: > more fixes regarding preferences > > On Tue, Nov 1, 2016 at 2:46 PM, Tomaz Canabrava > wrote: > >> bugfixes regarding preferences >> >> still checking for more. >> (the font issue that willem said

Re: final patches for the preferences unittests

more fixes regarding preferences On Tue, Nov 1, 2016 at 2:46 PM, Tomaz Canabrava wrote: > bugfixes regarding preferences > > still checking for more. > (the font issue that willem said is fixed on this series) > > Tomaz > > On Tue, Nov 1, 2016 at 12:06 PM, Tomaz Canabrava

Re: final patches for the preferences unittests

bugfixes regarding preferences still checking for more. (the font issue that willem said is fixed on this series) Tomaz On Tue, Nov 1, 2016 at 12:06 PM, Tomaz Canabrava wrote: > FINALLY > this finishes the unittests - sorry for all delays. > > I'll now look for

final patches for the preferences unittests

FINALLY this finishes the unittests - sorry for all delays. I'll now look for misbehaving preferences, like the one willan complained. Tomaz From 7437265091fb221578a09b26199e1eea18a523e0 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 1 Nov 2016 11:16:50 +0100

Re: Missing patches

Answering via phone - I managed to do around 15 patches this week - there are more comming, and also I'll work on this weekend. So I hope to finish this. Em 19 de out de 2016 20:29, "Robert Helling" <hell...@atdotde.de> escreveu: > > Am 19.10.2016 um 20:20 schrie

Re: Missing patches

> Am 19.10.2016 um 20:20 schrieb Robert Helling <hell...@atdotde.de>: > > Hi Dirk, > > you asked on IRC which patches are missing from my perspective in master. > This is what I have in my master but apparently is not in origin/master: > > The two patches of Ric

Re: [PATCHES] Vary undersaturated portion of heatmap according inert gas

> > -- Forwarded message -- > From: Rick Walsh <rickmwa...@gmail.com> > To: Robert Helling <hell...@atdotde.de> > Cc: "subsurface@subsurface-divelog.org" <subsurface@subsurface-divelog.org > > > Date: Wed, 19 Oct 2016 08:48:57 +

Re: [PATCHES] Vary undersaturated portion of heatmap according inert gas

On 18 October 2016 at 20:55, Robert Helling wrote: > Will try. I definitely like patch 2, that’s a no-brainer. > > For patch 1, I see your point (the user can see if on-gasing is > happening). I am not yet convinced, though. the trouble I am having is > “what is the heat-map

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > > ah, if what you have now works, then that's fine :) > > was something to try if it wasn't working yet :) > > So here are the kirigami patches that I now use. The last one I don't thanks, I'll take a look at all of them > t

Re: Kirigami patches

irigami.pri file from the Subsurface-mobile.pro file? And I assume > > that i then don't need much of what I spent all weekend trying to make > > work? > > ah, if what you have now works, then that's fine :) > was something to try if it wasn't working yet :) So here are the

Re: Kirigami patches

> On Aug 16, 2016, at 6:48 AM, Marco Martin wrote: > > On Tuesday 16 August 2016, Dirk Hohndel wrote: >> Just to make sure I understand this correctly... You are suggesting that I >> shouldn't build Kirigami as a separate library, but that I should include >> the kirigami.pri

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > Just to make sure I understand this correctly... You are suggesting that I > shouldn't build Kirigami as a separate library, but that I should include > the kirigami.pri file from the Subsurface-mobile.pro file? And I assume > that i then don't need

Re: Kirigami patches

-- Sent from my phone On August 16, 2016 5:59:06 AM PDT, Marco Martin wrote: >On Tuesday 16 August 2016, Tomaz Canabrava wrote: >> > > - use the .pri file when directly linking in kirigami into the >(parent) >> > > project (include directive in PROJECT.pro), then the

Re: Kirigami patches

On Tuesday 16 August 2016, Tomaz Canabrava wrote: > > > - use the .pri file when directly linking in kirigami into the (parent) > > > project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is > > > not necessary. using qmake this seems to be the easiest way and at > > > least seems

Re: Kirigami patches

Subsue Em 16 de ago de 2016 04:43, "Marco Martin" escreveu: > > On Tuesday 16 August 2016, Martin Gysel wrote: > > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > > > It's pretty clear that no one ever tested the kirigami.pro qmake file. > > > The second patch I'm not 100% sure

Re: Kirigami patches

On Tuesday 16 August 2016, Dirk Hohndel wrote: > It's pretty clear that no one ever tested the kirigami.pro qmake file. The > second patch I'm not 100% sure about, but it seems to match what the > documentation tells us SHOULD be done. because with the pro it was supposed to build the dynamic

Re: Kirigami patches

Am 16.08.2016 um 01:55 schrieb Dirk Hohndel: > It's pretty clear that no one ever tested the kirigami.pro qmake file. The > second patch I'm not 100% sure about, but it seems to match what the > documentation tells us SHOULD be done. maybe my understanding of the qt build system, tools and

Kirigami patches

It's pretty clear that no one ever tested the kirigami.pro qmake file. The second patch I'm not 100% sure about, but it seems to match what the documentation tells us SHOULD be done. /D >From 8e4307346614943a940f11d2ee6159886c54ee83 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel

some patches regarding the preferences mess

This is by no means complete, just a "I'm actually working" this should improve a few things and break others, so don't merge this yet, it's mostly a WIP. It's ~mainly~ finished, I just need to finish *testing* and fixing a couple of occasional bugs. Tomaz. From

Re: patches pushed to master

On Sat, Jul 09, 2016 at 10:37:25PM +0200, Axel Richter wrote: > Am 09.07.2016 um 22:05 schrieb Dirk Hohndel: > > > > Has anyone figured out the new Kirigami stuff? > > Hi Dirk, > > Qt 5.7 and kirigami works for the android build with the following patch: Could I get this as a proper patch that

Re: patches pushed to master

Dirk, > Am 09.07.2016 um 22:05 schrieb Dirk Hohndel : > > Next week Linus and I will be in Tokyo. That may > actually mean that I'll have at least SOME time to look at Subsurface. maybe you find time to make new windows binaries available. Then the reporter of the time zone

Re: [PATCH 00/11] Use cylinder index in divedatapoint structure and best mix patches

ode overall and makes it easier to manage > modifying multiple cylinders without model getting lost. The third patch > takes advantage of this and fixes #970 (update cylinder deco MOD when the > deco pO2 is changed). > > The remaining patches are reworked from my previous series improving

Re: patches pushed to master

have patches that I have overlooked, if you have things that you want my opinion on, now may be a great time to (re-)send those. The following week we'll be on a liveaboard with no phone or internet. That means that Subsurface will likely get some critical testing, but of course it also means

patches pushed to master

as a maintainer. Guilty as charged. I'd love to promise that it will be all better now, but that would be silly because it won't. Next week Linus and I will be in Tokyo. That may actually mean that I'll have at least SOME time to look at Subsurface. So if you have patches that I have overlooked, if you have

[PATCH 0/2] Some initial Suunto EON Steel CCR patches

The first patch is something I should have sent in long ago, rather than always do ad-hoc every single time I want to check new fields from the dive computer: add debug support for showing all the dive descriptors. That patch has no semantic difference, but it means that the download logs

[PATCH 0/2] Minor fairly cosmetic patches

Here are two trivial patches. The first one I've had pending for a while and fixes a memory leak (not big, but I happened to notice it when running valgrind), and the second one removes the code to ignore surface samples at divecomputer import time. That second one will mean that we'll get

Re: [PATCHES] 4.5.5

> On Mar 23, 2016, at 1:23 PM, Henrik Brautaset Aronsen > wrote: > > On Wed, Mar 23, 2016 at 8:47 AM, Robert Helling > wrote: > b) Get rid of the maximum value properly (not by making it ridiculously big > but by

Re: [PATCHES] 4.5.5

On Wed, Mar 23, 2016 at 8:47 AM, Robert Helling wrote: > b) Get rid of the maximum value properly (not by making it ridiculously > big but by also deleting it from the .ui file). In any case, what is it > good for? Why do we want to prevent the user from doing stupid things?

Re: [PATCHES] 4.5.5

Dirk,On 23.03.2016, at 15:52, Dirk Hohndel wrote:Since this was already pushed out, it has to be a second patch that fixesthings. Otherwise this would change a git repository that others havepulled from and pulls wouldn't be 'fast forward' anymore.here you go.From

Re: [PATCHES] 4.5.5

On Wed, Mar 23, 2016 at 08:47:36AM +0100, Robert Helling wrote: > > you caught me here but your „solution“ actually makes it worse: Ha. > The problem is when switching from PSI to bar: You start, say with a value of > 580psi (roughly 40bar). Then you change units, this makes the above code >

Re: [PATCHES] 4.5.5

> On 23.03.2016, at 00:14, Dirk Hohndel wrote: > > Thanks, Robert. > > I have a couple of small concerns. Given that it's past midnight in > Germany, I'll just fix them in your commit > > /D > >> diff --git a/desktop-widgets/diveplanner.cpp >>

Re: [PATCHES] Re: 4.5.5

Thanks, Robert. I have a couple of small concerns. Given that it's past midnight in Germany, I'll just fix them in your commit /D > diff --git a/desktop-widgets/diveplanner.cpp b/desktop-widgets/diveplanner.cpp > index e6fe612..32797f0 100644 > --- a/desktop-widgets/diveplanner.cpp > +++

[PATCHES] Re: 4.5.5

On 22.03.2016, at 19:45, Robert C. Helling wrote:Yesterday, I filed two bugs that should easily be fixed: Make the reserve of recreational mode units aware and warn when running as root. here is the patch that fixes the first:From

Re: [PATCH] OSX build patches against v4.5-branch

On Wed, Mar 16, 2016 at 09:31:44AM +0100, Jeroen Massar wrote: > > These are quite close to the changes I needed for the patches against > master. > > I did add "user home dir Qt5.5/5.6" detection to this too, just in case > as we have that in master. Good idea. T

[PATCH] OSX build patches against v4.5-branch

Hola, These are quite close to the changes I needed for the patches against master. I did add "user home dir Qt5.5/5.6" detection to this too, just in case as we have that in master. As noted, I'll do full-clean builds coming weekend, but I think this resolves the biggest chunks

[PATCH] 3 tiny OSX build patches (against master)

. I went for an error, as auto installing that causes possibly unexpected popups for accepting apple licenses, thus better to error out at that point. Find attached three separate tiny patches: - [PATCH 1/3] Debug reminder: how to get more verbose details out of cmake - [PATCH 2/3] Detect

more cleanup patches to remove tons of warnings while building for iOS

I hate warnings. 0001-Clean-DiveCartesianAxis.patch Description: Binary data 0002-Clean-DiveEventItem.patch Description: Binary data 0003-Clean-DiveProfileItem.patch Description: Binary data 0004-Clean-Profilewidget2.patch Description: Binary data 0005-Clean-TankItem.patch Description:

silence-warning patches

we hare more than 1000 warnings while building for iOS we need to silence those because they are hiding possible real errors this is the beginning of that work. 0001-Silence-warning-about-unued-parameter.patch Description: Binary data

Re: subsurface-ios first patches

eLists file (it reverts to master) and removes some >> noise on the dumb project for iOS. >> >> >> On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava <tcanabr...@kde.org> >> wrote: >> >>> >>> >>> On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel &

Re: subsurface-ios first patches

016 at 2:01 PM, Tomaz Canabrava <tcanabr...@kde.org> > wrote: > >> >> >> On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel <d...@hohndel.org> wrote: >> >>> Sadly the patches are base64 encoded (typical Mac issue) and I can't >>> easily quote t

Re: subsurface-ios first patches

this cleans the CMakeLists file (it reverts to master) and removes some noise on the dumb project for iOS. On Sat, Mar 5, 2016 at 2:01 PM, Tomaz Canabrava <tcanabr...@kde.org> wrote: > > > On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel <d...@hohndel.org> wrote: > >>

Re: subsurface-ios first patches

On Sat, Mar 5, 2016 at 1:50 PM, Dirk Hohndel <d...@hohndel.org> wrote: > Sadly the patches are base64 encoded (typical Mac issue) and I can't > easily quote them in there. > > A few comments: > > If you don't use cmake, why patches to the CMakeLists.txt file? That seem

Re: subsurface-ios first patches

Sadly the patches are base64 encoded (typical Mac issue) and I can't easily quote them in there. A few comments: If you don't use cmake, why patches to the CMakeLists.txt file? That seems to make no sense (oh, and it's whitespace damaged, too) There are also changes to the CMakeLists.txt files

Re: subsurface-ios first patches

On Sat, Mar 5, 2016 at 1:43 PM, Dirk Hohndel wrote: > On Sat, Mar 05, 2016 at 01:27:44PM -0300, Tomaz Canabrava wrote: > > people: > > > > This will work only with Qt 5.6 for now, so don't even try with 5.5 > > the prerequisites should be build for x86_64 bits, and qt 5.5 is

subsurface-ios first patches

people: This will work only with Qt 5.6 for now, so don't even try with 5.5 the prerequisites should be build for x86_64 bits, and qt 5.5 is build for 32 bits, giving tons of erros. I tested the desktop build, it works android build also works, ios builds are currently "meh", they open but don't

Re: CMake patches

It is, I fixed bugs, not those. :D On Thu, Dec 17, 2015 at 5:11 PM, Joakim Bygdell wrote: > > On 17 Dec 2015, at 18:03, Tomaz Canabrava wrote: > > code cleanup and bug fixes. > > > Building for android is broken. > > -- Found ANT: /usr/local/bin/ant >

Re: [PATCHES]

On Tuesday, November 24, 2015 05:49:21 PM Robert Helling wrote: > + QPixmap tempPixmap = pixmap; > + QPainter painter; > + painter.begin(); > + painter.fillRect(pixmap.rect(), QColor(127, 127, 127, 127)); > + painter.end(); I may be dense today, but this seems

[PATCHES]

Hi,I am resending a number of patches I sent earlier which seem to me are still not pushed. Comments or pushes would be appreciated.From 10be4f46ca1a16353cedbd4b709bcc2332d69a78 Mon Sep 17 00:00:00 2001 From: "Robert C. Helling" <hell...@atdotde.de> Date: Mon, 16 Nov 2015 16:10:

Re: Patches to add Context Menu to Images

Hi Robert 2015-11-03 21:34 GMT+01:00 Robert C. Helling <hell...@atdotde.de>: > Hi Guido, > > On 03 Nov 2015, at 17:21, Guido Lerch <guido.le...@gmail.com> wrote: > > This set of patches enables users to use the mouse and a context menu to: > > > I think the in

Re: Patches to add Context Menu to Images

Hi Guido, > On 03 Nov 2015, at 17:21, Guido Lerch <guido.le...@gmail.com> wrote: > > This set of patches enables users to use the mouse and a context menu to: I think the interference between these and my Drag and Drop patch should be very small, so yes, of course, go ah

Patches to add Context Menu to Images

Hi All, Re-submitting. This set of patches enables users to use the mouse and a context menu to: 1. Add images from files/web 2. Delete selected images 3. Delete all images If there is no objection, I am going to work on a local file based management of images again that can be selected via

[PATCH] 2 translation related patches

2 patched attached. 1) Fix broken translation in divelist Fixes a broken translation in the divelist introduced in commit 45b1d0d73db6e21. Now, the (.. dives) string on a trip line in the divelist is translated (again). 2) Add missing tr() implementations One specific string did not

Fwd: minor [PATCHES] for freediving

Now that the new release is out, could we consider adding those patches to the next minor? G -- Forwarded message -- From: Giorgio Marzano <marzano.gior...@gmail.com> Date: 2015-10-11 23:40 GMT+02:00 Subject: minor [PATCHES] for freediving To: Subsurface Mailing List <s

minor [PATCHES] for freediving

Hi, I know that this is something which won't be merged before the next release, but I would like to propose those patches for a (low priority) review. They are all easy, cosmetic and freedive specific (no impact on scuba) 0001-Change-plot-scaling-to-handle-FREEDIVE-mode hacks the autoscaling

Re: three small patches for current git head

is an issue in some environments.) I'll fix this here by making it a calloc as I had originally intended. :facepalm: > > Also, I have provided two (unrelated) bug fixes at: > > > > http://trac.subsurface-divelog.org/ticket/912 and > > http://trac.subsurface-divelog.org/ticket

Re: three small patches for current git head

are the first person who told me that they "lurked without subscribing". That's a new approach :-) As for patches... I love fixes so I'll go and look at github to see if I can find them... but you may have noticed that we mostly do things in email here. Or at least with pull requests sent in

Re: three small patches for current git head

ssue in some environments.) > Also, I have provided two (unrelated) bug fixes at: > > http://trac.subsurface-divelog.org/ticket/912 and > http://trac.subsurface-divelog.org/ticket/820 We generally prefer patches to be sent to the mailing list (to answer your question in the bug comm

three small patches for current git head

Hi all, When you pull the latest from github.com/torvalds/subsurface, if you (like me) are configured to open the default "username.xml" logbook on launch, you will likely discover a problem in commit e8a868aae of Oct 6. See comments here:

[PATCH] The 3 late patches

Hello, I have fixed the 3 late patches and added one more patch for style fixing. -- regards, Gehad From ee86aebe3498debae579db10bc5d3f51f44dd64d Mon Sep 17 00:00:00 2001 From: Gehad elrobey <gehadelro...@gmail.com> Date: Thu, 27 Aug 2015 22:40:04 +0200 Subject: [PATCH 1/4] Printing: s

patches pushed

So I think I have pushed what I had pending - except for my Uemis fixes as I don't want to cause merge issues for Guido. Hopefully we'll get his patches and I can add them tomorrow. I'll kick of new dailies and I hope to do Beta 2 tomorrow or Friday. /D

Re: Uemis patches

Hi Guido, I did some minor changes (commit messages plus a small convention issue... you need the (void)f() cast if you call a function that returns a value and you then ignore it. But your new helper in patch 4 is of type void, so you don't need to cast to (void). Pushed. /D On Mon, Sep 14,

Re: Uemis patches

On Mon, Sep 14, 2015 at 10:27:57PM +0200, Guido Lerch wrote: > Thanks Dirk, sometimes by brain doesnt catch those things. Will send > another bugfix soon. I fixed it as I committed this. no biggie /D > > 2015-09-14 22:26 GMT+02:00 Dirk Hohndel : > > > Hi Guido, > > > > I did

Re: Uemis patches

Thanks Dirk, sometimes by brain doesnt catch those things. Will send another bugfix soon. 2015-09-14 22:26 GMT+02:00 Dirk Hohndel : > Hi Guido, > > I did some minor changes (commit messages plus a small convention issue... > you need the (void)f() cast if you call a function

Re: Uemis patches

The last patch I sent you puts the case back, wait a second I fix that. 2015-09-14 22:35 GMT+02:00 Dirk Hohndel : > On Mon, Sep 14, 2015 at 10:27:57PM +0200, Guido Lerch wrote: > > Thanks Dirk, sometimes by brain doesnt catch those things. Will send > > another bugfix soon. > >

Uemis patches

One bug fix, 2 code simplifications that done have real algorithm changes. -- Best regards, Guido From 75eedcfa1b3f3e57cf667661ca08bf6e52349c1b Mon Sep 17 00:00:00 2001 From: glerch Date: Mon, 14 Sep 2015 10:31:29 +0200 Subject: [PATCH 3/5] Uemis bugfix Fixed a bug in

Re: printing patches

On Fri, Sep 11, 2015 at 8:53 PM, Dirk Hohndel <d...@hohndel.org> wrote: > On Fri, Sep 11, 2015 at 08:50:16PM +0200, Gehad Elrobey wrote: > > > I understand that you are busy, Gehad. Trust me, I know the feeling. > > > Right now I'm holding back Beta 2, waiting for yo

Re: printing patches

On Fri, Sep 11, 2015 at 08:50:16PM +0200, Gehad Elrobey wrote: > > I understand that you are busy, Gehad. Trust me, I know the feeling. > > Right now I'm holding back Beta 2, waiting for your patches. Any idea when > > I might expect them? Or should I just take the patche

Uemis Patches

I am done with my first round of Uemis patches. I am new to this so please forgive me if I still don't get this 100% correct. Dirk advised me to commit as much as possible but I still struggle to make a commit if the commit would not end up in something that is executable. Advise appreciated

Re: Uemis Patches

Hi Guido. This was an excellent series of patches. Well done. I ended up rephrasing the commit messages a but, especially the commit titles, but that's something that I do a lot for other people as well. I may be a bit over zealous there, but I think the result makes it easier to track what's

Re: Uemis Patches

Hi Guido, I mentioned this before, please don't mark comments with "glerch " If someone wants't to know who wrote this and when, they can use "git blame" /D On Thu, Sep 10, 2015 at 07:54:29PM +0200, Guido Lerch wrote: > From a10c9b8877a708157f52e335d4009bb9a22d33c5 Mon Sep 17 00:00:00 2001 >

Re: Uemis Patches

Thanks Dirk, I have a at least one more code optimisation. How would I get the last master and merge my commits that I have not formatted to patches. I was reading the documentation about merge vs. rebase and frankly I don't get it at this point in time. 2015-09-10 21:38 GMT+02:00 Dirk Hohndel

Re: printing patches

On Wed, Sep 9, 2015 at 1:14 PM, Lubomir I. Ivanov <neolit...@gmail.com> wrote: > On 9 September 2015 at 13:15, Dirk Hohndel <d...@hohndel.org> wrote: > > Gehad, Lubomir, > > > > I saw some patches a while ago that Lubomir commented on and that Gehad > > s

printing patches

Gehad, Lubomir, I saw some patches a while ago that Lubomir commented on and that Gehad said he would rework and resubmit. Did I miss the resubmission? I'm trying to make sure nothing gets dropped and we continue to make progress towards 4.5 and printing certainly is one of the cool new features

Re: printing patches

On 9 September 2015 at 14:43, Gehad Elrobey <gehadelro...@gmail.com> wrote: > > > On Wed, Sep 9, 2015 at 1:14 PM, Lubomir I. Ivanov <neolit...@gmail.com> > wrote: >> >> On 9 September 2015 at 13:15, Dirk Hohndel <d...@hohndel.org> wrote: >> > G

Re: printing patches

On Wed, Sep 09, 2015 at 02:14:21PM +0300, Lubomir I. Ivanov wrote: > On 9 September 2015 at 13:15, Dirk Hohndel <d...@hohndel.org> wrote: > > Gehad, Lubomir, > > > > I saw some patches a while ago that Lubomir commented on and that Gehad > > said he woul

Re: printing patches

On 9 September 2015 at 13:15, Dirk Hohndel <d...@hohndel.org> wrote: > Gehad, Lubomir, > > I saw some patches a while ago that Lubomir commented on and that Gehad > said he would rework and resubmit. Did I miss the resubmission? last week Gehad said he is (and/or going to be)

Re: Uemis patches

On Mon, Sep 07, 2015 at 05:14:42PM +0300, Miika Turkia wrote: > > +/* quickhack and workaround to capture the original dive_no > + * i am doing this so I dont have to change the original design > + * but when parsing a dive we never parse the dive number because > +

Re: Uemis patches

On Mon, Sep 07, 2015 at 07:47:24AM -0700, Dirk Hohndel wrote: > > > Last, I am always using tab not white space, any idea what you cause the > > white space instead of the tab ? > > Yes, QtCreator might be "helping" you. It's default setting unfortunately > is the Qt coding style which indents

Uemis patches

All, Attached two Uemis patches after the 10 Dirk applied for me. Patch 0001 Adds the first buddy to the dive Patch 0002 Fixes an issue where the original dive numbers coming from the Uemis where never parsed. -- Best regards, Guido 0001-Adding-buddy-to-dive.patch Description: Binary data

Re: Uemis patches

On Mon, Sep 7, 2015 at 4:45 PM, Guido Lerch <guido.le...@gmail.com> wrote: > All, > > Attached two Uemis patches after the 10 Dirk applied for me. Hello and thanks for the patches. I have some suggestions for a little rework on them. First of all, you should configure your ed

  1   2   3   >