GSoC Status - Week 7 (Customizable prints)

Hello all, This week I was working on the following tasks: - Enhancing the one dive per page template. - Refactoring the Printing class to handle QPrinter and QPixmap. - Implement the Preview section in "TemplateEdit" dialog. - Adding color tab to "TemplateEdit". - Adding color palettes to templa

Re: GSoC Status - Week 7 (Customizable prints)

On 13 July 2015 at 22:35, Gehad Elrobey wrote: > Hello all, > > This week I was working on the following tasks: > > - Enhancing the one dive per page template. > - Refactoring the Printing class to handle QPrinter and QPixmap. > - Implement the Preview section in "TemplateEdit" dialog. > - Adding

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov wrote: > On 13 July 2015 at 22:35, Gehad Elrobey wrote: > > Hello all, > > > > This week I was working on the following tasks: > > > > - Enhancing the one dive per page template. > > - Refactoring the Printing class to handle QPrinter and QPixm

Re: GSoC Status - Week 7 (Customizable prints)

On 13 July 2015 at 23:54, Gehad Elrobey wrote: > > > On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov > wrote: >> >> On 13 July 2015 at 22:35, Gehad Elrobey wrote: >> > Hello all, >> > >> > This week I was working on the following tasks: >> > >> > - Enhancing the one dive per page template. >

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 11:13 PM, Lubomir I. Ivanov wrote: > On 13 July 2015 at 23:54, Gehad Elrobey wrote: > > > > > > On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov > > > wrote: > >> > >> On 13 July 2015 at 22:35, Gehad Elrobey wrote: > >> > Hello all, > >> > > >> > This week I was work

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 00:16, Gehad Elrobey wrote: > > > On Mon, Jul 13, 2015 at 11:13 PM, Lubomir I. Ivanov > wrote: >> >> On 13 July 2015 at 23:54, Gehad Elrobey wrote: >> > >> > >> > On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov >> > >> > wrote: >> >> >> >> On 13 July 2015 at 22:35, Gehad

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 00:19, Lubomir I. Ivanov wrote: > > then again, there was this "huge lines" issues with QImage on Linux in > Qt5.x, so if this bug is still present QPixmap should be used. > via Q_OS_LINUX branching that is; same as the code we had in the previous printing stack. lubomir -- __

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 11:22 PM, Lubomir I. Ivanov wrote: > On 14 July 2015 at 00:19, Lubomir I. Ivanov wrote: > > > > then again, there was this "huge lines" issues with QImage on Linux in > > Qt5.x, so if this bug is still present QPixmap should be used. > > > > via Q_OS_LINUX branching that

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 00:16, Gehad Elrobey wrote: > > Should I convert the dive profile to QImage during previewing only or should > I convert it during actual printing also which will affect the printing > quality? > i can't build ATM, but i think the logic here is a bit wrong: https://github.com/G

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 13:20, Lubomir I. Ivanov wrote: > On 14 July 2015 at 13:19, Gehad Elrobey wrote: >> >> On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" wrote: >>> >>> On 14 July 2015 at 00:16, Gehad Elrobey wrote: >>> > >>> > Should I convert the dive profile to QImage during previewing only or

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 13:19, Gehad Elrobey wrote: > > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" wrote: >> >> On 14 July 2015 at 00:16, Gehad Elrobey wrote: >> > >> > Should I convert the dive profile to QImage during previewing only or >> > should >> > I convert it during actual printing also w

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 13:19, Gehad Elrobey wrote: > > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" wrote: >> >> On 14 July 2015 at 00:16, Gehad Elrobey wrote: >> > >> > Should I convert the dive profile to QImage during previewing only or >> > should >> > I convert it during actual printing also w

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov wrote: > On 14 July 2015 at 13:19, Gehad Elrobey wrote: > > > > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" > wrote: > >> > >> On 14 July 2015 at 00:16, Gehad Elrobey wrote: > >> > > >> > Should I convert the dive profile to QImage during pr

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 14:29, Lubomir I. Ivanov wrote: > On 14 July 2015 at 13:19, Gehad Elrobey wrote: >> >> On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" wrote: >>> >>> On 14 July 2015 at 00:16, Gehad Elrobey wrote: >>> > >>> > Should I convert the dive profile to QImage during previewing only or

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 14:38, Gehad Elrobey wrote: > > > On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov > wrote: >> >> On 14 July 2015 at 13:19, Gehad Elrobey wrote: >> > >> > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" >> > wrote: >> >> >> >> On 14 July 2015 at 00:16, Gehad Elrobey wrote: >

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 14:43, Lubomir I. Ivanov wrote: > On 14 July 2015 at 14:38, Gehad Elrobey wrote: >>> >>> 3) i get no text / data in the tables under the profiles. could this >>> be a bug on my end? >>> >> >> I am not sure why this happens, it works correctly for me, can you send me >> the dive

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov wrote: > On 14 July 2015 at 14:43, Lubomir I. Ivanov wrote: > > On 14 July 2015 at 14:38, Gehad Elrobey wrote: > >>> > >>> 3) i get no text / data in the tables under the profiles. could this > >>> be a bug on my end? > >>> > >> > >> I am not s

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 14:51, Gehad Elrobey wrote: > > > On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov > wrote: >> >> On 14 July 2015 at 14:43, Lubomir I. Ivanov wrote: >> > On 14 July 2015 at 14:38, Gehad Elrobey wrote: >> >>> >> >>> 3) i get no text / data in the tables under the profiles. c

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 2:01 PM, Lubomir I. Ivanov wrote: > On 14 July 2015 at 14:51, Gehad Elrobey wrote: > > > > > > On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 14 July 2015 at 14:43, Lubomir I. Ivanov > wrote: > >> > On 14 July 2015 at 14:38, Gehad Elrobey >

Re: GSoC Status - Week 7 (Customizable prints)

On 14 July 2015 at 15:08, Gehad Elrobey wrote: > > > On Tue, Jul 14, 2015 at 2:01 PM, Lubomir I. Ivanov > wrote: >> >> On 14 July 2015 at 14:51, Gehad Elrobey wrote: >> > >> > >> > On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> On 14 July 2015 at 14:43, Lubomir I. Iv

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov wrote: > On 14 July 2015 at 14:38, Gehad Elrobey wrote: > > > > > > On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 14 July 2015 at 13:19, Gehad Elrobey wrote: > >> > > >> > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivan

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 20:06, Gehad Elrobey wrote: > > > On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov > wrote: >> >> On 14 July 2015 at 14:38, Gehad Elrobey wrote: >> > >> > >> > On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> On 14 July 2015 at 13:19, Gehad Elrobey

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 20:06, Gehad Elrobey wrote: > > > > > > On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 14 July 2015 at 14:38, Gehad Elrobey wrote: > >> > > >> > > >> > On Tue, Jul 14, 2015 at 1:29 PM, Lu

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 3:13 PM, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov > wrote: > >> On 17 July 2015 at 20:06, Gehad Elrobey wrote: >> > >> > >> > On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov > > >> > wrote: >> >> >> >> On 14 July 2015 at 14:38, Geh

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:20 PM, Tomaz Canabrava wrote: > > > On Fri, Jul 17, 2015 at 3:13 PM, Gehad Elrobey > wrote: > >> >> >> On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov >> wrote: >> >>> On 17 July 2015 at 20:06, Gehad Elrobey wrote: >>> > >>> > >>> > On Tue, Jul 14, 2015 at 1:43 PM,

Re: GSoC Status - Week 7 (Customizable prints)

> I am forces to render the dive profile on a QImage so that I can convert >>> it to grayscale image and then render it on top of the QWebview, Do you >>> think there is a way to convert the vector graphics to grayscale? >>> >> >> >> graphicsview-common.h:QColor getColor(const color_indice_t i, bo

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 21:13, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov > wrote: >> >> hello Gehad, >> >> without looking at the code, the greyscale mode works as expected, but >> both the Preview and actual Print now razterize everything on Windows >> (profile and

Re: GSoC Status - Week 7 (Customizable prints)

We d On Fri, Jul 17, 2015 at 3:37 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 21:13, Gehad Elrobey wrote: > > > > > > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov > > wrote: > >> > >> hello Gehad, > >> > >> without looking at the code, the greyscale mode works as expected, but > >>

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 21:36, Tomaz Canabrava wrote: > I am forces to render the dive profile on a QImage so that I can convert it to grayscale image and then render it on top of the QWebview, Do you think there is a way to convert the vector graphics to grayscale? >>> >>> >>> >>> graph

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:37 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 21:13, Gehad Elrobey wrote: > > > > > > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov > > wrote: > >> > >> hello Gehad, > >> > >> without looking at the code, the greyscale mode works as expected, but > >> both

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 21:49, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 8:37 PM, Lubomir I. Ivanov > wrote: >> >> On 17 July 2015 at 21:13, Gehad Elrobey wrote: >> > >> > >> > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> hello Gehad, >> >> >> >> without lookin

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 21:36, Tomaz Canabrava wrote: > > > I am forces to render the dive profile on a QImage so that I can > convert > it to grayscale image and then render it on top of the QWebview, Do > you > think there i

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 21:42, Tomaz Canabrava wrote: > We d > > On Fri, Jul 17, 2015 at 3:37 PM, Lubomir I. Ivanov > wrote: >> >> On 17 July 2015 at 21:13, Gehad Elrobey wrote: >> > >> > >> > On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> hello Gehad, >> >> >> >> without

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 21:54, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov > wrote: > >> On 17 July 2015 at 21:36, Tomaz Canabrava wrote: >> > >> I am forces to render the dive profile on a QImage so that I can >> convert >> it to grayscale image and t

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 9:01 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 21:54, Gehad Elrobey wrote: > > > > > > On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov > > wrote: > > > >> On 17 July 2015 at 21:36, Tomaz Canabrava wrote: > >> > > >> I am forces to render the dive profile

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:51 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 21:49, Gehad Elrobey wrote: > > > > > > On Fri, Jul 17, 2015 at 8:37 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 17 July 2015 at 21:13, Gehad Elrobey wrote: > >> > > >> > > >> > On Fri, Jul 17, 2015 at 8:08 PM, Lu

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 22:10, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 9:01 PM, Lubomir I. Ivanov > wrote: >> >> On 17 July 2015 at 21:54, Gehad Elrobey wrote: >> > >> > >> > On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov >> > wrote: >> >> > >> >> On 17 July 2015 at 21:36, Tomaz Canab

Re: GSoC Status - Week 7 (Customizable prints)

On 17 July 2015 at 22:17, Lubomir I. Ivanov wrote: > On 17 July 2015 at 22:10, Gehad Elrobey wrote: >> >> Yes it does, you can test it on current master. >> > > > this is technically a Qt bug of sorts, because the QPrintEngine > greyscale property for some *very odd* doesn't work in the preview >

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov wrote: > On 17 July 2015 at 22:17, Lubomir I. Ivanov wrote: > > On 17 July 2015 at 22:10, Gehad Elrobey wrote: > >> > >> Yes it does, you can test it on current master. > >> > > > > > > this is technically a Qt bug of sorts, because the QPrintE

Re: GSoC Status - Week 7 (Customizable prints)

On 19 July 2015 at 13:23, Gehad Elrobey wrote: > > > On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov > wrote: >> >> On 17 July 2015 at 22:17, Lubomir I. Ivanov wrote: >> > On 17 July 2015 at 22:10, Gehad Elrobey wrote: >> >> >> >> Yes it does, you can test it on current master. >> >> >> > >>

Re: GSoC Status - Week 7 (Customizable prints)

On 20 July 2015 at 13:06, Gehad Elrobey wrote: > > > On Sun, Jul 19, 2015 at 9:56 PM, Lubomir I. Ivanov > wrote: >> >> On 19 July 2015 at 13:23, Gehad Elrobey wrote: >> > >> > >> > On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov >> > wrote: >> >> >> >> On 17 July 2015 at 22:17, Lubomir I. Iv

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 12:20 PM, Lubomir I. Ivanov wrote: > On 20 July 2015 at 13:06, Gehad Elrobey wrote: > > > > > > On Sun, Jul 19, 2015 at 9:56 PM, Lubomir I. Ivanov > > wrote: > >> > >> On 19 July 2015 at 13:23, Gehad Elrobey wrote: > >> > > >> > > >> > On Fri, Jul 17, 2015 at 9:28 PM, L

Re: GSoC Status - Week 7 (Customizable prints)

On 20 July 2015 at 14:59, Gehad Elrobey wrote: > > Now we always rasterize for grayscale, I pushed the updates. > PR sent. thank you for bearing with the greyscale issues... some important things TODO would be: - add the old "6 dives per page" template. some of the users will probably bring up

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 3:02 PM, Lubomir I. Ivanov wrote: > On 20 July 2015 at 14:59, Gehad Elrobey wrote: > > > > Now we always rasterize for grayscale, I pushed the updates. > > > > PR sent. thank you for bearing with the greyscale issues... > > some important things TODO would be: > > - add t

Re: GSoC Status - Week 7 (Customizable prints)

On 20 July 2015 at 16:10, Gehad Elrobey wrote: > > > On Mon, Jul 20, 2015 at 3:02 PM, Lubomir I. Ivanov > wrote: >> >> On 20 July 2015 at 14:59, Gehad Elrobey wrote: >> > >> > Now we always rasterize for grayscale, I pushed the updates. >> > >> >> PR sent. thank you for bearing with the greyscal

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: > >> - the cmake issues! can you even reproduce those? :-( > >> > > > > No I couldn't, it always works correctly with me. > > > > this could be windows cmake specific, but it's quite bad as it breaks > the entire build the second t

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 4:27 PM, Dirk Hohndel wrote: > On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: >> >> - the cmake issues! can you even reproduce those? :-( >> >> >> >> do you think the timings are OK for the pencils down date? what else >> >> is on your TODO list? >> > >>

Re: GSoC Status - Week 7 (Customizable prints)

On Jul 20, 2015 3:27 PM, "Dirk Hohndel" wrote: > > On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: > > >> - the cmake issues! can you even reproduce those? :-( > > >> > > > > > > No I couldn't, it always works correctly with me. > > > > > > > this could be windows cmake specific

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 5:27 PM, Gehad Elrobey wrote: > > On Jul 20, 2015 3:27 PM, "Dirk Hohndel" wrote: >> >> On Mon, Jul 20, 2015 at 04:17:28PM +0300, Lubomir I. Ivanov wrote: >> > >> - the cmake issues! can you even reproduce those? :-( >> > >> >> > > >> > > No I couldn't, it always works corr

Re: GSoC Status - Week 7 (Customizable prints)

> On Jul 20, 2015, at 07:30, Miika Turkia wrote: > >>> >>> Agreed. Better looking templates or at least templates that look closer to >>> what we had. I'll admit that the "shades of orange and beige" color scheme >>> isn't high on my list of favorites. If we really want to play with colors >>

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 4:59 PM, Dirk Hohndel wrote: > > > > > On Jul 20, 2015, at 07:30, Miika Turkia wrote: > > > >>> > >>> Agreed. Better looking templates or at least templates that look > closer to > >>> what we had. I'll admit that the "shades of orange and beige" color > scheme > >>> isn'

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 21, 2015 at 11:24:19AM +0200, Gehad Elrobey wrote: > On Mon, Jul 20, 2015 at 4:59 PM, Dirk Hohndel wrote: > > >> > > >> I want to admit that I am not a clever color chooser, I will add another > > >> color theme with shades of blue. Did you try the Template Edit dialog? > > > > > > Can

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 21, 2015 at 3:15 PM, Dirk Hohndel wrote: > On Tue, Jul 21, 2015 at 11:24:19AM +0200, Gehad Elrobey wrote: > > On Mon, Jul 20, 2015 at 4:59 PM, Dirk Hohndel wrote: > > > >> > > > >> I want to admit that I am not a clever color chooser, I will add > another > > > >> color theme with sh