Re: Pull request

ub? I think what it says is "You fool, the source repo already has all the changes in your manual-branch. It makes no sense to generate a pull request". Is this correct? That probably explains a lack of pr on your side. Kind r

Re: Pull request

> On Jul 18, 2017, at 12:24 PM, Willem Ferguson > <willemfergu...@zoology.up.ac.za> wrote: > > On 18/07/2017 18:10, Dirk Hohndel wrote: >> Hmm, I don't even understand the question. >> >> I haven't seen a pull request, but you sent me email to pull fro

Re: Pull request

On 18/07/2017 18:10, Dirk Hohndel wrote: Hmm, I don't even understand the question. I haven't seen a pull request, but you sent me email to pull from the separate git repo that you shared with me a while ago. Are there other changes I need to pull? Where are they? I will sort out the pull

[pull request]: dive details rework

Please pull from g...@github.com:sebasje/subsurface.git branch "divedetailssplit". The plan was to split up viewing and editing the dives in order to make both modes work better for their purpose. (For example, we don't need the huge profile picture in the edit mode, since it can't be edited,

Re: [PULL REQUEST] warning fixes

On 8 November 2015 at 08:24, Dirk Hohndel wrote: > On Sun, Nov 08, 2015 at 12:00:47AM +0200, Lubomir I. Ivanov wrote: >> some general cleanup of warnings. >> >> i always check for #ifdefs before removing an unused variable, but please >> let me know if i messed up somewhere or

[PULL REQUEST] warning fixes

some general cleanup of warnings. i always check for #ifdefs before removing an unused variable, but please let me know if i messed up somewhere or if something looks wrong. --- The following changes since commit dab207a8c84ca0621a8a3cabd0b911e60347537d: Subsurface-mobile: load

Re: [PULL REQUEST] warning fixes

On Sun, Nov 08, 2015 at 12:00:47AM +0200, Lubomir I. Ivanov wrote: > some general cleanup of warnings. > > i always check for #ifdefs before removing an unused variable, but please > let me know if i messed up somewhere or if something looks wrong. I didn't see anything wrong with these. Thanks

[PULL REQUEST] GSoC Printing: part 7

This is the final batch of patches from Gehad. Contains: - Updated user-manual to the printing stack changes. There might be some typos that we've missed. - Better support for the statistics print (colors/fonts). Can't be edited yet - I've just suggested a possible solution. - A couple of bug /

Re: [PULL REQUEST] VPM-B

I think that currently first_stop is being calculated for each stop (so isn't actually first_stop) rather than just the first. That's what it looked like from my limited running under gdb with a break every time first_stop is calculated, and printing the depth variable. To calculate the

Re: [PULL REQUEST] VPM-B

On 17 August 2015 at 19:46, Jan Darowski jan.darow...@gmail.com wrote: I think that currently first_stop is being calculated for each stop (so isn't actually first_stop) rather than just the first. That's what it looked like from my limited running under gdb with a break every time

Re: [PULL REQUEST] VPM-B

I think I've worked out at least one difference in the programs' algorithms, and sorry I doubt you'll like it. Subsurface calculates required stops considering the ascent rate and the time to reach the stop. The Fortran program calculates the 'instantaneous' ceiling, i.e. the depth

Re: [PULL REQUEST] VPM-B

On 18 Aug 2015 12:13 am, Jan Darowski jan.darow...@gmail.com wrote: I think I've worked out at least one difference in the programs' algorithms, and sorry I doubt you'll like it. Subsurface calculates required stops considering the ascent rate and the time to reach the stop. The Fortran

Re: [PULL REQUEST] VPM-B

Hi Jan, On 17 August 2015 at 20:59, Rick Walsh rickmwa...@gmail.com wrote: On 17 August 2015 at 19:46, Jan Darowski jan.darow...@gmail.com wrote: I think that currently first_stop is being calculated for each stop (so isn't actually first_stop) rather than just the first. That's what it

Re: [PATCH] Re: [PULL REQUEST] VPM-B

On Mon, Aug 17, 2015 at 06:41:03PM +0200, Jan Darowski wrote: 2015-08-17 17:54 GMT+02:00 Robert C. Helling hell...@atdotde.de: Hi, On 17 Aug 2015, at 15:44, Rick Walsh rickmwa...@gmail.com wrote: Which approach is more justified? Debatable. The method used by Subsurface should be

Re: [PULL REQUEST] VPM-B

DIrk, On 15 Aug 2015, at 16:11, Jan Darowski jan.darow...@gmail.com wrote: Here is my next pull request, this is definitely progress and nothing is obviously wrong (modulo what was said in this thread, so please pull: ACK by me. There are some things to work on, but this gets easier, once

[PATCH] Re: [PULL REQUEST] VPM-B

Hi,On 17 Aug 2015, at 15:44, Rick Walsh rickmwa...@gmail.com wrote:Which approach is more justified? Debatable. The method used by Subsurface should be 'better', but when the depth of the first stop/ceiling is given a special significance thanks to the Boyles law compensation process, I'm not so

Re: [PATCH] Re: [PULL REQUEST] VPM-B

On 17 Aug 2015, at 18:41, Jan Darowski jan.darow...@gmail.com wrote: In my opinion we shouldn't leave this as a preference, it's to technical and complicated to explain to most of users. We have the conservatism levels already, so users can manipulate how aggressive their schedule is.

Re: [PATCH] Re: [PULL REQUEST] VPM-B

2015-08-17 17:54 GMT+02:00 Robert C. Helling hell...@atdotde.de: Hi, On 17 Aug 2015, at 15:44, Rick Walsh rickmwa...@gmail.com wrote: Which approach is more justified? Debatable. The method used by Subsurface should be 'better', but when the depth of the first stop/ceiling is given a

Re: [PULL REQUEST] VPM-B

Hi, I've looked at and tested your latest series of VPM-B commits. From what I can see, it looks like it's doing the correct thing, except that first_stop_pressure is reset to zero every iteration, so it then gets set each stop (rather than just at the first stop) before running the Boyle's

Re: [PULL REQUEST] VPM-B

Hi Jan, On 17 Aug 2015 12:32 am, Jan Darowski jan.darow...@gmail.com wrote: Hi, I've looked at and tested your latest series of VPM-B commits. From what I can see, it looks like it's doing the correct thing, except that first_stop_pressure is reset to zero every iteration, so it then

Re: [PULL REQUEST] VPM-B

Hi Jan, On 16 August 2015 at 00:11, Jan Darowski jan.darow...@gmail.com wrote: Hi! Here is my next pull request, it adds all the remaining vpm-b elements. What is left to code is some way of logged dives rating against vpm-b and probably some fixes. I've looked at and tested your latest

[PULL REQUEST] GSoC Printing: part 6

This is the last batch of patches from Gehad for the soft pencils down date. For those who have free time and are interested in the printing module please compile and have a look at this update. I have requested multiple revisions on how the bundled templates look, trying to get them as close to

[PULL REQUEST] VPM-B

Hi! Here is my next pull request, it adds all the remaining vpm-b elements. What is left to code is some way of logged dives rating against vpm-b and probably some fixes. The following changes since commit 342479586d1f34a2b7f3d1d69037cb0d631489fa: Planner: use the heap for note buffers (2015

[PULL REQUEST] GSoC Printing: part 5

More from Gehad: - added a Table print template - we had this one before - added a Flow print template - as discussed at GSoC start, this one can span a dive on multiple pages - Import|Export|Delete of templates - as Dirk suggested - another bundled color scheme - a blueish one - more

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 4:41 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 12:18:36PM +0300, Lubomir I. Ivanov wrote: More from Gehad: - added a Table print template - we had this one before - added a Flow print template - as discussed at GSoC start, this one can span

Re: [PULL REQUEST] GSoC Printing: part 5

On 28 July 2015 at 18:41, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:34:36PM +0300, Lubomir I. Ivanov wrote: I am blown away. This is really great work. It's not perfect, there are things that I'd like to see improved, but it is such an amazing step forward for our

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 5:41 PM, Dirk Hohndel d...@hohndel.org wrote: - having the warning triangles but no way to see their text... I think we should just not print the triangles. Opinions? In general, we should have proper icons on the profile that describe what the warning/alarm is about.

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 6:26 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:01:08PM +0300, Miika Turkia wrote: On Tue, Jul 28, 2015 at 5:41 PM, Dirk Hohndel d...@hohndel.org wrote: - having the warning triangles but no way to see their text... I think we should just

Re: [PULL REQUEST] GSoC Printing: part 5

On 28 July 2015 at 19:09, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 18:41, Dirk Hohndel d...@hohndel.org wrote: - having the warning triangles but no way to see their text... I think we should just not print the triangles. Opinions? same as the previous printer

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 04:49:07PM +0200, Gehad Elrobey wrote: On Tue, Jul 28, 2015 at 4:41 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 12:18:36PM +0300, Lubomir I. Ivanov wrote: More from Gehad: - added a Table print template - we had this one before - added a

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 12:18:36PM +0300, Lubomir I. Ivanov wrote: More from Gehad: - added a Table print template - we had this one before - added a Flow print template - as discussed at GSoC start, this one can span a dive on multiple pages - Import|Export|Delete of templates - as Dirk

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 07:09:37PM +0300, Lubomir I. Ivanov wrote: In my case the toggle calculated ceilings setting is on (as I want to see those) and strangely on the screen the GF 30/70 doesn't bother me at all, but on the printout I find it odd on dives that don't have a visible

Re: [PULL REQUEST] GSoC Printing: part 5

On 28 July 2015 at 20:35, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 19:26, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 07:09:37PM +0300, Lubomir I. Ivanov wrote: In my case the toggle calculated ceilings setting is on (as I want to see those) and

Re: [PULL REQUEST] GSoC Printing: part 5

On 28 July 2015 at 19:26, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 07:09:37PM +0300, Lubomir I. Ivanov wrote: In my case the toggle calculated ceilings setting is on (as I want to see those) and strangely on the screen the GF 30/70 doesn't bother me at all, but on the

default colors for print [was: Re: [PULL REQUEST] GSoC Printing: part 5]

On Tue, Jul 28, 2015 at 06:47:35PM +0300, Lubomir I. Ivanov wrote: That's not exactly intuitive. But once we find a color palette that's reasonably pleasing to the eye maybe this is not too bad... With the deepest respect to your ability as a developer, Gehad, neither of these two

Re: default colors for print [was: Re: [PULL REQUEST] GSoC Printing: part 5]

On Tue, Jul 28, 2015 at 7:59 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:47:35PM +0300, Lubomir I. Ivanov wrote: That's not exactly intuitive. But once we find a color palette that's reasonably pleasing to the eye maybe this is not too bad... With the deepest

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 7:35 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 19:26, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 07:09:37PM +0300, Lubomir I. Ivanov wrote: In my case the toggle calculated ceilings setting is on (as I want to see

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 08:35:33PM +0300, Lubomir I. Ivanov wrote: That's part of it. The bigger issue for me is that GF x/y is printed even if there is no ceiling at all. And that's kinda strange. i have no idea how are we going to hide the GF text based on no how small the ceiling

Re: [PULL REQUEST] GSoC Printing: part 5

Hi, Am 28.07.2015 um 17:41 schrieb Dirk Hohndel d...@hohndel.org: So what someone needs to do is change the profile code to do the right thing and only show that text if there actually is a ceiling shown. Strictly speaking, the fact that there is no ceiling shown is also gradient factor

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 6:09 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 18:41, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:34:36PM +0300, Lubomir I. Ivanov wrote: I am blown away. This is really great work. It's not perfect, there are things

Re: default colors for print [was: Re: [PULL REQUEST] GSoC Printing: part 5]

On 28 July 2015 at 20:59, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:47:35PM +0300, Lubomir I. Ivanov wrote: That's not exactly intuitive. But once we find a color palette that's reasonably pleasing to the eye maybe this is not too bad... With the deepest respect to

[PULL REQUEST] GSoC Printing: part 4

Part 4 of the new GSoC printing module from Gehad. Adds: 1) Better greyscale conversations when print in color is de-selected. Due to a QPrinter-setColorMode() bug we are forced to rasterize the entire page (profile, tables, everything) when in greyscale. We have faced some limitations here

Re: [PULL REQUEST] GSoC Printing: part 4

On 20 July 2015 at 16:22, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: Part 4 of the new GSoC printing module from Gehad. I merged this. thanks. lubomir -- ___ subsurface mailing list

Re: [PULL REQUEST] GSoC Printing: part 4

On Mon, Jul 20, 2015 at 04:29:50PM +0300, Lubomir I. Ivanov wrote: On 20 July 2015 at 16:22, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: Part 4 of the new GSoC printing module from Gehad. I merged this. ATM this is useable,

Re: [PULL REQUEST] GSoC Printing: part 4

On 20 July 2015 at 16:22, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: Part 4 of the new GSoC printing module from Gehad. I merged this. ATM this is useable, but the stock templates aren't pretty yet; an important thing on the TODO

Re: [PULL REQUEST] GSoC Printing: part 4

On 20 July 2015 at 16:34, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 20, 2015 at 04:29:50PM +0300, Lubomir I. Ivanov wrote: On 20 July 2015 at 16:22, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 20, 2015 at 03:48:32PM +0300, Lubomir I. Ivanov wrote: Part 4 of the new GSoC printing

Re: [PULL REQUEST] VPM-B Attempt 2.

Dirk, Jan, On 5 July 2015 at 23:56, Dirk Hohndel d...@hohndel.org wrote: On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: Hi, Here is another pull request. I hope now it's better. Everything was reorganized from scratch, the final code is almost the same. I like the patches

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); That's slightly weird :-) I know that this is weird but there is no HostPoweredOn enum :-). It can be either off, connectable, discoverable or discoverable limited

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

Hi Thiago, + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); That's slightly weird :-) I know that this is weird but there is no HostPoweredOn enum :-). It can be either off, connectable, discoverable or discoverable limited inquiry. Therefore I choose to use !(mode ==

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

Oh yeah :). I don't know what was in my mind when I did that :)). On Tue, Jul 7, 2015 at 12:02 AM, Thiago Macieira thi...@macieira.org wrote: On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); That's slightly weird

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

Actually, here's one. The fake open function for the OSTC 2N. That could have been its own commit, added before the next commit that adds all the qtserialbluetooth stuff. That's a simple example, but maybe it illustrates what I mean. It is funny that in the beginning I did an isolated

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

implementation for HW_OSTC3 and SHEARWATER families. hey, Claudiu. just to point out that if you attach the patches in the email, it's not a git pull-request. but AFAIK, pull-requests are not mandatory for GSoC. Both true. I prefer emails with patches to have [PATCH] in their subject because

[PULL REQUEST] libdivecomputer - Subsurface-testing branch

Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial implementation for HW_OSTC3 and SHEARWATER families. Claudiu From 05d830371f2bce35820bebb7419ed27946b3a658 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

On Mon, Jul 06, 2015 at 05:33:00PM +0300, Claudiu Olteanu wrote: Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial implementation for HW_OSTC3 and SHEARWATER families. This looks good to me. I'll add these to our

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread PULL REQUEST. Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull request. Also I knew that Dirk prefers patches instead of pull requests

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

Hi CLaudiu On Mon, Jul 06, 2015 at 05:42:00PM +0300, Claudiu Olteanu wrote: Hi there, I attached you some patches which add the QtBluetooth serial implementation. The Bluetooth download mode is accessible from the DownloadFromDiveComputer widget. In order to connect to a Bluetooth device

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

On Mon, Jul 06, 2015 at 06:17:02PM +0300, Claudiu Olteanu wrote: Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread PULL REQUEST. Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull

Re: [PULL REQUEST] VPM-B Attempt 2.

On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: Hi, Here is another pull request. I hope now it's better. Everything was reorganized from scratch, the final code is almost the same. I like the patches much better. I agree with Robert that you could have squashed a couple together

[PULL REQUEST] GSoC Printing: part 3

These are the third series from Gehad. Not much is happening visually except fixes for the print selected issue and the addition of the template editor dialog. The template edit itself is WIP. There is also the addition of the Preview window which we had in the previous Qt implementation. This

Re: [PULL REQUEST] VPM-B Attempt 2.

Hi, On 4 July 2015 at 18:29, Jan Darowski jan.darow...@gmail.com wrote: eh... from deepocean.net: 7500 fsw min = 250 bar min It's not the first mistake I found there. And it seems that the author of existing c code based his implementation on this site also. I multiplied 7500 fsw by 0.304

Re: [PULL REQUEST] VPM-B Attempt 2.

Hi, On 04 Jul 2015, at 10:29, Jan Darowski jan.darow...@gmail.com wrote: I guess I need to implement Boyle's law as soon as possible and only test against the original fortran code... just a brief comment: Indeed testing against other code is quite essential (not only since our software

Re: [PULL REQUEST] VPM-B Attempt 2.

Hi, On 04 Jul 2015, at 11:23, Rick Walsh rickmwa...@gmail.com wrote: I multiplied 7500 fsw by 0.304 (feet to metres) divided by 10 (metres salt water to ata) and multipled by 1.01325 (ata to bar). 7500 * 0.304 / 10 * 1.01353 = 231.021 bar It's close, but I think my conversion was very

Re: [PULL REQUEST] VPM-B Attempt 2.

On Sat, Jul 04, 2015 at 10:29:17AM +0200, Jan Darowski wrote: Thanks for checking it. But then I checked the configuration parameters adopted, and there are differences. I altered vpmb_config to match what was used in the Fortran code. critical radius of N2 was 0.6, changed to 0.8

Re: [PULL REQUEST] VPM-B Attempt 2.

On Sat, Jul 04, 2015 at 07:23:12PM +1000, Rick Walsh wrote: I multiplied 7500 fsw by 0.304 (feet to metres) divided by 10 (metres salt water to ata) and multipled by 1.01325 (ata to bar). 7500 * 0.304 / 10 * 1.01353 = 231.021 bar It's close, but I think my conversion was very slightly out,

Re: [PULL REQUEST] VPM-B

Hi, here is the link to the results of some tests I did. https://docs.google.com/spreadsheets/d/1jrafQsE9bwHLszJadYzRlD2zBD57UB7TIAh2Xz0o-XQ/edit?usp=sharing Some comments: As you can see the are some cases when results differ. Test 4: starting gradients are the same, final gradients differ a lot.

Re: [PULL REQUEST] VPM-B

On 30 Jun 2015 10:01 p.m., Robert C. Helling hell...@atdotde.de wrote: I second all of Dirk’s suggestions (of course, how could I?) and should maybe point out (as I learned this only very recently) that git rebase —interactive and git add -p are both extremely useful when rewriting

Re: [PULL REQUEST] VPM-B

Dirk: fine, I agree that these commits aren't of the highest quality. One of the reasons is that this work is based in huge part on the existing implementation which I had to discover part by part and which has a lot of strange solutions (including units and constants scaled all the time). The

Re: [PULL REQUEST] VPM-B

that happens relatively frequently. And it is something that for a number of reasons way too often makes it into our master branch. But especially when creating a pull request like this as part of a GSoC project with the goal to teach you how to do well in open source it would be really good

Re: [PULL REQUEST] VPM-B

Hi Jan, On 30 Jun 2015, at 15:38, Dirk Hohndel d...@hohndel.org wrote: Jan, thanks for sending this. I have asked Robert to look at the code from the algorithmic side, but let me give you some general feedback in addition to the comments that I made on github: I have pulled your patches

[PULL REQUEST] VPM-B

Hi, here is the request for the basic vpm algorithm. Right now it doesn't include Boyle's law compensation so the deco plans it generates can be too short in some situations. The following changes since commit f763da66b3db17347954272b9f856df6f8b9888d: Implement planner option to switch only

Re: [PULL REQUEST] GSoC Printing: part 2

On 20 June 2015 at 12:44, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 June 2015 at 06:19, Gehad Elrobey gehadelro...@gmail.com wrote: - Implementing the flow layout template. i wonder if the table print can be a template instead of an option. technically it's just tables without the

Re: [PULL REQUEST] GSoC Printing: part 2

On 20 June 2015 at 06:42, Dirk Hohndel d...@hohndel.org wrote: On Sat, Jun 20, 2015 at 05:19:15AM +0200, Gehad Elrobey wrote: On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task. Here Gehad has added

Re: [PULL REQUEST] GSoC Printing: part 2

On 20 June 2015 at 06:19, Gehad Elrobey gehadelro...@gmail.com wrote: - Implementing the flow layout template. i wonder if the table print can be a template instead of an option. technically it's just tables without the profiles. this makes the Print type radio group in the dialog redundant

Re: [PULL REQUEST] GSoC Printing: part 2

On 20 June 2015 at 06:19, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task. Here Gehad has added another template which is the one dive per page, some minor

Re: [PULL REQUEST] GSoC Printing: part 2

On Sat, Jun 20, 2015 at 11:03 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 June 2015 at 06:19, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC

Re: [PULL REQUEST] GSoC Printing: part 2

On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task. Here Gehad has added another template which is the one dive per page, some minor fixes and renames here and there and also support for printing on any

Re: [PULL REQUEST] GSoC Printing: part 2

On Sat, Jun 20, 2015 at 05:19:15AM +0200, Gehad Elrobey wrote: On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task. Here Gehad has added another template which is the one dive per page, some minor

[PULL REQUEST] GSoC Printing: part 2

So this is the second batch of patches for this GSoC task. Here Gehad has added another template which is the one dive per page, some minor fixes and renames here and there and also support for printing on any page size (or render target size). Also good news is that I'm now actually able to use

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 20:02, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs to continute the work into the template specific logic. Rebasing

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 21:39, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 09:13:34PM +0300, Lubomir I. Ivanov wrote: replies: https://github.com/torvalds/subsurface/commit/3f3937f908b5c0044aef1caa196511469103daa7#commitcomment-11525543 Why is this hard coded to A4? This should

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 04, 2015 at 09:13:34PM +0300, Lubomir I. Ivanov wrote: replies: https://github.com/torvalds/subsurface/commit/3f3937f908b5c0044aef1caa196511469103daa7#commitcomment-11525543 Why is this hard coded to A4? This should simply use the printer's default page size intentional. i

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 04, 2015 at 10:02:28AM -0700, Dirk Hohndel wrote: On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs to continute the work into the template specific logic.

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 20:20, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 10:02:28AM -0700, Dirk Hohndel wrote: On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 4, 2015 at 8:13 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 20:02, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : On 4 June 2015 at 18:27, Lubomir I. Ivanov neolit...@gmail.com wrote: - should we in the meantime add -DNO_PRINTING=1 to build.sh? ^ actually, that's pretty much the only thing i can safely do ATM, as i can't test Linux and OSX. for instance,

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 18:27, Lubomir I. Ivanov neolit...@gmail.com wrote: - should we in the meantime add -DNO_PRINTING=1 to build.sh? ^ actually, that's pretty much the only thing i can safely do ATM, as i can't test Linux and OSX. for instance, about the INSTALL instructions on Grantlee:

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 18:47, Guillaume Gardet guillaume.gar...@free.fr wrote: Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : On 4 June 2015 at 18:27, Lubomir I. Ivanov neolit...@gmail.com wrote: - should we in the meantime add -DNO_PRINTING=1 to build.sh? ^ actually, that's pretty much the

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs to continute the work into the template specific logic. Rebasing all the time while waiting on me for reviews must be a pain, so

[PULL REQUEST] GSoC Printing: initial batch of patches

So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs to continute the work into the template specific logic. Rebasing all the time while waiting on me for reviews must be a pain, so this is pending. As discussed this does break the current printing

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

Thank you On 4 Jun 2015 18:18, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 18:15, Benjamin nyst...@gmail.com wrote: How does one install Grantlee? From the repositories? From a tar.gz? building from source might be the preferred way:

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 18:15, Benjamin nyst...@gmail.com wrote: How does one install Grantlee? From the repositories? From a tar.gz? building from source might be the preferred way: https://www.gitorious.org/grantlee/pages/Home lubomir -- ___ subsurface

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 17:58, Lubomir I. Ivanov neolit...@gmail.com wrote: cmake -DNO_PRINTING but mind that Grantlee will be a hard dependency if you cmake -DNO_PRINTING=1 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 Jun 2015 18:02, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 17:58, Lubomir I. Ivanov neolit...@gmail.com wrote: cmake -DNO_PRINTING but mind that Grantlee will be a hard dependency if you cmake -DNO_PRINTING=1 lubomir --

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 4 June 2015 at 18:24, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:18:51PM +0200, Anton Lundin wrote: On 04 June, 2015 - Benjamin wrote: On 4 Jun 2015 18:02, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 17:58, Lubomir I. Ivanov neolit...@gmail.com

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On 04 June, 2015 - Benjamin wrote: On 4 Jun 2015 18:02, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 17:58, Lubomir I. Ivanov neolit...@gmail.com wrote: cmake -DNO_PRINTING but mind that Grantlee will be a hard dependency if you cmake -DNO_PRINTING=1 lubomir

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 04, 2015 at 05:18:51PM +0200, Anton Lundin wrote: On 04 June, 2015 - Benjamin wrote: On 4 Jun 2015 18:02, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 17:58, Lubomir I. Ivanov neolit...@gmail.com wrote: cmake -DNO_PRINTING but mind that Grantlee will be

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 4, 2015 at 7:52 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 19:42, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:47:02PM +0200, Guillaume Gardet wrote: Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : On 4 June 2015 at 18:27, Lubomir I.