Re: [PATCH] Set -std=c++11 flag for g++

2016-06-22 Thread Thiago Macieira
On quarta-feira, 22 de junho de 2016 22:47:23 PDT Anton Lundin wrote: > @@ -73,6 +73,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang") > set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ") > elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") > set(CMAKE_C_FLAGS "${CMAKE_

Re: [PATCH] Set -std=c++11 flag for g++

2016-06-22 Thread Dirk Hohndel
> On Jun 22, 2016, at 2:49 PM, Thiago Macieira wrote: > > On quarta-feira, 22 de junho de 2016 22:47:23 PDT Anton Lundin wrote: >> @@ -73,6 +73,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang") >>set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99 ") >> elseif ("${CMAKE_CXX_COMPI

Re: [PATCH] Set -std=c++11 flag for g++

2016-06-22 Thread Thiago Macieira
On quarta-feira, 22 de junho de 2016 14:59:49 PDT Dirk Hohndel wrote: > > On Jun 22, 2016, at 2:49 PM, Thiago Macieira wrote: > > > > On quarta-feira, 22 de junho de 2016 22:47:23 PDT Anton Lundin wrote: > >> @@ -73,6 +73,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL > >> "AppleClang") > >> >

Re: [PATCH] Set -std=c++11 flag for g++

2016-06-23 Thread Anton Lundin
On 22 June, 2016 - Thiago Macieira wrote: > On quarta-feira, 22 de junho de 2016 14:59:49 PDT Dirk Hohndel wrote: > > > On Jun 22, 2016, at 2:49 PM, Thiago Macieira wrote: > > > > > > On quarta-feira, 22 de junho de 2016 22:47:23 PDT Anton Lundin wrote: > > >> @@ -73,6 +73,7 @@ elseif ("${CMAKE_

Re: [PATCH] Set -std=c++11 flag for g++

2016-06-23 Thread Dirk Hohndel
> On Jun 23, 2016, at 12:20 PM, Anton Lundin wrote: > > On 22 June, 2016 - Thiago Macieira wrote: > >> On quarta-feira, 22 de junho de 2016 14:59:49 PDT Dirk Hohndel wrote: On Jun 22, 2016, at 2:49 PM, Thiago Macieira wrote: On quarta-feira, 22 de junho de 2016 22:47:23 PDT Ant

Re: [PATCH] Set -std=c++11 flag for g++

2016-06-23 Thread Thiago Macieira
On quinta-feira, 23 de junho de 2016 12:42:36 PDT Dirk Hohndel wrote: > No, careful. I’m grudgingly accepting the fact that we need to compile with > the -std=c++11 flag in order to build against Qt5.7. I am NOT ok with > including C++11 features in the code. I’d prefer my code to be readable. >