Re: Split a dive by time

2018-07-02 Thread Robert Helling
Dirk, > On 2. Jul 2018, at 17:35, Dirk Hohndel wrote: > > I assume that this has a helper function split_dive_at_time(struct dive *d, > duration_t seconds) almost. I called it split_dive_at_time(struct dive *dive, int time). But you are right, duration_t is probably better. And it uses

Re: Split a dive by time

2018-07-02 Thread Dirk Hohndel
> On Jul 2, 2018, at 6:19 AM, Robert C. Helling > wrote: >> Am 02.07.2018 um 13:55 schrieb Berthold Stoeger : >> >> On the one hand, these are "low-hanging fruit". > > I have a „context menu split dive here“ almost ready. Nice. I assume that this has a helper function

Re: Split a dive by time

2018-07-02 Thread Robert C. Helling
Hi, > Am 02.07.2018 um 13:55 schrieb Berthold Stoeger : > > On the one hand, these are "low-hanging fruit". I have a „context menu split dive here“ almost ready. Best Robert ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: Split a dive by time

2018-07-02 Thread tormento
Thanks, it made its purpose. I can understand it's not a widely used feature. Anyway sometimes, when training people, strange and unusual dives occur. I keep on thinking that a "split by time" would be more than welcome :) Alberto Il giorno lun 2 lug 2018 alle ore 13:55 Berthold Stoeger <

Re: Split a dive by time

2018-07-02 Thread Berthold Stoeger
On Monday, 2 July 2018 09:36:34 CEST tormento wrote: > Linus thanks for your interest in my minor problem. > > Which build is the one with your fix? The one I have tried from nightly > splits the dive in three parts, the last two of negligible lenght, while > the first one is much longer than the

Re: Split a dive by time

2018-07-01 Thread Dirk Hohndel
> On Jul 1, 2018, at 2:43 PM, Linus Torvalds > wrote: > > Ok, fixed that too, and now I can take Alberto's dive, and do "split > selected dive" on it to get the four non-surface parts, and then > stitch the three quick dips that were part of the rescue dive back > into one dive, ending up with

Re: Split a dive by time

2018-07-01 Thread Linus Torvalds
On Sun, Jul 1, 2018 at 1:57 PM Linus Torvalds wrote: > > Fixing that, I get the right splits, and let me just fix the merging too. Ok, fixed that too, and now I can take Alberto's dive, and do "split selected dive" on it to get the four non-surface parts, and then stitch the three quick dips

Re: Split a dive by time

2018-07-01 Thread Linus Torvalds
On Sun, Jul 1, 2018 at 1:35 PM Linus Torvalds wrote: > > Oh, but this *does* split automatically (go to dive list, select that > dive, right-click to get the action menu, pick "split dive"), and the > first 29:30 is considered a dive of its own. Actually, we have a really stupid bug in the

Re: Split a dive by time

2018-07-01 Thread Linus Torvalds
On Sun, Jul 1, 2018 at 1:07 PM tormento wrote: > I have attached the dive. It's one I did in very shallow water, half as a > open diver training assistant, the second during a rescue simulation. The > time I'd like it to be splitted is something like 29:30 from the beginning. Oh, but this

Re: Split a dive by time

2018-07-01 Thread Jan Iversen
Enviado desde mi iPad > El 1 jul 2018, a las 22:08, tormento escribió: > > Or simply, where a cursor or a mark is placed... For the desktop that is a good idea, but remember the mobile version does not have a cursor. I am in favour for a simple “split by x minutes:second” feature. I would

Re: Split a dive by time

2018-07-01 Thread tormento
Or simply, where a cursor or a mark is placed... Il giorno dom 1 lug 2018 alle ore 22:07 tormento ha scritto: > I humbly suggest that the split dive option should be by time and by depth > level, with both asked after selecting one of them and not hardcoded as > SURFACE_THRESHOLD. > > I have

Re: Split a dive by time

2018-07-01 Thread Berthold Stoeger
Hi, On Sunday, 1 July 2018 21:50:17 CEST Linus Torvalds wrote: > A lot of these things are likely fairly simple to implement, but there > are people like me who really don't do UI, but could do the "split > dive" part fairly easily. And there are probably people who could do > the UI trivially,

Re: Split a dive by time

2018-07-01 Thread Linus Torvalds
On Sun, Jul 1, 2018 at 12:06 AM tormento wrote: > > Sorry but not working for me. Perhaps I put computer not so shallow to > recognize as “surface”. As with a lot of subsurface issues, one of the main complications is having the UI integration. A lot of these things are likely fairly simple to

Re: Split a dive by time

2018-07-01 Thread tormento
Sorry but not working for me. Perhaps I put computer not so shallow to recognize as “surface”. Il giorno ven 29 giu 2018 alle 20:01 Salvador Cuñat < salvador.cu...@gmail.com> ha scritto: > Good evening. > > On Fri, Jun 29, 2018 at 06:56:03PM +0200, tormento wrote: > > There are no 0 segments,

Re: Split a dive by time

2018-06-29 Thread Salvador Cuñat
Good evening. On Fri, Jun 29, 2018 at 06:56:03PM +0200, tormento wrote: > There are no 0 segments, unfortunately. And by a defined time would be much > more useful. > > Il giorno ven 29 giu 2018 alle 14:04 Jan Mulder ha > scritto: > > > Not really what you ask for, but there is a split dive

Re: Split a dive by time

2018-06-29 Thread Jan Mulder
Not really what you ask for, but there is a split dive option in the context menu (right-click on a dive in the dive list). This splits dives that have segments of 0m depth in the profile. On 29-06-18 13:57, tormento wrote: I have a request to do: I need to split a dive in two separate ones by