Re: Suspicious if/else constructs

Hallo Berthold, Am 19.11.2017 um 13:20 schrieb Berthold Stoeger: > There is another one that might be of interest to you: > In core/planner.c, the variable o2break_done is initialized and set, but > never > actually used. Thanks again. I - not long ago - changed there s.th. together with

Re: Suspicious if/else constructs

> On Nov 19, 2017, at 4:20 AM, Berthold Stoeger > wrote: > > The few remaining gcc/g++ -Wall warnings seem all to be either style > (operator > precedence) or irrelevant precision (weight certainly does not need more than > float precision) issues. Feel free to

Re: Suspicious if/else constructs

Hi Stefan, On Samstag, 18. November 2017 22:05:59 CET Stefan Fuchs wrote: > Am 18.11.2017 um 21:50 schrieb Berthold Stoeger: > > In qt-models/diveplannermodel.cpp:341, the if is indented as if it was > > part of the outer if. But it isn't owing to missing braces. Since I don't > > know the

Re: Suspicious if/else constructs

On 18 November 2017 at 23:05, Stefan Fuchs wrote: > Hallo Berthold, > > Am 18.11.2017 um 21:50 schrieb Berthold Stoeger: > > In qt-models/diveplannermodel.cpp:341, the if is indented as if it was part > of > the outer if. But it isn't owing to missing braces. Since I don't know the

Re: Suspicious if/else constructs

Hallo Berthold, Am 18.11.2017 um 21:50 schrieb Berthold Stoeger: > In qt-models/diveplannermodel.cpp:341, the if is indented as if it was part > of > the outer if. But it isn't owing to missing braces. Since I don't know the > meaning of "value", I can't decide in this case... Ups, that is a

Suspicious if/else constructs

Dear all, at the suggestion of Lubomir I compiled with -Wall and I got two g++ warnings, which indeed point to two highly suspicious if/else constructs. The first one is trivial (PR submited). For the second one, I simply don't understand the intent of the indent (heh): In qt-models