Simon Schampijer si...@schampijer.de writes:
Thanks Daniel for the patch.
Looks good to me and reading the bug conversation this looks like the
right thing to do to me.
Sascha, you said you wanted to adjust some description?
Yes, the review showed the actual code change to be good, but
Hi,
I added a send-patches command to the sugar-build shell which tries to
streamline patch submission as much as possible. It helps setting up SMTP
interactively and then it tries to figure out as many as possible
git-send-email options. It's still a work in progress but testing and
feedback are
Hi,
I'm looking at
http://wiki.sugarlabs.org/go/Development_Team/Code_Review
and trying to understand how to submit a patch with the reviewer
comments addressed.
It first suggest
git send-to-ml-single --annotate --subject-prefix=PATCH v2 sugar
and then
git send-to-ml-single
From: Daniel Narvaez dwnarv...@gmail.com
We was starting it manually because dbus would not
activate it automatically. A proper solution to that
issue is pointed out in the following GNOME bug
https://bugzilla.gnome.org/show_bug.cgi?id=628302
Since we are running inside a GNOME session, we
need
== Source ==
http://download.sugarlabs.org/sources/sucrose/fructose/Labyrinth/Labyrinth-13.tar.bz2
== News ==
* Release 13 (Manuel Quiñones)
* Fix for image scaling, SL #3669 (Walter Bender)
* Push many files from Pootle (Pootle daemon)
___
Activity Homepage:
http://activities.sugarlabs.org/addon/4078
Sugar Platform:
0.82 - 0.96
Download Now:
http://activities.sugarlabs.org/downloads/file/28138/labyrinth-13.xo
Release notes:
* Release 13 (Manuel Quiñones)
* Fix for image scaling, SL #3669 (Walter Bender)
* Push many files from
From: Daniel Narvaez dwnarv...@gmail.com
This is based on a patch by
Marco Pesenti Gritti ma...@marcopg.org,
with reviewer comments addressed.
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index a71e202..bac5247 100755
== Source ==
http://download.sugarlabs.org/sources/sucrose/fructose/Labyrinth/Labyrinth-14.tar.bz2
== News ==
* Release 13 (Manuel Quiñones)
* Add forgotten code in the old toolbars, affects Sugar = 0.84 (Walter Bender)
___
Sugar-devel mailing list
From: Daniel Narvaez dwnarv...@gmail.com
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index b02ffac..750a5a9 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,5 +1,14 @@
#!/bin/sh
+
+test -n ${srcdir} || srcdir=`dirname
From: Daniel Narvaez dwnarv...@gmail.com
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index d09dc6a..ef569d3 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,3 +1,12 @@
#!/bin/sh
+
+test -n ${srcdir} || srcdir=`dirname
From: Daniel Narvaez dwnarv...@gmail.com
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 3d12f8f..679c2bf 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,6 +1,15 @@
#!/bin/sh
+
+test -n ${srcdir} || srcdir=`dirname
From: Daniel Narvaez dwnarv...@gmail.com
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index f25b0a3..c5e1bf3 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,6 +1,15 @@
#!/bin/sh
+
+test -n ${srcdir} || srcdir=`dirname
From: Daniel Narvaez dwnarv...@gmail.com
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index f25b0a3..c5e1bf3 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,6 +1,15 @@
#!/bin/sh
+
+test -n ${srcdir} || srcdir=`dirname
Hi,
today we will have our weekly development team meeting, the topics will be:
- Introducing new contributors
- Update list of action items
- shell port status update
Time: 26. June 2012 (15:00 UTC)
Place: #sugar-meeting (freenode)
Regards,
Simon
2012/6/25 Sameer Verma sve...@sfsu.edu:
Does GetBooks autodiscover a OPDS feed off the LAN or does it have to be
entered manually in the config?
Not currently, can be a good idea. What URL can be a good candidate
to look for in a LAN? Maybe we can add a default LAN URL in the
config file that
Well, if we have a URL, is not autodiscover ;)
Gonzalo
Not currently, can be a good idea. What URL can be a good candidate
to look for in a LAN? Maybe we can add a default LAN URL in the
config file that can be changed.
--
.. manuq ..
___
Replace the use of dbus by Gio to monitor the (dis)connection of pen
drives and show/hide them in the ComboBox used to search books
Signed-off-by: Manuel Kaufmann humi...@gmail.com
---
GetIABooksActivity.py |2 +-
devicemanager.py | 88 -
On 06/26/2012 04:23 PM, Simon Schampijer wrote:
Hi,
today we will have our weekly development team meeting, the topics will be:
- Introducing new contributors
- Update list of action items
- shell port status update
Time: 26. June 2012 (15:00 UTC)
Place: #sugar-meeting (freenode)
Regards,
Ajay Garg ajaygargn...@gmail.com writes:
NM may (re-)request the secrets in the following cases ::
a)
Wifi connection is lost. (Yes, even if the AP is switched off permanently,
the dialog-box keeps popping up periodically).
b)
After being lost, the wifi connection is again within the
Added the current and total time of the actual stream in the toolbar
and removed the separators to make them fit.
Signed-off-by: Manuel Kaufmann humi...@gmail.com
---
ControlToolbar.py | 20 +++-
jukeboxactivity.py | 17 -
2 files changed, 23 insertions(+),
- Switched Fullscreen and Show playlist buttons in View Toolbar
- Added tooltip for Add Track button
- Changed the icon for Add Track button to match the style with
the Remove Track
- Use just Remove Track as tooltip on Remove Track button
- Changed the name of the icon for Remove Track
-
Activity Homepage:
http://activities.sugarlabs.org/addon/4078
Sugar Platform:
0.84 - 0.96
Download Now:
http://activities.sugarlabs.org/downloads/file/28139/labyrinth-14.xo
Release notes:
Sugar Labs Activities
http://activities.sugarlabs.org
___
Signed-off-by: Daniel Francis fran...@sugarlabs.org
---
browser.py|6 --
pdfviewer.py |3 ++-
webtoolbar.py |6 --
widgets.py|3 ++-
4 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/browser.py b/browser.py
index 7379d2b..4091052 100644
---
Reviewed-by: James Cameron qu...@laptop.org
--
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
On Tue, Jun 26, 2012 at 12:01:00PM +0200, Daniel Narvaez wrote:
[...]
git send-to-ml-single --annotate --subject-prefix=PATCH v2 sugar
git send-to-ml-single --in-reply-to=1290857483.723...@twin.sascha.silbe.org
Which is right or in which situation should each be used?
I would think of how
On Tue, Jun 26, 2012 at 7:11 PM, James Cameron qu...@laptop.org wrote:
Reviewed-by: James Cameron qu...@laptop.org
Good!.
--
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
On Tue, Jun 26, 2012 at 02:26:02PM +0200, Daniel Narvaez wrote:
From: Daniel Narvaez dwnarv...@gmail.com
This is based on a patch by
Marco Pesenti Gritti ma...@marcopg.org,
with reviewer comments addressed.
---
autogen.sh | 11 ++-
1 file changed, 10 insertions(+), 1
On Mon, 2012-06-25 at 09:45 -0600, Daniel Drake wrote:
On Mon, Jun 25, 2012 at 9:22 AM, Samuel Greenfeld greenf...@laptop.org
wrote:
How does GNOME handle this?
Yes, I think thats the critical information missing from the patch
description.
We need to see if we match the GNOME
Signed-off-by: Agustin Zubiaga a...@sugarlabs.org
---
epubview/epubview.py |9 +
readactivity.py | 11 +++
readdialog.py| 11 +++
readsidebar.py |6 --
readtoolbar.py |3 ++-
readtopbar.py|5 +++--
sugarmenuitem.py
Thanks for the patch. I have review comments for one change:
On Tue, Jun 26, 2012 at 10:53:57PM -0300, Agustin Zubiaga wrote:
[...]
diff --git a/readtopbar.py b/readtopbar.py
index d0da3d0..b6fe196 100644
--- a/readtopbar.py
+++ b/readtopbar.py
@@ -33,15 +33,16 @@ _UP_DEVICE_IFACE =
On Tue, Jun 26, 2012 at 8:55 AM, Gonzalo Odiard gonz...@laptop.org wrote:
Well, if we have a URL, is not autodiscover ;)
Gonzalo
I was looking at the get-books.cfg file. I got some success by
including IP address/latest.atom in the catalog, but that only lists
5 books (in my settings, I have
---
src/sugar3/activity/widgets.py |3 ++-
src/sugar3/graphics/alert.py|9 ++---
src/sugar3/graphics/notebook.py |6 --
src/sugar3/graphics/palette.py | 27 +++
src/sugar3/graphics/panel.py|3 ++-
On Tue, Jun 26, 2012 at 8:22 AM, Manuel Quiñones ma...@laptop.org wrote:
2012/6/25 Sameer Verma sve...@sfsu.edu:
Does GetBooks autodiscover a OPDS feed off the LAN or does it have to be
entered manually in the config?
Not currently, can be a good idea. What URL can be a good candidate
to
On Mon, Jun 25, 2012 at 3:17 PM, Chris Leonard cjlhomeaddr...@gmail.com wrote:
On Mon, Jun 25, 2012 at 4:53 PM, Sameer Verma sve...@sfsu.edu wrote:
Does GetBooks autodiscover a OPDS feed off the LAN or does it have to be
entered manually in the config?
This has me thinking about the Pathagar
Hi, James
sorry, I didn't want to do it.
Can you remove it?
2012/6/27 Rafael Ortiz raf...@activitycentral.com
On Tue, Jun 26, 2012 at 9:20 PM, James Cameron qu...@laptop.org wrote:
Thanks for the patch. I have review comments for one change:
On Tue, Jun 26, 2012 at 10:53:57PM -0300,
Reviewed-by: James Cameron qu...@laptop.org
I note other people have accepted the default orientation in their
patches. I'm not sure which method is best. I think it is fine
either way.
(Also, I blame upstream for causing this extra work. I can see no
good reason for deprecating these
On Wed, Jun 27, 2012 at 12:19:55AM -0300, Agustin Zubiaga Sanchez wrote:
sorry, I didn't want to do it.
Can you remove it?
No, not me.
This brings up an interesting process question. If I was a committer,
I would modify and apply the patch. You would then have to merge the
conflict.
A virtual machine with Pathagar Book Server preloaded and ready to
use. If you've wondered what this thing is like, try it out!
http://olpcsf.org/node/60
cheers,
Sameer
--
Sameer Verma, Ph.D.
Professor, Information Systems
San Francisco State University
http://verma.sfsu.edu/
(Also, I blame upstream for causing this extra work. I can see no
good reason for deprecating these classes.)
+1
Gonzalo
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Ok, In this message I send my patch again but without this line.
Regards,
aguz
2012/6/27 James Cameron qu...@laptop.org
On Wed, Jun 27, 2012 at 12:19:55AM -0300, Agustin Zubiaga Sanchez wrote:
sorry, I didn't want to do it.
Can you remove it?
No, not me.
This brings up an interesting
On Wed, Jun 27, 2012 at 12:46:00AM -0300, Agustin Zubiaga Sanchez wrote:
Ok, In this message I send my patch again but without this line.
Reviewed-by: James Cameron qu...@laptop.org
(Also tested that it applies cleanly to master).
--
James Cameron
http://quozl.linux.org.au/
41 matches
Mail list logo
