Re: [Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-03 Thread Simon Schampijer
On 11/03/2010 04:24 AM, Anish Mangal wrote: Hi, Thank you for the patch, however, * I'd prefer two patches for two different changes (layout compatibility fix, edit toolbar), as I mailed earlier. * Your patch moves the activity-exit button to the left for sugar 0.88+. This [1] is how it should

Re: [Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-03 Thread Gary Martin
Hi Gonzalo, On 3 Nov 2010, at 02:40, Gonzalo Odiard wrote: > This patch modify the last two patches from Anish to enable the use of the > right toolbars in every Sugar version. > There are screenshots here: > http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.84.png > http://dev.laptop.org/~gonzal

Re: [Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-03 Thread Gonzalo Odiard
On Wed, Nov 3, 2010 at 12:24 AM, Anish Mangal wrote: > Hi, > > Thank you for the patch, however, > > * I'd prefer two patches for two different changes (layout > compatibility fix, edit toolbar), as I mailed earlier. > Ok, resolve first the last. Does not have sense make two patches if you don't

Re: [Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-02 Thread Anish Mangal
Hi, Thank you for the patch, however, * I'd prefer two patches for two different changes (layout compatibility fix, edit toolbar), as I mailed earlier. * Your patch moves the activity-exit button to the left for sugar 0.88+. This [1] is how it should look. * Regarding the layout-fix, your patch i

Re: [Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-02 Thread Gonzalo Odiard
This patch modify the last two patches from Anish to enable the use of the right toolbars in every Sugar version. There are screenshots here: http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.84.png http://dev.laptop.org/~gonzalo/pippy-in-sugar-0.90.png Gonzalo __

[Sugar-devel] [PATCH Pippy] Add EditToolbar and modify toolbars to support the older from sugar < 0.86

2010-11-02 Thread godiard
From: Gonzalo Odiard --- groupthink/sugar_tools.py | 23 +--- pippy_app.py | 87 +++-- 2 files changed, 94 insertions(+), 16 deletions(-) diff --git a/groupthink/sugar_tools.py b/groupthink/sugar_tools.py index 0292a0b..66d4a0e 10