Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-31 Thread Simon Schampijer
On 01/31/2012 12:31 AM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2012-01-30 23:32:23 +0100: If you have a long text been played, and want finish or start again from the beginning, you need a stop button. How about a rewind button instead? That would make it clearer what

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-30 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2012-01-30 23:32:23 +0100: > >> If you have a long text been played, and want finish or start again > >> from the beginning, you need a stop button. > > > > How about a rewind button instead? That would make it clearer what the > > difference between the

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-30 Thread Simon Schampijer
On 01/30/2012 08:55 PM, Sascha Silbe wrote: Excerpts from Gonzalo Odiard's message of 2012-01-25 17:46:01 +0100: [...] Why do we need a Stop button in addition to Play/Pause? And where does this callback get invoked? AFAICT the hook-up is commented out. If you have a long text been played, an

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-30 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of 2012-01-25 17:46:01 +0100: > > Please use pep8 and pylint [2] to check your code prior to submission > > [3,4]. > > I have used it. If you see any problem tell me. I saw at least one occasion of three blank lines in a row. Nothing serious, but pep8 will

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-25 Thread Gonzalo Odiard
On Mon, Jan 23, 2012 at 1:08 PM, Sascha Silbe wrote: > Excerpts from godiard's message of 2012-01-17 22:49:31 +0100: > > > Added controls to pause/stop and addressed suggestions > > in the review process. > > Please put the changelog below the marker line, i.e. below this one: > > > --- > > Please

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-23 Thread Sascha Silbe
Excerpts from godiard's message of 2012-01-17 22:49:31 +0100: > Added controls to pause/stop and addressed suggestions > in the review process. Please put the changelog below the marker line, i.e. below this one: > --- Please add a description. Besides other things I'm missing a clear mention t

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-19 Thread Simon Schampijer
On 01/18/2012 03:25 PM, Gonzalo Odiard wrote: Thanks, please read my reply to your review mail http://lists.sugarlabs.org/archive/sugar-devel/2012-January/035292.html More below... On Wed, Jan 18, 2012 at 5:05 AM, Simon Schampijerwrote: On 17/01/12 22:49, godi...@sugarlabs.org wrote: From: G

Re: [Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-18 Thread Simon Schampijer
On 17/01/12 22:49, godi...@sugarlabs.org wrote: From: Gonzalo Odiard Added controls to pause/stop and addressed suggestions in the review process. Thanks for the update! - one thing that is not solved yet, is the item that gets created in the clipboard tray - when I do not have text select

[Sugar-devel] [Sugar] Implement text to speech in Sugar feature - v2

2012-01-17 Thread godiard
From: Gonzalo Odiard Added controls to pause/stop and addressed suggestions in the review process. --- data/sugar.schemas.in | 28 extensions/deviceicon/Makefile.am |1 + extensions/deviceicon/speech.py | 204 extensions/globalkey/Makefile.a