Re: [Suspend-devel] [RFT][PATCH] Use libgcrypt instead of openssl

2006-07-20 Thread Luca Tettamanti
On 7/20/06, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Thursday 20 July 2006 18:58, Luca wrote: > > (btw, rsa_data_set was leacked): > > Yes, it was intentional. If you free the key created out of a data set, you > can't free the data set itself, apparently, or you get a double free > (libg

[Suspend-devel] [PATCH] Use libgcrypt instead of openssl (rev. 3)

2006-07-20 Thread Rafael J. Wysocki
Hi, This is the version of the libgcrypt patch that I'd like to apply, if there are no objections. Of course it makes s2disk/s2both and resume use libgcrypt instead of openssl, and replaces Blowfish with 128-bit AES (AES appears to 10% faster, although it is slower than the Blowfish out of openss

Re: [Suspend-devel] [RFT][PATCH] Use libgcrypt instead of openssl

2006-07-20 Thread Rafael J. Wysocki
On Thursday 20 July 2006 18:58, Luca wrote: > Il Wed, Jul 19, 2006 at 10:13:00PM +0200, Rafael J. Wysocki ha scritto: > > On Wednesday 19 July 2006 21:38, Luca wrote: > > > Il Wed, Jul 19, 2006 at 05:55:17PM +0200, Rafael J. Wysocki ha scritto: > > > > The libgcrypt's AES seems to be significantl

Re: [Suspend-devel] [RFT][PATCH] Use libgcrypt instead of openssl

2006-07-20 Thread Luca
Il Wed, Jul 19, 2006 at 10:13:00PM +0200, Rafael J. Wysocki ha scritto: > On Wednesday 19 July 2006 21:38, Luca wrote: > > Il Wed, Jul 19, 2006 at 05:55:17PM +0200, Rafael J. Wysocki ha scritto: > > > The libgcrypt's AES seems to be significantly slower than the openssl's > > > Blowfish, but well

Re: [Suspend-devel] [PATCH] Makefile cleanup

2006-07-20 Thread Rafael J. Wysocki
On Thursday 20 July 2006 00:48, Pavel Machek wrote: > Hi! > > > The appended patch fixes Makefiles so that s2both gets built too if 'make' > > is > > run without arguments. > > Looks good to me. Committed. > (Sorry, I probably will not be able to test the new encrypted swsusp -- I'm > at OLS a

Re: [Suspend-devel] s2ram: "vbemode get/set" hack, please review

2006-07-20 Thread Stefan Seyfried
On Wed, Jul 19, 2006 at 12:16:54PM +0200, Rafael J. Wysocki wrote: > On Wednesday 19 July 2006 12:06, Stefan Seyfried wrote: > > On Wed, Jul 19, 2006 at 12:00:48PM +0200, Rafael J. Wysocki wrote: > ]--snip--[ > > > > +void set_vbe_mode(int mode) > > > > +{ > > > > + (void)do_set_mode(mode,

Re: [Suspend-devel] s2ram flags for Epia-M mobo

2006-07-20 Thread Stefan Seyfried
On Thu, Jul 20, 2006 at 05:32:12AM +0200, Pavel Machek wrote: > Hi! > > I'd rather say "call s2ram with the correct options" and let HAL figure > > out the correct options. > > I'd prefer HAL figure out the complex options, but still leave > "simple" whitelist inside s2ram. Yes, that's fine wit