Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 23:51, Pavel Machek wrote: > On Thu 2006-11-02 23:07:32, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > > > Hi! > > > > > > > > > > The appended patch allows the users of suspend to abort the image > > > > > > > saving by > > >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
On Thu 2006-11-02 23:07:32, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > > Hi! > > > > > > > > The appended patch allows the users of suspend to abort the image > > > > > > saving by > > > > > > pressing Ctrl+c. > > > > > > > > > > It would be nice to abor

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 22:43, Pavel Machek wrote: > Hi! > > > > > Sounds good, but generally we have two options now: We can apply the > > > > patch > > > > as is and then add the libsplashy function or we can wait with applying > > > > the > > > > patch until the libsplashy function is re

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > Hi! > > > > > > The appended patch allows the users of suspend to abort the image > > > > > saving by > > > > > pressing Ctrl+c. > > > > > > > > It would be nice to abort with escape or something... ctrl+c is going > > > > to be "interest

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > Sounds good, but generally we have two options now: We can apply the patch > > > as is and then add the libsplashy function or we can wait with applying > > > the > > > patch until the libsplashy function is ready. > > > > > > So, if the patch doesn't break splashy, I'd like to apply

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > > The appended patch allows the users of suspend to abort the image > > > > saving by > > > > pressing Ctrl+c. > > > > > > It would be nice to abort with escape or something... ctrl+c is going > > > to be "interesting" for users using splashscreen. > > > > OK > > Escape (and f2) swit

Re: [Suspend-devel] Release, maybe?

2006-11-02 Thread Pavel Machek
Hi! > On a completely unrelated note I recently installed Ubuntu Edgy to > have a stable system with some new features but was annoyed that > suspend to ram does not work there. They don't seem to use s2ram or > even have packages for it. I tried just using an s2ram binary I had > downloaded som

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 20:47, Tim Dijkstra wrote: > On Thu, 2 Nov 2006 17:20:39 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > > > Op Thu, 2 Nov 2006 16:10:04 +0100 > > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>:

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
On Thu, 2 Nov 2006 17:20:39 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > > Op Thu, 2 Nov 2006 16:10:04 +0100 > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > > > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > Op Thu, 2 Nov 2006 16:10:04 +0100 > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > > > Op Thu, 2 Nov 2006 08:07:36 +0100 > > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
Op Thu, 2 Nov 2006 16:10:04 +0100 schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > > Op Thu, 2 Nov 2006 08:07:36 +0100 > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > > > Hi, > > > > > > The appended patch allows the users of

Re: [Suspend-devel] Release, maybe?

2006-11-02 Thread Rafael J. Wysocki
Hi, On Thursday, 2 November 2006 15:32, Sheer El-Showk wrote: > Hi Rafael, > > Following up on this I noticed you checked on my kernel bug report > (bug #7135) to see if any of the kernel devs are working on it and > Alan said that it will only be addressed as part of a larger project. > Are you

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > Op Thu, 2 Nov 2006 08:07:36 +0100 > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > Hi, > > > > The appended patch allows the users of suspend to abort the image > > saving by pressing Ctrl+c. > > > > Comments welcome. > > This is

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote: > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > > Hi! > > > > > > > The appended patch allows the users of suspend to abort the image > > > > saving by >

Re: [Suspend-devel] Release, maybe?

2006-11-02 Thread Sheer El-Showk
Hi Rafael, Following up on this I noticed you checked on my kernel bug report (bug #7135) to see if any of the kernel devs are working on it and Alan said that it will only be addressed as part of a larger project. Are you (and others) planning to look at this (and related bugs) after you release

Re: [Suspend-devel] [Patch] Add SONY Vaio VGN-FS215B into whitelist

2006-11-02 Thread S.Çağlar Onur
02 Kas 2006 Per 15:32 tarihinde, Stefan Seyfried şunları yazmıştı: > Ok. Does this also work from the text mode or only from X? It would almost > be too good to believe :-) Believe me its suspends and resumes back without a problem from both X and console mode :) -- S.Çağlar Onur <[EMAIL PROTE

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
Op Thu, 2 Nov 2006 08:07:36 +0100 schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > Hi, > > The appended patch allows the users of suspend to abort the image > saving by pressing Ctrl+c. > > Comments welcome. This is not going to work for splashy. We will need wrap the call to 'read' in the sp

Re: [Suspend-devel] [Patch] Add SONY Vaio VGN-FS215B into whitelist

2006-11-02 Thread Stefan Seyfried
On Thu, Nov 02, 2006 at 02:28:55PM +0200, S.Çağlar Onur wrote: > Hi; > > SONY Vaio VGN-FS215B suspends/resumes without a problem, attached patch is a > whitelist update. > > This machine can be identified by: > sys_vendor = "Sony Corporation" > sys_product = "VGN-FS215B" > sys_ver

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Stefan Seyfried
On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > Hi! > > > > > The appended patch allows the users of suspend to abort the image saving > > > by > > > pressing Ctrl+c. > > > > It would be nice to abort with escape or

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > > @@ -451,20 +476,34 @@ static int save_image(struct swap_map_ha > > > > error = swap_write_page(handle); > > > > if (error) > > > > break; > > > > + > > > > if (!(nr_pages % m)) { > >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 11:29, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > Hi! > > > > > The appended patch allows the users of suspend to abort the image saving > > > by > > > pressing Ctrl+c. > > > > It would be nice to abort with escape or somet

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > Hi! > > > The appended patch allows the users of suspend to abort the image saving by > > pressing Ctrl+c. > > It would be nice to abort with escape or something... ctrl+c is going > to be "interesting" for users using splashscreen. OK >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > The appended patch allows the users of suspend to abort the image saving by > pressing Ctrl+c. It would be nice to abort with escape or something... ctrl+c is going to be "interesting" for users using splashscreen. > - printf("suspend: Saving image data pages (%u pages) ... ", > n