Re: [Suspend-devel] [RFC][PATCH] swsusp: Reduce code duplication between user.c and disk.c

2007-05-07 Thread Rafael J. Wysocki
On Monday, 7 May 2007 14:26, Pavel Machek wrote: > On Mon 2007-05-07 13:43:11, Johannes Berg wrote: > > Hi, > > > > > However, this modifies the user-observable behavior in such a way that > > > if the user sets 'shutdown mode = platform' in the s2disk's configuration > > > file, > > > the kernel

Re: [Suspend-devel] [RFC][PATCH] swsusp: Reduce code duplication between user.c and disk.c

2007-05-07 Thread Pavel Machek
On Mon 2007-05-07 13:43:11, Johannes Berg wrote: > Hi, > > > However, this modifies the user-observable behavior in such a way that > > if the user sets 'shutdown mode = platform' in the s2disk's configuration > > file, > > the kernel will use the hibernation mode resulting from the sysfs interfa

Re: [Suspend-devel] [RFC][PATCH] swsusp: Reduce code duplication between user.c and disk.c

2007-05-07 Thread Johannes Berg
Hi, > However, this modifies the user-observable behavior in such a way that > if the user sets 'shutdown mode = platform' in the s2disk's configuration > file, > the kernel will use the hibernation mode resulting from the sysfs interface > settings. That is, if there is 'shutdown mode = platfor

[Suspend-devel] [RFC][PATCH] swsusp: Reduce code duplication between user.c and disk.c

2007-05-05 Thread Rafael J. Wysocki
Hi, Currently much of the code in kernel/power/disk.c is duplicated in kernel/power/user.c , mainly for historical reasons. By eliminating this duplication we can reduce the size of user.c quite substantially and remove the maintenance difficulty with making essentially the same changes in two di