Re: [Suspend-devel] Remove useless errror messages

2006-11-30 Thread Rafael J. Wysocki
On Thursday, 30 November 2006 13:53, Stefan Seyfried wrote: > On Thu, Nov 30, 2006 at 10:53:56AM +0100, Tim Dijkstra wrote: > > > So by checking errno we can distinguish 'to old > > kernel' from 'real error'? > > Yes, i think so. I have not checked all the possible cases where the > error return

Re: [Suspend-devel] Remove useless errror messages

2006-11-30 Thread Tim Dijkstra
Op Thu, 30 Nov 2006 13:53:46 +0100 schreef Stefan Seyfried <[EMAIL PROTECTED]>: > > BTW, what is the first kernel with the correct code? It's not in > > 2.16.18, is it? Ah, I see they just released 2.6.19, is it in there? > > I think it is (i pushed it through Andrew), but i have not checked it.

Re: [Suspend-devel] Remove useless errror messages

2006-11-30 Thread Stefan Seyfried
On Thu, Nov 30, 2006 at 10:53:56AM +0100, Tim Dijkstra wrote: > So by checking errno we can distinguish 'to old > kernel' from 'real error'? Yes, i think so. I have not checked all the possible cases where the error return value is set, but i think it cannot return -ENOTTY other than for this ca

Re: [Suspend-devel] Remove useless errror messages

2006-11-30 Thread Tim Dijkstra
Op Thu, 30 Nov 2006 08:11:09 +0100 schreef Stefan Seyfried <[EMAIL PROTECTED]>: > Hi, > > On Wed, Nov 29, 2006 at 10:16:12PM +0100, Tim Dijkstra wrote: > > On Wed, 29 Nov 2006 12:09:02 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > On Wednesday, 29 November 2006 11:59, Tim Dijk

Re: [Suspend-devel] Remove useless errror messages

2006-11-29 Thread Stefan Seyfried
Hi, On Wed, Nov 29, 2006 at 10:16:12PM +0100, Tim Dijkstra wrote: > On Wed, 29 Nov 2006 12:09:02 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > On Wednesday, 29 November 2006 11:59, Tim Dijkstra wrote: > > > If the kernel doesn't have support for platform mode, uswsusp complains > >

Re: [Suspend-devel] Remove useless errror messages

2006-11-29 Thread Tim Dijkstra
On Wed, 29 Nov 2006 12:09:02 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > Hi, > > On Wednesday, 29 November 2006 11:59, Tim Dijkstra wrote: > > Hi guys, > > > > If the kernel doesn't have support for platform mode, uswsusp complains > > loudly. > > > > suspend: pm_ops->prepare returne

Re: [Suspend-devel] Remove useless errror messages

2006-11-29 Thread Rafael J. Wysocki
Hi, On Wednesday, 29 November 2006 11:59, Tim Dijkstra wrote: > Hi guys, > > If the kernel doesn't have support for platform mode, uswsusp complains > loudly. > > suspend: pm_ops->prepare returned error -1 > suspend: Snapshotting system > ... > suspend: Saving image data pages ... > suspend: pm_

[Suspend-devel] Remove useless errror messages

2006-11-29 Thread Tim Dijkstra
Hi guys, If the kernel doesn't have support for platform mode, uswsusp complains loudly. suspend: pm_ops->prepare returned error -1 suspend: Snapshotting system ... suspend: Saving image data pages ... suspend: pm_ops->enter returned error -1, calling power_off These are harmless messages, becau