Re: svn commit: r324541 - in head: share/man/man9 sys/kern sys/sys

> On Oct 11, 2017, at 14:53, Matt Joras wrote: > > Author: mjoras > Date: Wed Oct 11 21:53:50 2017 > New Revision: 324541 > URL: https://svnweb.freebsd.org/changeset/base/324541 > > Log: > Add clearing function for unr(9). > > Previously before you could call

svn commit: r324614 - head/sys/sys

Author: mjg Date: Sat Oct 14 04:27:58 2017 New Revision: 324614 URL: https://svnweb.freebsd.org/changeset/base/324614 Log: Fix wrong v_free_count annotation - (f) instead of (a) Reported by: alc Modified: head/sys/sys/vmmeter.h Modified: head/sys/sys/vmmeter.h

Re: svn commit: r324609 - head/sys/sys

On Sat, Oct 14, 2017 at 2:30 AM, Ian Lepore wrote: > On Fri, 2017-10-13 at 23:38 +0200, Svatopluk Kraus wrote: > > MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you > > removed it actually. I have very bad feeling about it. But maybe, it's > > really possible

svn commit: r324613 - head/sys/kern

Author: mjg Date: Sat Oct 14 00:47:30 2017 New Revision: 324613 URL: https://svnweb.freebsd.org/changeset/base/324613 Log: mtx: fix up owner_mtx after r324609 Now that MTX_UNOWNED is 0 the test was alwayas false. Modified: head/sys/kern/kern_mutex.c Modified: head/sys/kern/kern_mutex.c

Re: svn commit: r324609 - head/sys/sys

On Fri, 2017-10-13 at 23:38 +0200, Svatopluk Kraus wrote: > MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you > removed it actually. I have very bad feeling about it. But maybe, it's > really possible and in that case, a very good explanation should be > provided. > > Svata >

Re: svn commit: r324609 - head/sys/sys

MTX_UNOWNED is a flag. You did not change its value from 4 to 0, you removed it actually. I have very bad feeling about it. But maybe, it's really possible and in that case, a very good explanation should be provided. Svata On Fri, Oct 13, 2017 at 10:31 PM, Mateusz Guzik

svn commit: r324612 - in stable: 10/sys/ufs/ffs 11/sys/ufs/ffs

Author: jhb Date: Fri Oct 13 22:40:57 2017 New Revision: 324612 URL: https://svnweb.freebsd.org/changeset/base/324612 Log: MFC 324039: Don't defer wakeup()s for completed journal workitems. Normally wakeups() are performed for completed softupdates work items in workitem_free() before

svn commit: r324612 - in stable: 10/sys/ufs/ffs 11/sys/ufs/ffs

Author: jhb Date: Fri Oct 13 22:40:57 2017 New Revision: 324612 URL: https://svnweb.freebsd.org/changeset/base/324612 Log: MFC 324039: Don't defer wakeup()s for completed journal workitems. Normally wakeups() are performed for completed softupdates work items in workitem_free() before

svn commit: r324611 - in stable: 10/sys/kern 11/sys/kern

Author: jhb Date: Fri Oct 13 21:58:44 2017 New Revision: 324611 URL: https://svnweb.freebsd.org/changeset/base/324611 Log: MFC 324073: Use UMA_ALIGNOF() for name cache UMA zones. This fixes kernel crashes due to misaligned accesses to the 64-bit time_t embedded in struct namecache_ts in

svn commit: r324611 - in stable: 10/sys/kern 11/sys/kern

Author: jhb Date: Fri Oct 13 21:58:44 2017 New Revision: 324611 URL: https://svnweb.freebsd.org/changeset/base/324611 Log: MFC 324073: Use UMA_ALIGNOF() for name cache UMA zones. This fixes kernel crashes due to misaligned accesses to the 64-bit time_t embedded in struct namecache_ts in

svn commit: r324610 - in head/sys: sys vm

Author: mjg Date: Fri Oct 13 21:54:34 2017 New Revision: 324610 URL: https://svnweb.freebsd.org/changeset/base/324610 Log: Reduce traffic on vm_cnt.v_free_count The variable is modified with the highly contended page free queue lock. It unnecessarily shares a cacheline with purely

Re: svn commit: r324471 - head/sys/boot

> On Oct 13, 2017, at 8:53 AM, Ngie Cooper wrote: > > >> On Oct 9, 2017, at 21:57, Ngie Cooper (yaneurabeya) >> wrote: >> >> >>> On Oct 9, 2017, at 21:56, Warner Losh wrote: >>> >>> DO NOT MAKE EDITS TO sys/boot. YOU ARE

Re: svn commit: r324609 - head/sys/sys

On Fri, Oct 13, 2017 at 10:54 PM, Ian Lepore wrote: > On Fri, 2017-10-13 at 20:31 +, Mateusz Guzik wrote: > > Author: mjg > > Date: Fri Oct 13 20:31:56 2017 > > New Revision: 324609 > > URL: https://svnweb.freebsd.org/changeset/base/324609 > > > > Log: > > mtx: change

Re: svn commit: r324609 - head/sys/sys

On Fri, 2017-10-13 at 20:31 +, Mateusz Guzik wrote: > Author: mjg > Date: Fri Oct 13 20:31:56 2017 > New Revision: 324609 > URL: https://svnweb.freebsd.org/changeset/base/324609 > > Log: >   mtx: change MTX_UNOWNED from 4 to 0 >    >   The value is spread all over the kernel and zeroing a

svn commit: r324609 - head/sys/sys

Author: mjg Date: Fri Oct 13 20:31:56 2017 New Revision: 324609 URL: https://svnweb.freebsd.org/changeset/base/324609 Log: mtx: change MTX_UNOWNED from 4 to 0 The value is spread all over the kernel and zeroing a register is cheaper/shorter than setting it up to an arbitrary value.

svn commit: r324608 - head/etc/devd

Author: kp Date: Fri Oct 13 20:29:35 2017 New Revision: 324608 URL: https://svnweb.freebsd.org/changeset/base/324608 Log: Regenerate usb.conf Modified: head/etc/devd/usb.conf Modified: head/etc/devd/usb.conf == ---

svn commit: r324607 - in head/sys/dev/usb: . serial

Author: kp Date: Fri Oct 13 19:41:35 2017 New Revision: 324607 URL: https://svnweb.freebsd.org/changeset/base/324607 Log: Support the D-Link DWM-222 LTE Dongle Submitted by: Daniel Hänschke Modified: head/sys/dev/usb/serial/u3g.c head/sys/dev/usb/usbdevs

svn commit: r324606 - head/sys/compat/linuxkpi/common/src

Author: markj Date: Fri Oct 13 19:27:33 2017 New Revision: 324606 URL: https://svnweb.freebsd.org/changeset/base/324606 Log: Make the PHOLD in linux_wait_event_common() unconditional. After some in-progress work is committed, this would otherwise be the only instance of #if(n)def

svn commit: r324605 - head/targets/pseudo/userland/gnu

Author: emaste Date: Fri Oct 13 18:30:32 2017 New Revision: 324605 URL: https://svnweb.freebsd.org/changeset/base/324605 Log: clean up remnants of removed GPL software send-pr r267486 texinfo r276551 ranlibr286332 sdiff r298823 rcs r307351 diff r317209

svn commit: r324604 - head/targets/pseudo/userland/gnu

Author: emaste Date: Fri Oct 13 18:23:08 2017 New Revision: 324604 URL: https://svnweb.freebsd.org/changeset/base/324604 Log: Remove additional groff leftovers (r319664) Modified: head/targets/pseudo/userland/gnu/Makefile.depend Modified: head/targets/pseudo/userland/gnu/Makefile.depend

svn commit: r324603 - head

Author: emaste Date: Fri Oct 13 17:15:17 2017 New Revision: 324603 URL: https://svnweb.freebsd.org/changeset/base/324603 Log: ObsoleteFiles.inc: correct year on libstand removal Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

svn commit: r324602 - in stable: 10/sys/vm 11/sys/vm

Author: jhb Date: Fri Oct 13 17:11:08 2017 New Revision: 324602 URL: https://svnweb.freebsd.org/changeset/base/324602 Log: MFC 324072: Add UMA_ALIGNOF(). This is a wrapper around _Alignof() that sets the alignment for a zone to the alignment required by a given type. This allows the

svn commit: r324602 - in stable: 10/sys/vm 11/sys/vm

Author: jhb Date: Fri Oct 13 17:11:08 2017 New Revision: 324602 URL: https://svnweb.freebsd.org/changeset/base/324602 Log: MFC 324072: Add UMA_ALIGNOF(). This is a wrapper around _Alignof() that sets the alignment for a zone to the alignment required by a given type. This allows the

svn commit: r324601 - head/sys/kern

Author: alc Date: Fri Oct 13 16:31:50 2017 New Revision: 324601 URL: https://svnweb.freebsd.org/changeset/base/324601 Log: Address two problems with sendfile(..., SF_NOCACHE) and apply one "optimization". First, sendfile(..., SF_NOCACHE) frees pages without checking whether those pages are

svn commit: r324600 - head/sys/vm

Author: kib Date: Fri Oct 13 16:23:05 2017 New Revision: 324600 URL: https://svnweb.freebsd.org/changeset/base/324600 Log: Evaluate the real size of the sblk_zone. Submitted by: o...@j.email.ne.jp PR: 221356 Reviewed by: alc, markj MFC after:1 week Differential revision:

Re: svn commit: r324471 - head/sys/boot

> On Oct 9, 2017, at 21:57, Ngie Cooper (yaneurabeya) > wrote: > > >> On Oct 9, 2017, at 21:56, Warner Losh wrote: >> >> DO NOT MAKE EDITS TO sys/boot. YOU ARE CREATING CONFLICTS FOR ME. >> >> DO NOT MAKE ANY COMMITS TO sys/boot. >> >> BACK OFF. >>

svn commit: r324599 - head/release/arm

Author: gjb Date: Fri Oct 13 15:16:57 2017 New Revision: 324599 URL: https://svnweb.freebsd.org/changeset/base/324599 Log: Increase the arm/armv6 and arm/armv7 images from 2.5GB to 3GB, since the RPI2 (at least) does not fit in 2.5GB. While here, add a missing BOARDNAME to RPI2.conf.

svn commit: r324598 - head/sys/dev/hwpmc

Author: br Date: Fri Oct 13 15:02:29 2017 New Revision: 324598 URL: https://svnweb.freebsd.org/changeset/base/324598 Log: o Support for Kabylake CPU PMCs (fall down to PMC_CPU_INTEL_SKYLAKE). o Fix bugs in events descriptions for Skylake, Skylake Xeon and Haswell. Reviewed by: kib

Re: svn commit: r324580 - head/sys/net80211

In message <201710130649.v9d6n7ci036...@repo.freebsd.org>, Adrian Chadd writes: > Author: adrian > Date: Fri Oct 13 06:49:07 2017 > New Revision: 324580 > URL: https://svnweb.freebsd.org/changeset/base/324580 > > Log: > [net80211] don't try to follow a NULL rxs pointer down the sink. > >

svn commit: r324597 - head/sys/compat/linuxkpi/common/src

Author: hselasky Date: Fri Oct 13 14:14:46 2017 New Revision: 324597 URL: https://svnweb.freebsd.org/changeset/base/324597 Log: Don't call selrecord() outside the select system call in the LinuxKPI, because then td->td_sel is NULL and this will result in a segfault inside selrecord(). This

svn commit: r324596 - stable/11/cddl/contrib/opensolaris/lib/libdtrace/common

Author: markj Date: Fri Oct 13 13:56:44 2017 New Revision: 324596 URL: https://svnweb.freebsd.org/changeset/base/324596 Log: MFC r324373: Avoid adding an extra "0x" prefix before pointer formats. Modified: stable/11/cddl/contrib/opensolaris/lib/libdtrace/common/dt_dis.c

svn commit: r324595 - head/sys/vm

Author: emaste Date: Fri Oct 13 13:53:19 2017 New Revision: 324595 URL: https://svnweb.freebsd.org/changeset/base/324595 Log: ANSIfy vm_kern.c PR: 222673 Submitted by: o...@j.email.ne.jp MFC after:1 week Modified: head/sys/vm/vm_kern.c Modified: head/sys/vm/vm_kern.c

svn commit: r324594 - head/usr.bin/truss

Author: emaste Date: Fri Oct 13 13:47:55 2017 New Revision: 324594 URL: https://svnweb.freebsd.org/changeset/base/324594 Log: truss: mention 'H' in usage r295930 introduced the 'H' option to display thread IDs, but did not add the option to usage(). PR: 222837 Submitted

svn commit: r324593 - head/sys/netpfil/ipfw

Author: ae Date: Fri Oct 13 11:11:53 2017 New Revision: 324593 URL: https://svnweb.freebsd.org/changeset/base/324593 Log: Fix regression in handling O_FORWARD_IP opcode after r279948. To properly handle 'fwd tablearg,port' opcode, copy sin_port value from sockaddr_in structure stored in

svn commit: r324592 - head/sbin/ipfw

Author: ae Date: Fri Oct 13 11:01:33 2017 New Revision: 324592 URL: https://svnweb.freebsd.org/changeset/base/324592 Log: Return 'errno' value from the table_do_modify_record(), it is expected by table_modify_record(). This makes quiet operations with tables really quiet. PR:

svn commit: r324591 - head/sys/kern

Author: avg Date: Fri Oct 13 09:42:05 2017 New Revision: 324591 URL: https://svnweb.freebsd.org/changeset/base/324591 Log: remove process and jail directory machinations from dounmount The manipulations done by mountcheckdirs() are not that useful during the unmount, they can bring about

svn commit: r324590 - head/usr.sbin/i2c

Author: avg Date: Fri Oct 13 09:21:41 2017 New Revision: 324590 URL: https://svnweb.freebsd.org/changeset/base/324590 Log: i2c(8): clean up and clarify read operation The code went to a lot of trouble to issue either a start+stop condition or a repeated start condition only to follow it

svn commit: r324589 - stable/10/sys/geom/mirror

Author: avg Date: Fri Oct 13 09:14:05 2017 New Revision: 324589 URL: https://svnweb.freebsd.org/changeset/base/324589 Log: MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error Modified: stable/10/sys/geom/mirror/g_mirror.c stable/10/sys/geom/mirror/g_mirror.h Directory

svn commit: r324588 - stable/11/sys/geom/mirror

Author: avg Date: Fri Oct 13 09:13:08 2017 New Revision: 324588 URL: https://svnweb.freebsd.org/changeset/base/324588 Log: MFC r323612: gmirror: treat ENXIO as disk disconnect, not media error Modified: stable/11/sys/geom/mirror/g_mirror.c stable/11/sys/geom/mirror/g_mirror.h Directory

svn commit: r324587 - stable/10/cddl/contrib/opensolaris/lib/libzpool/common

Author: avg Date: Fri Oct 13 09:11:24 2017 New Revision: 324587 URL: https://svnweb.freebsd.org/changeset/base/324587 Log: MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global panicstr Modified: stable/10/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c Directory

svn commit: r324586 - stable/11/cddl/contrib/opensolaris/lib/libzpool/common

Author: avg Date: Fri Oct 13 09:10:37 2017 New Revision: 324586 URL: https://svnweb.freebsd.org/changeset/base/324586 Log: MFC r323528: MFV r323527: 5815 libzpool's panic function doesn't set global panicstr Modified: stable/11/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c Directory

svn commit: r324585 - stable/10/cddl/contrib/opensolaris/lib/libzfs/common

Author: avg Date: Fri Oct 13 09:07:58 2017 New Revision: 324585 URL: https://svnweb.freebsd.org/changeset/base/324585 Log: MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb unshare failure Modified:

svn commit: r324584 - stable/11/cddl/contrib/opensolaris/lib/libzfs/common

Author: avg Date: Fri Oct 13 09:06:57 2017 New Revision: 324584 URL: https://svnweb.freebsd.org/changeset/base/324584 Log: MFC r323525: MFV r323523: 8331 zfs_unshare returns wrong error code for smb unshare failure Modified:

svn commit: r324583 - stable/11/cddl/contrib/opensolaris/lib/libzfs/common

Author: avg Date: Fri Oct 13 09:05:32 2017 New Revision: 324583 URL: https://svnweb.freebsd.org/changeset/base/324583 Log: MFC r323524: MFV r316932: 6280 libzfs: unshare_one() could fail with EZFS_SHARENFSFAILED Modified: stable/11/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c

svn commit: r324582 - stable/10/cddl/contrib/opensolaris/lib/libzfs/common

Author: avg Date: Fri Oct 13 09:05:20 2017 New Revision: 324582 URL: https://svnweb.freebsd.org/changeset/base/324582 Log: MFC r323524: MFV r316932: 6280 libzfs: unshare_one() could fail with EZFS_SHARENFSFAILED Modified: stable/10/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c

Re: svn commit: r324580 - head/sys/net80211

On 10/13/17 09:45, Adrian Chadd wrote: no, it checks it. -a On 13 October 2017 at 00:11, Hans Petter Selasky wrote: On 10/13/17 08:49, Adrian Chadd wrote: if (ieee80211_check_rxseq_amsdu_more(rxs)) { ^^^ does this line also need a NULL check?

svn commit: r324581 - stable/11/contrib/mdocml

Author: bapt Date: Fri Oct 13 07:50:44 2017 New Revision: 324581 URL: https://svnweb.freebsd.org/changeset/base/324581 Log: MFC: r324362 Import mandoc 1.14.3 Modified: stable/11/contrib/mdocml/Makefile stable/11/contrib/mdocml/NEWS stable/11/contrib/mdocml/man_term.c

Re: svn commit: r324580 - head/sys/net80211

no, it checks it. -a On 13 October 2017 at 00:11, Hans Petter Selasky wrote: > On 10/13/17 08:49, Adrian Chadd wrote: >> >> if (ieee80211_check_rxseq_amsdu_more(rxs)) { > > ^^^ does this line also need a NULL check? > > >> ni->ni_rxseqs[tid] = rxseq;

Re: svn commit: r324580 - head/sys/net80211

On 10/13/17 08:49, Adrian Chadd wrote: if (ieee80211_check_rxseq_amsdu_more(rxs)) { ^^^ does this line also need a NULL check? ni->ni_rxseqs[tid] = rxseq; - if (ieee80211_check_rxseq_amsdu(rxs)) + if ((rxs != NULL) &&

svn commit: r324580 - head/sys/net80211

Author: adrian Date: Fri Oct 13 06:49:07 2017 New Revision: 324580 URL: https://svnweb.freebsd.org/changeset/base/324580 Log: [net80211] don't try to follow a NULL rxs pointer down the sink. It's smelly, and we already checked earlier whether we needed to. Modified:

Re: svn commit: r324570 - head/sys/net80211

god damnit. lemme go look at what's going on. thanks for the heads up! -a On 12 October 2017 at 18:53, Cy Schubert wrote: > In message <201710122156.v9cluwh4017...@repo.freebsd.org>, Adrian Chadd > writes: >> Author: adrian >> Date: Thu Oct 12 21:56:58 2017 >> New