Author: cem
Date: Tue Jun 4 00:01:37 2019
New Revision: 348595
URL: https://svnweb.freebsd.org/changeset/base/348595
Log:
virtio_random(4): Fix random(4) integration
random(4) masks unregistered entropy sources. Prior to this revision,
virtio_random(4) did not correctly register a
Author: cem
Date: Mon Jun 3 23:57:29 2019
New Revision: 348594
URL: https://svnweb.freebsd.org/changeset/base/348594
Log:
style.9: Codify tolerance for eliding blank lines
Consensus seems to be that eliding blank lines for functions with no local
variables is acceptable. Codify that
Author: cem
Date: Sat Jun 1 01:22:21 2019
New Revision: 348489
URL: https://svnweb.freebsd.org/changeset/base/348489
Log:
random(4): Fix RANDOM_LOADABLE build
I introduced an obvious compiler error in r346282, so this change fixes
that.
Unfortunately, RANDOM_LOADABLE isn't covered
Author: cem
Date: Tue May 28 20:44:23 2019
New Revision: 348337
URL: https://svnweb.freebsd.org/changeset/base/348337
Log:
style.9: Correct usage's definition to match its declaration
Suggested by: emaste
Reviewed by: delphij, imp, rgrimes, vangyzen (earlier version)
Sponsored by:
Author: cem
Date: Mon May 27 17:33:20 2019
New Revision: 348309
URL: https://svnweb.freebsd.org/changeset/base/348309
Log:
kldxref(8): Sort MDT_MODULE info first in linker.hints output
MDT_MODULE info is required to be ordered before any other MDT metadata for
a given kld because it
Author: cem
Date: Mon May 27 00:55:46 2019
New Revision: 348295
URL: https://svnweb.freebsd.org/changeset/base/348295
Log:
virtio_random(4): Remove unneeded reference to device
The device_t always references the softc, so we can pass the device and
obtain the softc instead of the other
Author: cem
Date: Mon May 27 00:51:27 2019
New Revision: 348294
URL: https://svnweb.freebsd.org/changeset/base/348294
Log:
virtio.4: Add missing devices and Xr
This page could probably use further improvement.
Modified:
head/share/man/man4/virtio.4
Modified:
Author: cem
Date: Mon May 27 00:47:51 2019
New Revision: 348293
URL: https://svnweb.freebsd.org/changeset/base/348293
Log:
aesni(4): Fix trivial type typo
This fixes the kernel build with xtoolchain-gcc (6.4.0).
X-MFC-With: r348268
Modified:
head/sys/crypto/aesni/aesni_ccm.c
Author: cem
Date: Mon May 27 00:43:43 2019
New Revision: 348292
URL: https://svnweb.freebsd.org/changeset/base/348292
Log:
sys/bufobj.h: Avoid using C++ reserved keyword 'private'
No functional change (except for out-of-tree C++ kmods).
Modified:
head/sys/sys/bufobj.h
Modified:
Author: cem
Date: Sat May 25 01:59:24 2019
New Revision: 348262
URL: https://svnweb.freebsd.org/changeset/base/348262
Log:
virtio_pci(4): Fix typo in read_ivar method
Prior to this revision, vtpci's BUS_READ_IVAR method on VIRTIO_IVAR_SUBVENDOR
accidentally returned the PCI subdevice.
Author: cem
Date: Fri May 24 22:33:14 2019
New Revision: 348255
URL: https://svnweb.freebsd.org/changeset/base/348255
Log:
Disable intr_storm_threshold mechanism by default
The ixl.4 manual page has documented that the threshold falsely detects
interrupt storms on 40Gbit NICs as long ago
On Fri, May 24, 2019 at 9:24 AM Andrew Gallatin wrote:
> Dumb question about this: Will it update toolchains, or just use what
> can find?
-DMAKE_JUST_KERNELS doesn't touch toolchains. For that, there is the
less memorable build step:
export NCPU=$((1 * $(sysctl -n hw.ncpu) / 3)); make
Author: cem
Date: Thu May 23 21:02:27 2019
New Revision: 348199
URL: https://svnweb.freebsd.org/changeset/base/348199
Log:
random(4): deduplicate explicit_bzero() in harvest
Pull the responsibility for zeroing events, which is general to any
conceivable implementation of a random device
Author: cem
Date: Thu May 23 20:18:46 2019
New Revision: 348198
URL: https://svnweb.freebsd.org/changeset/base/348198
Log:
uart_cpu_acpi: Fix GCC build break from r348195
extern declarations are redundant with those in uart_cpu.h, which this file
includes.
X-MFC-with: r348195
Author: cem
Date: Thu May 23 20:12:24 2019
New Revision: 348197
URL: https://svnweb.freebsd.org/changeset/base/348197
Log:
EKCD: Add Chacha20 encryption mode
Add Chacha20 mode to Encrypted Kernel Crash Dumps.
Chacha20 does not require messages to be multiples of block size, so it is
Author: cem
Date: Wed May 22 23:22:36 2019
New Revision: 348130
URL: https://svnweb.freebsd.org/changeset/base/348130
Log:
Decode and name additional x86 feature bits
These are all enumerated in Intel's ISA extension reference, 37th ed.
Sponsored by: Dell EMC Isilon
Modified:
Hi Brad,
Ping. It's still broken. Can you revert this please?
Thanks,
Conrad
On Thu, May 16, 2019 at 8:05 AM Conrad Meyer wrote:
>
> Hi Brad,
>
> Can you revert this? It seems to break every config-management tool
> we have (mergemaster, etcupdate, beinstall ...).
>
>
Author: cem
Date: Wed May 22 21:47:17 2019
New Revision: 348122
URL: https://svnweb.freebsd.org/changeset/base/348122
Log:
save-entropy(8), rc.d/random: Set nodump flag
Tag saved entropy files as "nodump," to signal that the files should not be
backed up by dump(8) or other automated
On Wed, May 22, 2019 at 12:59 PM John Baldwin wrote:
> On 5/22/19 12:12 PM, Conrad Meyer wrote:
> > On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote:
> >>
> >> On 22/05/2019 16:44, Andrew Gallatin wrote:
> >>> This is needed for AMD SMCA process
On Wed, May 22, 2019 at 11:06 AM Andriy Gapon wrote:
>
> On 22/05/2019 16:44, Andrew Gallatin wrote:
> > This is needed for AMD SMCA processors, as SMCA uses different
> > MSR address for access MCA banks.
>
> Just curious, what is SMCA?
Scalable MCA. It's a set of AMD Fam17h MCA
Author: cem
Date: Wed May 22 01:22:33 2019
New Revision: 348078
URL: https://svnweb.freebsd.org/changeset/base/348078
Log:
pmc: Fix stack std::string lifetime
It's invalid to reference a C++ string's c_str() buffer after the object
goes out of scope. Adjust the scope of the string to
Author: cem
Date: Wed May 22 00:21:42 2019
New Revision: 348076
URL: https://svnweb.freebsd.org/changeset/base/348076
Log:
Revert r348070
Konstantin points out that lockmgr probably requires the whole lock.h anyway.
Requested by: kib
Modified:
head/sys/sys/lockmgr.h
Modified:
Author: cem
Date: Tue May 21 21:35:37 2019
New Revision: 348070
URL: https://svnweb.freebsd.org/changeset/base/348070
Log:
sys/lockmgr.h: Update #error to point at correct _lock.h
After r347984, these macros live in sys/_lock.h. No functional change.
Sponsored by: Dell EMC Isilon
Author: cem
Date: Tue May 21 21:26:14 2019
New Revision: 348067
URL: https://svnweb.freebsd.org/changeset/base/348067
Log:
mqueuefs: Do not allow manipulation of the pseudo-dirents "." and ".."
"." and ".." names are not maintained in the mqueuefs dirent datastructure and
cannot be
Author: cem
Date: Tue May 21 20:38:48 2019
New Revision: 348064
URL: https://svnweb.freebsd.org/changeset/base/348064
Log:
Include ktr.h in more compilation units
Similar to r348026, exhaustive search for uses of CTRn() and cross reference
ktr.h includes. Where it was obvious that an OS
Author: cem
Date: Tue May 21 01:18:43 2019
New Revision: 348026
URL: https://svnweb.freebsd.org/changeset/base/348026
Log:
Include eventhandler.h in more compilation units
This was enumerated with exhaustive search for sys/eventhandler.h includes,
cross-referenced against EVENTHANDLER_*
the eventhandler header (and fixing
that is trivial), but I'd like to better understand where the leak is
so that other misses can be located.
Thanks,
Conrad
On Mon, May 20, 2019 at 12:31 PM Conrad Meyer wrote:
>
> Hi Peter,
>
> Thanks for reporting this. I ran a full tinderbox on this ch
Author: cem
Date: Tue May 21 00:04:19 2019
New Revision: 348022
URL: https://svnweb.freebsd.org/changeset/base/348022
Log:
Add two missing eventhandler.h headers
These are obviously missing from the .c files, but don't show up in any
tinderbox configuration (due to latent header
On Mon, May 20, 2019 at 12:21 PM Peter Jeremy wrote:
>
> On 2019-May-20 00:38:23 +, Conrad Meyer wrote:
> >Author: cem
> >Date: Mon May 20 00:38:23 2019
> >New Revision: 347984
> >URL: https://svnweb.freebsd.org/changeset/base/347984
> >
> >Log:
&g
Author: cem
Date: Mon May 20 00:38:23 2019
New Revision: 347984
URL: https://svnweb.freebsd.org/changeset/base/347984
Log:
Extract eventfilter declarations to sys/_eventfilter.h
This allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"
in other header files (e.g.,
Author: cem
Date: Sun May 19 06:01:11 2019
New Revision: 347967
URL: https://svnweb.freebsd.org/changeset/base/347967
Log:
nvd.4: Reference nda(4)
Fix a totally minor typo in nvme.4 while here.
Modified:
head/share/man/man4/nvd.4
head/share/man/man4/nvme.4
Modified:
Author: cem
Date: Sat May 18 00:22:28 2019
New Revision: 347948
URL: https://svnweb.freebsd.org/changeset/base/347948
Log:
Add DragonFly's partition number to fdisk(8) and diskmbr.h
This change doesn't make any attempt to add support for these slices to the
relevent GEOM classes. Just
Author: cem
Date: Thu May 16 19:10:48 2019
New Revision: 347888
URL: https://svnweb.freebsd.org/changeset/base/347888
Log:
mips: Implement basic pmap_kenter_device, pmap_kremove_device
Unbreak mips.BERI_DE4_SDROOT build, which uses device xdma. Device xdma
depends on the
Author: cem
Date: Thu May 16 17:34:36 2019
New Revision: 347828
URL: https://svnweb.freebsd.org/changeset/base/347828
Log:
xdma(4): Fix invalid pointer use (breaks arm.SOCFPGA build)
In xdma_handle_mem_node(), vmem_size_t and vmem_addr_t pointers were passed to
an FDT API that emits
Hi Brad,
Can you revert this? It seems to break every config-management tool
we have (mergemaster, etcupdate, beinstall ...).
Additionally, I don't believe this move has been justified — the cons
seem to outweigh the pros, if there are any. I skimmed the
differential and it was not immediately
Author: cem
Date: Thu May 16 01:32:54 2019
New Revision: 347639
URL: https://svnweb.freebsd.org/changeset/base/347639
Log:
x86: Correctly identify bhyve hypervisor
Spotted after a similar report by Olivier Cochard-Labbé.
Sponsored by: Dell EMC Isilon
Modified:
Author: cem
Date: Mon May 13 23:37:44 2019
New Revision: 347555
URL: https://svnweb.freebsd.org/changeset/base/347555
Log:
Revert r346292 (permit_nonrandom_stackcookies)
We have a better, more comprehensive knob for this now:
kern.random.initial_seeding.bypass_before_seeding=1.
Author: cem
Date: Mon May 13 19:35:35 2019
New Revision: 347546
URL: https://svnweb.freebsd.org/changeset/base/347546
Log:
Fortuna: Fix false negatives in is_random_seeded()
(1) We may have had sufficient entropy to consider Fortuna seeded, but the
random_fortuna_seeded() function would
Author: cem
Date: Fri May 10 23:10:22 2019
New Revision: 347471
URL: https://svnweb.freebsd.org/changeset/base/347471
Log:
netdump: Fix boot-time configuration typo
Boot-time netdump configuration is much more useful if one can configure the
client and gateway addresses. Fix trivial
Author: cem
Date: Fri May 10 23:12:59 2019
New Revision: 347473
URL: https://svnweb.freebsd.org/changeset/base/347473
Log:
netdump: Ref the interface we're attached to
Serialize netdump configuration / deconfiguration, and discard our
configuration when the affiliated interface goes away
Author: cem
Date: Fri May 10 21:55:11 2019
New Revision: 347467
URL: https://svnweb.freebsd.org/changeset/base/347467
Log:
netdump: Don't store sensitive key data we don't need
Prior to this revision, struct diocskerneldump_arg (and struct netdump_conf
with embedded diocskerneldump_arg
Author: cem
Date: Wed May 8 14:54:32 2019
New Revision: 347329
URL: https://svnweb.freebsd.org/changeset/base/347329
Log:
random(4): Don't complain noisily when an entropy source is slow
Mjg@ reports that RDSEED (r347239) causes a lot of logspam from this printf,
and I don't feel that
Unfortunately, no real knob for it. I have proposed disabling the warning
in
https://reviews.freebsd.org/D20195 .
Sorry about the noise.
Best,
Conrad
On Wed, May 8, 2019 at 2:08 AM Michael Tuexen wrote:
> > On 8. May 2019, at 02:45, Conrad Meyer wrote:
> >
> > Author: cem
Hi Marius,
This change seems to break LINT-NOIP tinderbox builds; one reference
to tcp_lro_free() is covered by #if defined(INET) || defined(INET6),
but the one added in iflib_rx_structures_free() is not.
On Tue, May 7, 2019 at 1:28 AM Marius Strobl wrote:
>
> Author: marius
> Date: Tue May 7
Hi Tycho,
On Wed, Apr 24, 2019 at 1:31 PM Tycho Nightingale wrote:
>
> Author: tychon
> Date: Wed Apr 24 20:30:45 2019
> New Revision: 346645
> URL: https://svnweb.freebsd.org/changeset/base/346645
>
> Log:
> LinuxKPI should use bus_dma(9) to be compatible with an IOMMU
>
> Reviewed by:
Hi Kirk,
Coverity points out that namlen may be used uninitialized in the
following sequence (CID 1401317):
On Fri, May 3, 2019 at 2:54 PM Kirk McKusick wrote:
>
> Author: mckusick
> Date: Fri May 3 21:54:14 2019
> New Revision: 347066
> URL: https://svnweb.freebsd.org/changeset/base/347066
>
Author: cem
Date: Wed May 8 00:45:16 2019
New Revision: 347239
URL: https://svnweb.freebsd.org/changeset/base/347239
Log:
random: x86 driver: Prefer RDSEED over RDRAND when available
Per
https://software.intel.com/en-us/blogs/2012/11/17/the-difference-between-rdrand-and-rdseed
,
Author: cem
Date: Wed May 8 00:40:08 2019
New Revision: 347238
URL: https://svnweb.freebsd.org/changeset/base/347238
Log:
vmm(4): Pass through RDSEED feature bit to guests
Reviewed by: jhb
Approved by: #bhyve (jhb)
MFC after:2 leapseconds
Sponsored by: Dell EMC Isilon
Author: cem
Date: Tue May 7 21:15:11 2019
New Revision: 347235
URL: https://svnweb.freebsd.org/changeset/base/347235
Log:
Fix libsbuf sbuf_printf_drain symbol version
(Introduced incorrectly in r347229 earlier today.)
As pointed out by kevans, 1.6 should be used for FreeBSD 13, like
One correction
On Tue, May 7, 2019 at 10:47 AM Conrad Meyer wrote:
> Author: cem
> Date: Tue May 7 17:47:20 2019
> New Revision: 347229
> URL: https://svnweb.freebsd.org/changeset/base/347229
>
> Log:
> device_printf: Use sbuf for more coherent prints on SMP
>
>
Author: cem
Date: Tue May 7 17:47:20 2019
New Revision: 347229
URL: https://svnweb.freebsd.org/changeset/base/347229
Log:
device_printf: Use sbuf for more coherent prints on SMP
device_printf does multiple calls to printf allowing other console messages to
be inserted between the device
Author: cem
Date: Mon May 6 18:24:07 2019
New Revision: 347192
URL: https://svnweb.freebsd.org/changeset/base/347192
Log:
List-ify kernel dump device configuration
Allow users to specify multiple dump configurations in a prioritized list.
This enables fallback to secondary device(s) if
Author: cem
Date: Sat May 4 20:34:26 2019
New Revision: 347134
URL: https://svnweb.freebsd.org/changeset/base/347134
Log:
x86: Implement MWAIT support for stopping a CPU
IPI_STOP is used after panic or when ddb is entered manually. MONITOR/
MWAIT allows CPUs that support the feature to
Author: cem
Date: Sat May 4 17:35:13 2019
New Revision: 347129
URL: https://svnweb.freebsd.org/changeset/base/347129
Log:
x86: Define pc_monitorbuf as a logical structure
Rather than just accessing it via pointer cast.
No functional change intended.
Discussed with: kib
Author: cem
Date: Thu May 2 18:10:23 2019
New Revision: 347029
URL: https://svnweb.freebsd.org/changeset/base/347029
Log:
Add a COMPAT_FREEBSD12 kernel option.
Use it wherever COMPAT_FREEBSD11 is currently specified, like r309749.
Reviewed by: imp, jhb, markj
Sponsored by: Dell
Thanks, Glen!
On Tue, Apr 30, 2019 at 7:29 AM Glen Barber wrote:
>
> Author: gjb
> Date: Tue Apr 30 14:29:09 2019
> New Revision: 346959
> URL: https://svnweb.freebsd.org/changeset/base/346959
>
> Log:
> Reduce the default image size for virtual machine disk images from
> 30GB to 3GB. The
Author: cem
Date: Wed Apr 24 18:24:22 2019
New Revision: 346643
URL: https://svnweb.freebsd.org/changeset/base/346643
Log:
x86: Halt non-BSP CPUs on panic IPI_STOP
We may need the BSP to reboot, but we don't need any AP CPU that isn't the
panic thread. Any CPU landing in this routine
Author: cem
Date: Tue Apr 23 17:18:20 2019
New Revision: 346601
URL: https://svnweb.freebsd.org/changeset/base/346601
Log:
ip6_randomflowlabel: Avoid blocking if random(4) is not available
If kern.random.initial_seeding.bypass_before_seeding is disabled, random(4)
and arc4random(9) will
Author: cem
Date: Tue Apr 23 17:05:57 2019
New Revision: 346599
URL: https://svnweb.freebsd.org/changeset/base/346599
Log:
netdump: Fix !COMPAT_FREEBSD11 unused variable warning
Reported by: Ralf Wenk
Sponsored by: Dell EMC Isilon
Modified:
head/sys/netinet/netdump/netdump_client.c
Author: cem
Date: Mon Apr 22 16:29:34 2019
New Revision: 346566
URL: https://svnweb.freebsd.org/changeset/base/346566
Log:
random.3: Remove obsolete BUGS section
Relative performance to rand(3) is sort of irrelevant; they do different
things
and a user with sensitivity to RNG
Author: cem
Date: Mon Apr 22 16:26:39 2019
New Revision: 346565
URL: https://svnweb.freebsd.org/changeset/base/346565
Log:
rand.3: Match better recommendation language from random.3
Sponsored by: Dell EMC Isilon
Modified:
head/lib/libc/stdlib/rand.3
Modified:
Author: cem
Date: Mon Apr 22 03:25:49 2019
New Revision: 346516
URL: https://svnweb.freebsd.org/changeset/base/346516
Log:
gnop(8): Nopify configuration as a kernel dump device
As a dummy / no-op dump device, to facilitate dumpon(8) testing.
Reviewed by: markj (earlier version)
On Sat, Apr 20, 2019 at 9:54 AM John Baldwin wrote:
> To be clear, I prefer the _new_ indentation. I kept having to go back and
> manually
> use tabify in emacs to work with the current scripts, so once my pending
> stuff is
> drained I will appreciate having it converted.
>
+1 as someone else
Author: cem
Date: Sat Apr 20 16:07:29 2019
New Revision: 346448
URL: https://svnweb.freebsd.org/changeset/base/346448
Log:
netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl
The logic was present for the 11 version of the DIOCSKERNELDUMP ioctl, but
had not been updated for the 12 ABI.
Author: cem
Date: Fri Apr 19 22:08:17 2019
New Revision: 346420
URL: https://svnweb.freebsd.org/changeset/base/346420
Log:
Revert r346410 and r346411
libkern in .PATH has too many filename conflicts with libc and my -DNO_CLEAN
tinderbox didn't catch that ahead of time. Mea culpa.
Author: cem
Date: Fri Apr 19 20:08:45 2019
New Revision: 346412
URL: https://svnweb.freebsd.org/changeset/base/346412
Log:
kernel build: Disable unhelpful GCC warning (tripped after r346352)
-Wformat-zero-length does not highlight any particularly wrong code and it
is especially
Author: cem
Date: Fri Apr 19 20:06:22 2019
New Revision: 346411
URL: https://svnweb.freebsd.org/changeset/base/346411
Log:
Bump __FreeBSD_version after r346410
Modified:
head/sys/sys/param.h
Modified: head/sys/sys/param.h
Author: cem
Date: Fri Apr 19 20:05:47 2019
New Revision: 346410
URL: https://svnweb.freebsd.org/changeset/base/346410
Log:
libkern: Bring in arc4random_uniform(9) from libc
It is a useful arc4random wrapper in the kernel for much the same reasons as
in userspace. Move the source to
Author: cem
Date: Fri Apr 19 17:15:58 2019
New Revision: 346399
URL: https://svnweb.freebsd.org/changeset/base/346399
Log:
random.4: Include description of knobs added in r346358
Reported by: ngie
Sponsored by: Dell EMC Isilon
Modified:
head/share/man/man4/random.4
Modified:
Author: cem
Date: Fri Apr 19 02:54:13 2019
New Revision: 346364
URL: https://svnweb.freebsd.org/changeset/base/346364
Log:
Update to Zstandard 1.4.0
The full release notes can be found on Github:
https://github.com/facebook/zstd/releases/tag/v1.4.0
Relnotes: yes
Added:
Author: cem
Date: Fri Apr 19 00:32:13 2019
New Revision: 346362
URL: https://svnweb.freebsd.org/changeset/base/346362
Log:
tag zstd 1.4.0
Added:
vendor/zstd/1.4.0/
- copied from r346360, vendor/zstd/dist/
vendor/zstd/1.4.0/CHANGELOG
- copied unchanged from r346361,
Author: cem
Date: Fri Apr 19 00:31:04 2019
New Revision: 346361
URL: https://svnweb.freebsd.org/changeset/base/346361
Log:
import zstd 1.4.0
Added:
vendor/zstd/dist/CHANGELOG
vendor/zstd/dist/contrib/docker/
vendor/zstd/dist/contrib/docker/Dockerfile
Author: cem
Date: Thu Apr 18 20:48:54 2019
New Revision: 346358
URL: https://svnweb.freebsd.org/changeset/base/346358
Log:
random(4): Restore availability tradeoff prior to r346250
As discussed in that commit message, it is a dangerous default. But the
safe default causes enough pain on
On Mon, Apr 15, 2019 at 11:40 AM Conrad Meyer wrote:
>
> Author: cem
> Date: Mon Apr 15 18:40:36 2019
> New Revision: 346250
> URL: https://svnweb.freebsd.org/changeset/base/346250
>
> Log:
> random(4): Block read_random(9) on initial seeding
Hi,
For anyone intereste
:22 AM Adrian Chadd wrote:
>
>
>
> On Mon, 15 Apr 2019 at 11:40, Conrad Meyer wrote:
>>
>> Author: cem
>> Date: Mon Apr 15 18:40:36 2019
>> New Revision: 346250
>> URL: https://svnweb.freebsd.org/changeset/base/346250
>>
>> Log:
>> rand
Hi John,
On Wed, Apr 17, 2019 at 9:01 AM John Baldwin wrote:
> You're missing the point which is that you've added potential blocking in a
> lot of
> places by changing the semantics of arc4random.
I get it. The thing is, it's a weird blocking semantic. It's not the
same as any other
Hi Warner,
On Wed, Apr 17, 2019 at 10:16 AM Warner Losh wrote:
> I'm going to put a very fine point on this: any hard-requirement of entropy
> sources is a non-starter. If you require that, your commit will be backed out
> and/or hacked around by the addition of a nob in the future. It will
On Wed, Apr 17, 2019 at 9:06 AM John Baldwin wrote:
>
> On 4/16/19 4:48 PM, Conrad Meyer wrote:
> > Perhaps cryptographically random stack-protector cookies are simply
> > inappropriate for MIPS or RISCV. Do we have any other examples of
> > kernel random consumers block
On Tue, Apr 16, 2019 at 4:31 PM John Baldwin wrote:
> bhyveload is effectively the loader in this case. It runs the normal loader
> scripts and logic and so would load the guests's /boot/entropy and pass it
> to the guest kernel as metadata just like the regular loader.
Right, except it doesn't
On Tue, Apr 16, 2019 at 4:28 PM John Baldwin wrote:
> Yes, but we need some kind of non-blocking API, not an
> unconditionally-blocking API
> that deadlocks.
I'm not sure we do. It would be sufficient to check once at subsystem
initialization time. There's no race condition such that we block
On Tue, Apr 16, 2019 at 2:32 PM John Baldwin wrote:
> There are definitely places arc4random is used where sleeping is not allowed.
Sure.
> ipsec generating nonces for AES-CBC is one example I can think of off the
> top of my head.
IVs for AES-CBC are also a great example of a case we should
Author: cem
Date: Tue Apr 16 18:47:20 2019
New Revision: 346292
URL: https://svnweb.freebsd.org/changeset/base/346292
Log:
stack_protector: Add tunable to bypass random cookies
This is a stopgap measure to unbreak installer/VM/embedded boot issues
introduced (or at least exposed by) in
Author: cem
Date: Tue Apr 16 17:12:17 2019
New Revision: 346282
URL: https://svnweb.freebsd.org/changeset/base/346282
Log:
random(4): Add is_random_seeded(9) KPI
The imagined use is for early boot consumers of random to be able to make
decisions based on whether random is available yet
On Tue, Apr 16, 2019 at 9:33 AM Warner Losh wrote:
> In that case, we're better off having a MD routine that gets called if
> there's no loader-provided entropy pool.
Yes, this is more or less the same plan I had. There's no need to add
anything MD specific; we already abstract MD random
Hi Warner,
On Tue, Apr 16, 2019 at 8:47 AM Warner Losh wrote:
> On Tue, Apr 16, 2019 at 9:16 AM Ian Lepore wrote:
>> Isn't a file full of data which is distributed in identical form to
>> everyone the exact opposite of entropy?
Ian has the right idea.
> It's just to bootstrap entropy for
Hi Ruslan,
On Tue, Apr 16, 2019 at 8:38 AM Ruslan Bukin wrote:
>
> Hi I just got this:
>
> ...
> _sleep() at random_harvest_deregister_source+0x132
> random_harvest_deregister_source() at read_random+0xc4
> read_random() at vn_fsync_buf+0x594
> vn_fsync_buf() at arc4rand+0xd4
> arc4rand() at
On Tue, Apr 16, 2019 at 6:20 AM Shawn Webb wrote:
> Is there any documentation anywhere telling users that Capsicum
> support will be disabled under certain circumstances?
Hi Shawn,
I don't think documenting that makes much sense in general. It would
be extremely burdensome to fully document
Hi Marcin,
Isn't this check racy? Thread TIDs are allocated from a fixed range
and can be recycled.
Best,
Conrad
On Mon, Apr 15, 2019 at 7:28 PM Marcin Wojtas wrote:
>
> Author: mw
> Date: Tue Apr 16 02:28:35 2019
> New Revision: 346259
> URL: https://svnweb.freebsd.org/changeset/base/346259
On Tue, Apr 16, 2019 at 7:24 AM Justin Hibbits wrote:
>
> Hi Conrad,
> ...
> [Power] does use bsdinstall to install. How is entropy loaded at startup,
> which causes the problem noted in github?
There are a couple very early load sources. loader(8) will load
early-boot entropy from
On Tue, Apr 16, 2019 at 6:19 AM Warner Losh wrote:
> On Tue, Apr 16, 2019, 7:04 AM Emmanuel Vadot wrote:
>> It's not only CI, all release images (memstick, iso) don't have
>> a /boot/entropy.
>> Also all arm/arm64 image don't have this file too.
>> If /boot/entropy is needed and isn't present
On Mon, Apr 15, 2019 at 5:53 PM Conrad Meyer wrote:
> E.g., the CI infrastructure for
> Riscv/Arm is/was generating minimal filesystem images and not
> populating /boot/entropy.
I should add, I say "is/was" because I have a PR out which may address
the problem: https://github.
Hi Justin,
On Mon, Apr 15, 2019 at 5:01 PM Justin Hibbits wrote:
> Given the discussion over there it would probably also fail on powernv, which
> also does not use loader.
Does power use bsdinstall (which populates /boot/entropy at install
time via usr.sbin/bsdinstall/scripts/entropy) and
Author: cem
Date: Mon Apr 15 18:49:04 2019
New Revision: 346251
URL: https://svnweb.freebsd.org/changeset/base/346251
Log:
random.3: Clarify confusing summary
random.3 is only "better" in contrast to rand.3. Both are non-cryptographic
pseudo-random number generators. The opening blurbs
Author: cem
Date: Mon Apr 15 18:40:36 2019
New Revision: 346250
URL: https://svnweb.freebsd.org/changeset/base/346250
Log:
random(4): Block read_random(9) on initial seeding
read_random() is/was used, mostly without error checking, in a lot of
very sensitive places in the kernel --
Author: cem
Date: Sat Apr 13 16:51:48 2019
New Revision: 346187
URL: https://svnweb.freebsd.org/changeset/base/346187
Log:
hexdump(1): Exit gracefully on format strings missing conversion
PR: 237263
Submitted by: Bojan Petrovic
Modified:
head/usr.bin/hexdump/hexdump.h
Author: cem
Date: Sat Apr 13 04:42:17 2019
New Revision: 346175
URL: https://svnweb.freebsd.org/changeset/base/346175
Log:
sort(1): Memoize MD5 computation to reduce repeated computation
Experimentally, reduces sort -R time of a 148160 line corpus from about
3.15s to about 0.93s on this
Hi Edward,
I have a question about this change below.
On Thu, Apr 11, 2019 at 4:22 AM Edward Tomasz Napierala
wrote:
>
> Author: trasz
> Date: Thu Apr 11 11:21:45 2019
> New Revision: 346120
> URL: https://svnweb.freebsd.org/changeset/base/346120
>
> Log:
> Use shared vnode locks for the ELF
Author: cem
Date: Thu Apr 11 05:08:49 2019
New Revision: 346116
URL: https://svnweb.freebsd.org/changeset/base/346116
Log:
sort(1): Simplify and bound random seeding
Bound input file processing length to avoid the issue reported in [1]. For
simplicity, only allow regular file and
Author: cem
Date: Thu Apr 11 00:39:06 2019
New Revision: 346110
URL: https://svnweb.freebsd.org/changeset/base/346110
Log:
sort(1): Whitespace and style cleanup
No functional change.
Sponsored by: Dell EMC Isilon
Modified:
head/usr.bin/sort/sort.c
Modified:
Author: cem
Date: Sat Apr 6 21:56:24 2019
New Revision: 345993
URL: https://svnweb.freebsd.org/changeset/base/345993
Log:
kern/subr_pctrie: Fix mismatched signedness in assertion comparison
'tos' is an index into an array and never holds a negative value. Correct
its signedness to
501 - 600 of 1506 matches
Mail list logo