Re: svn commit: r272372 - stable/10/bin/rm

2014-10-03 Thread Bruce Evans
On Sat, 4 Oct 2014, Bruce Evans wrote: On Fri, 3 Oct 2014, Garrett Cooper wrote: ? as filtering out these errors would handle the case that -f should handle according to the manpage: -f Attempt to remove the files without prompting for confirmation, regardless of the fil

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-03 Thread Bruce Evans
On Fri, 3 Oct 2014, Garrett Cooper wrote: On Oct 2, 2014, at 16:34, Bruce Evans wrote: There is still the larger problem with fts_read(). Applications like rm are specified to do a complete tree walk, with special handling for files that do not exist. If fts_read() is going to abort in the

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-03 Thread Ian Lepore
On Wed, 2014-10-01 at 23:25 -0700, NGie Cooper wrote: > On Wed, Oct 1, 2014 at 11:16 PM, Glen Barber wrote: > > On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: > >> On Wed, 1 Oct 2014, Glen Barber wrote: > >> > >> >Log: > >> > MFC r268376 (imp): > >> > > >> > rm -rf can fail sometim

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-03 Thread Garrett Cooper
On Oct 2, 2014, at 16:34, Bruce Evans wrote: > There is still the larger problem with fts_read(). Applications like rm > are specified to do a complete tree walk, with special handling for files > that do not exist. If fts_read() is going to abort in the middle of a > tree walk, then it is unus

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-02 Thread Bruce Evans
On Thu, 2 Oct 2014, John Baldwin wrote: On Thursday, October 02, 2014 2:16:28 am Glen Barber wrote: On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: On Wed, 1 Oct 2014, Glen Barber wrote: Log: MFC r268376 (imp): rm -rf can fail sometimes with an error from fts_read. Make it

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-02 Thread John Baldwin
On Thursday, October 02, 2014 2:16:28 am Glen Barber wrote: > On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: > > On Wed, 1 Oct 2014, Glen Barber wrote: > > > > >Log: > > > MFC r268376 (imp): > > > > > > rm -rf can fail sometimes with an error from fts_read. Make it > > > honor ff

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-01 Thread NGie Cooper
On Wed, Oct 1, 2014 at 11:16 PM, Glen Barber wrote: > On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: >> On Wed, 1 Oct 2014, Glen Barber wrote: >> >> >Log: >> > MFC r268376 (imp): >> > >> > rm -rf can fail sometimes with an error from fts_read. Make it >> > honor fflag to ignore f

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-01 Thread Glen Barber
On Thu, Oct 02, 2014 at 02:56:05PM +1000, Bruce Evans wrote: > On Wed, 1 Oct 2014, Glen Barber wrote: > > >Log: > > MFC r268376 (imp): > > > > rm -rf can fail sometimes with an error from fts_read. Make it > > honor fflag to ignore fts_read errors, but stop deleting from > > that directory b

Re: svn commit: r272372 - stable/10/bin/rm

2014-10-01 Thread Bruce Evans
On Wed, 1 Oct 2014, Glen Barber wrote: Log: MFC r268376 (imp): rm -rf can fail sometimes with an error from fts_read. Make it honor fflag to ignore fts_read errors, but stop deleting from that directory because no further progress can be made. I asked for this to be backed out in -c

svn commit: r272372 - stable/10/bin/rm

2014-10-01 Thread Glen Barber
Author: gjb Date: Wed Oct 1 16:18:40 2014 New Revision: 272372 URL: https://svnweb.freebsd.org/changeset/base/272372 Log: MFC r268376 (imp): rm -rf can fail sometimes with an error from fts_read. Make it honor fflag to ignore fts_read errors, but stop deleting from that directory