Re: svn commit: r347477 - head/sys/kern

2019-05-10 Thread Doug Moore
With mentor approval, I commit r347469.  I start getting email about jenkins failure to build for several architectures on account of the _Generic() construct I introduced in that change. I whip up a patch to undo that part of r347469, and ask for mentor approval.  Meanwhile, mentor authorizes me

Re: svn commit: r347477 - head/sys/kern

2019-05-10 Thread Cy Schubert
In message <201905110213.x4b2dq9u088...@repo.freebsd.org>, Doug Moore writes: > Author: dougm > Date: Sat May 11 02:13:52 2019 > New Revision: 347477 > URL: https://svnweb.freebsd.org/changeset/base/347477 > > Log: > Revert r347469. Why? > > Approved by: kib (mentor) > > Modified: >

svn commit: r347483 - head/sys/net

2019-05-10 Thread Kyle Evans
Author: kevans Date: Sat May 11 04:18:06 2019 New Revision: 347483 URL: https://svnweb.freebsd.org/changeset/base/347483 Log: tuntap: Improve style No functional change. tun_flags of the tuntap_driver was renamed to ident_flags to reflect the fact that it's a subset of the tun_flags

svn commit: r347477 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Sat May 11 02:13:52 2019 New Revision: 347477 URL: https://svnweb.freebsd.org/changeset/base/347477 Log: Revert r347469. Approved by: kib (mentor) Modified: head/sys/kern/subr_blist.c Modified: head/sys/kern/subr_blist.c

svn commit: r347476 - head/usr.sbin/mountd

2019-05-10 Thread Rick Macklem
Author: rmacklem Date: Fri May 10 23:52:17 2019 New Revision: 347476 URL: https://svnweb.freebsd.org/changeset/base/347476 Log: Factor out some exportlist list operations into separate functions. This patch moves the code that removes and frees all exportlist elements out into a separate

svn commit: r347473 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:12:59 2019 New Revision: 347473 URL: https://svnweb.freebsd.org/changeset/base/347473 Log: netdump: Ref the interface we're attached to Serialize netdump configuration / deconfiguration, and discard our configuration when the affiliated interface goes away

svn commit: r347472 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 23:12:37 2019 New Revision: 347472 URL: https://svnweb.freebsd.org/changeset/base/347472 Log: Don't use _Generic, as many systems don't know about it. Go back to a lo-tech switch statement. Approved by: kib (mentor) Differential Revision:

svn commit: r347471 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 23:10:22 2019 New Revision: 347471 URL: https://svnweb.freebsd.org/changeset/base/347471 Log: netdump: Fix boot-time configuration typo Boot-time netdump configuration is much more useful if one can configure the client and gateway addresses. Fix trivial

svn commit: r347470 - in head/sys/compat/linuxkpi/common: include/linux src

2019-05-10 Thread Johannes Lundberg
Author: johalun Date: Fri May 10 23:10:22 2019 New Revision: 347470 URL: https://svnweb.freebsd.org/changeset/base/347470 Log: Implement linux_pci_unregister_drm_driver in linuxkpi so that drm drivers can be unloaded. This patch is a part of D19565. Reviewed by: hps Approved by:

svn commit: r347469 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 22:49:01 2019 New Revision: 347469 URL: https://svnweb.freebsd.org/changeset/base/347469 Log: When bitpos can't be implemented with an inline ffs* instruction, change the binary search so that it does not depend on a single bit only being set in the bitmask.

svn commit: r347468 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 22:02:29 2019 New Revision: 347468 URL: https://svnweb.freebsd.org/changeset/base/347468 Log: Add a (q)uit option to the subr_blist test program. Approved by: kib (mentor) Differential Revision: https://reviews.freebsd.org/D20234 Modified:

svn commit: r347467 - head/sys/netinet/netdump

2019-05-10 Thread Conrad Meyer
Author: cem Date: Fri May 10 21:55:11 2019 New Revision: 347467 URL: https://svnweb.freebsd.org/changeset/base/347467 Log: netdump: Don't store sensitive key data we don't need Prior to this revision, struct diocskerneldump_arg (and struct netdump_conf with embedded diocskerneldump_arg

svn commit: r347466 - head/sys/netinet

2019-05-10 Thread Gleb Smirnoff
Author: glebius Date: Fri May 10 21:51:17 2019 New Revision: 347466 URL: https://svnweb.freebsd.org/changeset/base/347466 Log: Fix regression from r347375: do not panic when sending an IP multicast packet from an interface that doesn't have IPv4 address. Reported by: Michael Butler

svn commit: r347465 - head/sys/netinet6

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 20:15:40 2019 New Revision: 347465 URL: https://svnweb.freebsd.org/changeset/base/347465 Log: Apply r280991 to ip6_fragment. This uses m_dup_pkthdr() to copy all of the metadata about a packet to each of its fragments including VLAN tags, mbuf tags, etc.

svn commit: r347464 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 19:55:29 2019 New Revision: 347464 URL: https://svnweb.freebsd.org/changeset/base/347464 Log: Replace the expression "-mask & ~mask" with a function call that does the same thing, but is commented so that it might be better understood. Approved by: kib

svn commit: r347463 - head/sys/powerpc/aim

2019-05-10 Thread Justin Hibbits
Author: jhibbits Date: Fri May 10 19:36:14 2019 New Revision: 347463 URL: https://svnweb.freebsd.org/changeset/base/347463 Log: powerpc: Initialize the Hardware Interrupt Offset Register (HIOR) earlier for ppc970 Since we now have a much larger KVA on powerpc64, it's possible to get SLB

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Slawa Olhovchenkov
On Fri, May 10, 2019 at 11:31:21AM -0400, Andrew Gallatin wrote: > On 2019-05-10 08:44, Slawa Olhovchenkov wrote: > > > pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT > > (netpfil/pf/if_pfsync.c). > > > > Thanks for pointing this out. It seems like IPSEC_SUPPORT would work >

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Alexey Dokuchaev
On Fri, May 10, 2019 at 09:44:58PM +0300, Andrey V. Elsukov wrote: > On 10.05.2019 21:39, Alexey Dokuchaev wrote: > >> The second cause -- reduce overhead that IPSEC produces even when it > >> is not used. > > > > So does it mean that if I don't plan to use IPSEC, I can safely remove > >

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Alexey Dokuchaev
On Fri, May 10, 2019 at 12:11:47PM +0300, Andrey V. Elsukov wrote: > On 10.05.2019 11:46, Alexey Dokuchaev wrote: > > ... > > What is the reason behind having IPSEC_SUPPORT option instead of no > > special option at all? > > IPSEC_SUPPORT builds into the kernel PF_KEY domain protocol, that is >

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Andrey V. Elsukov
On 10.05.2019 21:39, Alexey Dokuchaev wrote: >> The second cause -- reduce overhead that IPSEC produces even when it >> is not used. > > So does it mean that if I don't plan to use IPSEC, I can safely remove > IPSEC_SUPPORT from my config and also get slight performance boost? Yes, currently

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Andrey V. Elsukov
On 10.05.2019 18:31, Andrew Gallatin wrote: > On 2019-05-10 08:44, Slawa Olhovchenkov wrote: > >> pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT >> (netpfil/pf/if_pfsync.c). >> > > Thanks for pointing this out.  It seems like IPSEC_SUPPORT would work > for this.  I've made a

svn commit: r347462 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 18:25:06 2019 New Revision: 347462 URL: https://svnweb.freebsd.org/changeset/base/347462 Log: blist_next_leaf_alloc walks over all the meta-nodes between one leaf and the next one, and if blocks are allocated from the next leaf, it walks back toward where it

svn commit: r347461 - head/sys/kern

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 18:22:40 2019 New Revision: 347461 URL: https://svnweb.freebsd.org/changeset/base/347461 Log: Replace panic() with KASSERT() and provide more useful information when failure happens. Approved by: kib (mentor) Differential Revision:

Re: svn commit: r347402 - head/sys/modules/ipsec

2019-05-10 Thread Kyle Evans
On Fri, May 10, 2019 at 2:46 AM Andrey V. Elsukov wrote: > > On 09.05.2019 22:13, Kyle Evans wrote: > >> there is two IPsec related interfaces that have problem with automatic > >> loading - if_enc and if_ipsec. So, if you add both to the mapping list, > >> this will be useful. CAM enc driver has

svn commit: r347458 - head/sys/conf

2019-05-10 Thread Bryan Drewery
Author: bdrewery Date: Fri May 10 18:09:27 2019 New Revision: 347458 URL: https://svnweb.freebsd.org/changeset/base/347458 Log: Fix build race with machine links and genoffset.o. Generate the ilinks for all dependency objects not just the ones in the CLEAN list. Possibly related to

svn commit: r347445 - head/usr.bin/dtc

2019-05-10 Thread Leandro Lupori
Author: luporl Date: Fri May 10 17:05:40 2019 New Revision: 347445 URL: https://svnweb.freebsd.org/changeset/base/347445 Log: Fix build issue with clang 8.0.1 The algorithm header is needed to use std::remove_if Modified: head/usr.bin/dtc/fdt.hh Modified: head/usr.bin/dtc/fdt.hh

svn commit: r347442 - head/sys/arm64/rockchip/clk

2019-05-10 Thread Emmanuel Vadot
Author: manu Date: Fri May 10 16:45:17 2019 New Revision: 347442 URL: https://svnweb.freebsd.org/changeset/base/347442 Log: arm64: rockchip: Don't always put PLL to normal mode We used to put every PLL in normal mode (meaning that the output would be the result of the PLL configuration)

svn commit: r347441 - head/usr.sbin/efibootmgr

2019-05-10 Thread Emmanuel Vadot
Author: manu Date: Fri May 10 16:44:35 2019 New Revision: 347441 URL: https://svnweb.freebsd.org/changeset/base/347441 Log: efibootmgr: Do not add the new boot entry in dry-run is specified While here fix a typo. Sponsored-by: Ampere Computing, LLC Reviewed by: imp Differential

svn commit: r347440 - head/sys/dev/ahci

2019-05-10 Thread Emmanuel Vadot
Author: manu Date: Fri May 10 16:43:53 2019 New Revision: 347440 URL: https://svnweb.freebsd.org/changeset/base/347440 Log: ahci: Check if bus is cache-coherent We do this for FDT systems but not for ACPI ones. Check the presence of the _CCA attribute. Sponsored by: Ampere

svn commit: r347439 - head/lib/libnetgraph

2019-05-10 Thread Mark Johnston
Author: markj Date: Fri May 10 16:43:47 2019 New Revision: 347439 URL: https://svnweb.freebsd.org/changeset/base/347439 Log: Atomically update the global gMsgId in libnetgraph. Otherwise concurrently running threads may inadvertently use the same token for different messages.

svn commit: r347433 - head/sys/sys

2019-05-10 Thread Doug Moore
Author: dougm Date: Fri May 10 16:01:25 2019 New Revision: 347433 URL: https://svnweb.freebsd.org/changeset/base/347433 Log: A major change to subr_blist.c failed to update all the comments about changes to struct fields. Update those now. Approved by: markj (mentor) Differential

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Kristof Provost
On 10 May 2019, at 8:31, Andrew Gallatin wrote: On 2019-05-10 08:44, Slawa Olhovchenkov wrote: pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT (netpfil/pf/if_pfsync.c). Thanks for pointing this out. It seems like IPSEC_SUPPORT would work for this. I've made a patch, and it

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Andrew Gallatin
On 2019-05-10 08:44, Slawa Olhovchenkov wrote: pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT (netpfil/pf/if_pfsync.c). Thanks for pointing this out. It seems like IPSEC_SUPPORT would work for this. I've made a patch, and it compiles and the pf module loads. However, I

svn commit: r347430 - in head/sys: kern netinet sys

2019-05-10 Thread Andrew Gallatin
Author: gallatin Date: Fri May 10 13:41:19 2019 New Revision: 347430 URL: https://svnweb.freebsd.org/changeset/base/347430 Log: Bind TCP HPTS (pacer) threads to NUMA domains Bind the TCP pacer threads to NUMA domains and build per-domain pacer-thread lookup tables. These tables allow us

svn commit: r347429 - head/sbin/ifconfig

2019-05-10 Thread Kyle Evans
Author: kevans Date: Fri May 10 13:18:22 2019 New Revision: 347429 URL: https://svnweb.freebsd.org/changeset/base/347429 Log: ifconfig(8): Add kld mappings for ipsec/enc Additionally, providing mappings makes the comparison for already loaded modules a little more strict. This should

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Slawa Olhovchenkov
On Thu, May 09, 2019 at 10:38:15PM +, Andrew Gallatin wrote: > Author: gallatin > Date: Thu May 9 22:38:15 2019 > New Revision: 347410 > URL: https://svnweb.freebsd.org/changeset/base/347410 > > Log: > Remove IPSEC from GENERIC due to performance issues > > Having IPSEC compiled into

svn commit: r347427 - head/sys/riscv/riscv

2019-05-10 Thread Ruslan Bukin
Author: br Date: Fri May 10 11:21:57 2019 New Revision: 347427 URL: https://svnweb.freebsd.org/changeset/base/347427 Log: RISC-V ISA does not specify how to manage physical memory attributes (PMA). So do nothing in pmap_page_set_memattr() and don't panic. Reviewed by: markj Sponsored

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Andrey V. Elsukov
On 10.05.2019 11:46, Alexey Dokuchaev wrote: > On Thu, May 09, 2019 at 10:38:15PM +, Andrew Gallatin wrote: >> Author: gallatin >> Date: Thu May 9 22:38:15 2019 >> New Revision: 347410 >> URL: https://svnweb.freebsd.org/changeset/base/347410 >> >> Log: >> Remove IPSEC from GENERIC due to

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Alexey Dokuchaev
On Thu, May 09, 2019 at 10:38:15PM +, Andrew Gallatin wrote: > Author: gallatin > Date: Thu May 9 22:38:15 2019 > New Revision: 347410 > URL: https://svnweb.freebsd.org/changeset/base/347410 > > Log: > Remove IPSEC from GENERIC due to performance issues > > @@ -30,7 +30,6 @@ options

svn commit: r347426 - head/tests/sys/sys

2019-05-10 Thread Edward Tomasz Napierala
Author: trasz Date: Fri May 10 08:16:29 2019 New Revision: 347426 URL: https://svnweb.freebsd.org/changeset/base/347426 Log: Try to unbreak the build after r347425. MFC after:2 weeks Modified: head/tests/sys/sys/rb_test.c head/tests/sys/sys/splay_test.c Modified:

svn commit: r347425 - head/tests/sys/sys

2019-05-10 Thread Edward Tomasz Napierala
Author: trasz Date: Fri May 10 07:46:14 2019 New Revision: 347425 URL: https://svnweb.freebsd.org/changeset/base/347425 Log: Add simple regression tests for tree(3). Those are ATF-ified versions of OpenBSD's regress/sys/sys/tree/. Reviewed by: ngie MFC after:2 weeks Sponsored

Re: svn commit: r347402 - head/sys/modules/ipsec

2019-05-10 Thread Andrey V. Elsukov
On 09.05.2019 22:13, Kyle Evans wrote: >> there is two IPsec related interfaces that have problem with automatic >> loading - if_enc and if_ipsec. So, if you add both to the mapping list, >> this will be useful. CAM enc driver has conflicting name and prevents to >> automatic loading of if_enc(4).