Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
, they are used (for better or for worse) in a multi-site database synchronization protocol that currently works portably across operating systems. Removing them would change the semantics of that protocol in a subtle way that might introduce breakage. -Ben Kaduk

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
On Wed, Nov 14, 2012 at 11:27 AM, Eitan Adler ead...@freebsd.org wrote: On 14 November 2012 11:12, Ben Kaduk minimar...@gmail.com wrote: Andre, they are used (for better or for worse) in a multi-site database synchronization protocol that currently works portably across operating systems

Re: svn commit: r242934 - head/sys/dev/xen/netback

2012-11-12 Thread Ben Kaduk
the assertion failed. Note the implied parameters buffer and + * Writes an error message to buffer if cond is false + * Note the implied parameters buffer and At risk of being Bruce, aren't comments like this supposed to be complete sentences and end with a full stop? -Ben Kaduk

Re: svn commit: r241933 - head/sys/conf

2012-11-12 Thread Ben Kaduk
On Mon, Nov 12, 2012 at 7:47 PM, David O'Brien obr...@freebsd.org wrote: On Mon, Nov 12, 2012 at 04:29:07PM -0800, David O'Brien (@FreeBSD) wrote: $ diff -Bbw files.mips.r241680,sorted files.mips.r241933,sorted | egrep -v '^(\+|-|@@)' | wc -l 43 Sorry, should have better ensured all

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
the definition of MPSAFE causes out-of-tree filesystem modules to not build. Perhaps a definition can remain for some period to allow a smoother transition? Conditional on __FreeBSD_Version is the proper fix, of course, but takes longer to get everywhere. -Ben Kaduk % -#define GIANTHELD 0x0200

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
On Tue, Nov 6, 2012 at 5:53 PM, Attilio Rao atti...@freebsd.org wrote: On Tue, Nov 6, 2012 at 10:50 PM, Ben Kaduk minimar...@gmail.com wrote: On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov k...@freebsd.org wrote: Hi Ben, no, ports/thirdy part should be adjusted on the -CURRENT ABI

Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opens

2012-11-06 Thread Ben Kaduk
I do not wish to belabor the point; we all have better things to do with our time. Hopefully this is my last message on the topic. On Tue, Nov 6, 2012 at 6:10 PM, Attilio Rao atti...@freebsd.org wrote: The point is that KPI/KBI of -CURRENT can change as long as __FreeBSD_version is bumped

Re: svn commit: r238962 - head/sys/dev/ath/ath_rate/sample

2012-07-31 Thread Ben Kaduk
On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd adr...@freebsd.org wrote: --- head/sys/dev/ath/ath_rate/sample/sample.c Tue Jul 31 23:54:15 2012 (r238961) +++ head/sys/dev/ath/ath_rate/sample/sample.c Wed Aug 1 00:18:02 2012 (r238962) @@ -504,7 +504,7 @@

Re: svn commit: r232496 - head/share/man/man4

2012-03-04 Thread Ben Kaduk
On Sun, Mar 4, 2012 at 2:32 PM, Eitan Adler ead...@freebsd.org wrote: On Sun, Mar 4, 2012 at 1:52 PM, John Baldwin j...@freebsd.org wrote: Can you do a forced commit to add a commit log of the actual change please? I don't know of any real way to do forced commits so does the following look

Re: svn commit: r232473 - in head: share/mk sys/conf

2012-03-03 Thread Ben Kaduk
On Sat, Mar 3, 2012 at 3:03 PM, Doug Barton do...@freebsd.org wrote: On 03/03/2012 10:58, Dimitry Andric wrote: However, since it is apparently an expected use case to build using old   .mk files, Expected how? It shouldn't happen if you're building in /usr/src. Wouldn't it be better to

Re: svn commit: r232238 - in head: share/man/man4 sys/dev/e1000 sys/dev/ixgbe sys/dev/netmap sys/dev/re sys/net tools/tools/netmap

2012-02-27 Thread Ben Kaduk
    at it add a version field and some spares to the ioctl() argument     to help detect mismatches. Is it worth bumping __FreeBSD_version? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head

Re: svn commit: r230207 - in head/sys: netinet sys

2012-01-19 Thread Ben Kaduk
compatibility. But if you go and remove those too, I am screwed. Please don't just assume that no one is using classful addressing and remove things ahead of a reasonable deprecation schedule. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2012-01-01 Thread Ben Kaduk
On Sun, Jan 1, 2012 at 12:33 PM, Ulrich Spoerlein u...@freebsd.org wrote: On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote: On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein u...@freebsd.org wrote: Modified: head/usr.sbin/cron/doc/CHANGES

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2012-01-01 Thread Ben Kaduk
On Fri, Dec 30, 2011 at 3:04 PM, Glen Barber g...@freebsd.org wrote: On Fri, Dec 30, 2011 at 07:54:44PM +, Alexey Dokuchaev wrote: On Fri, Dec 30, 2011 at 02:43:22PM -0500, Ben Kaduk wrote: On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein u...@freebsd.org wrote

Re: svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnm

2011-12-30 Thread Ben Kaduk
. *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** Hmm, that's unfortunate. Pulling out a svn client, it looks like: usr.sbin/pkg_install/lib/plist.c changes a misspelled form to the still-misspelled occurrance (not occurrence) Thanks for doing this cleanup along with the encoding cleanup! -Ben Kaduk

Re: svn commit: r228992 - in head/usr.bin: csup finger fstat indent ipcs lex limits locate/locate login mail make man ncplogin netstat pr rpcgen rpcinfo systat talk tip/tip top vgrind xlint/lint1 xlin

2011-12-30 Thread Ben Kaduk
. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r228571 - in head: . lib/libc/net sbin/ifconfig share/man/man4 sys/net sys/netinet sys/netinet6 sys/sys

2011-12-16 Thread Ben Kaduk
commented out should just be removed entirely? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r227797 - head/share/mk

2011-11-22 Thread Ben Kaduk
2011/11/22 Rui Paulo rpa...@freebsd.org: On 2011/11/22, at 21:33, Dag-Erling Smørgrav wrote: Rui Paulo rpa...@freebsd.org writes: With this change, I can no longer update a FreeBSD 9.0-current system from June 2010 to FreeBSD 10.0. I suspect I'm not the only one. Sorry, my mind reader is

Re: svn commit: r227778 - head/sys/net

2011-11-20 Thread Ben Kaduk
to use that ABI, something that we just ran into with vm_page_t and friends and had a long thread on -current about. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail

Re: svn commit: r226635 - head/usr.bin/tar

2011-10-22 Thread Ben Kaduk
libarchive.googlecode.com. MFC after: 3 days Thanks! (Your earlier mail was unclear whether you would actually get to it, so I had been planning to take a look, but hadn't had time, yet.) -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org

Re: svn commit: r224475 - head/usr.sbin/jail

2011-07-28 Thread Ben Kaduk
, which would close off this class of attack. I don't have a good sense of whether suid applications are frequently useful/needed inside a jail, though. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src

Re: svn commit: r223722 - in head/sys: kern sys

2011-07-02 Thread Ben Kaduk
to add ioctls to the *.init and  *.lock devices. This commit breaks the ttydevsw ABI, since this Aren't __FreeBSD_version bumps cheap, these days? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src

Re: svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Ben Kaduk
- * to make it a function. + * to make it a function.  Spress warning when card gone. ^^^u -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail

Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes cont

2011-06-18 Thread Ben Kaduk
be in dt_popc(), here. -Ben Kaduk  #endif  } ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r219573 - head/sbin/geom/class/part

2011-03-12 Thread Ben Kaduk
it makes impossible any types of actions +with such partitions. Judging by, e.g. r216755 of g_part_ebr.c, it seems that the sense of impossible is reversed. I think It also allows such partitions to be modified might be what is intended? -Ben Kaduk +The  .Dv GEOM_PART_GPT  option adds support

Re: svn commit: r217097 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include sun4v/include

2011-01-07 Thread Ben Kaduk
       AT_COUNT        22      /* Count of defined aux entry types. */ +#define        AT_COUNT        24      /* Count of defined aux entry types. */ Is there a reason to skip 22? -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http

Re: svn commit: r216591 - head

2010-12-20 Thread Ben Kaduk
there is something of a tradeoff. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org

Re: svn commit: r215176 - in head: . share/man/man9

2010-11-12 Thread Ben Kaduk
(by jeff): Don't make vgonel() globally visible.  While here, specify the vnode locking scheme for vgone(). Thanks! (I was going to send a follow-up to -hackers in a few days, otherwise.) -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http

Re: svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys

2010-11-12 Thread Ben Kaduk
, but I haven't yet checked. That said, I hear __FreeBSD_version bumps are cheap. -Ben Kaduk ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr

Re: svn commit: r213643 - head/usr.bin/ar

2010-10-08 Thread Ben Kaduk
and  modes to 0644.  Useful for producing libraries that are  bitwise identical across multiple build runs. Thanks! Has anyone looked at the feasibility of setting AR?=ar -D in sys.mk? I will probably try this when I get my scratch box up again. -Ben Kaduk

Re: svn commit: r213398 - head/bin/rm

2010-10-04 Thread Ben Kaduk
belonging into a BUGS section? personally i think the BUGS section in rm(1) should be renamed to CAVEATS. BUGS is easier to find than CAVEATS, though I guess rm(1) is short enough that we can expect people to read the whole thing. -Ben Kaduk ___ svn-src

Re: svn commit: r211650 - head/share/man/man4

2010-08-22 Thread Ben Kaduk
space register mapping. Non-zero values enable or A non-zero value enables is better. +For controllers that have no I/O space register mapping this tunable +should be set to 0 to use I/O space register mapping. This seems odd -- should this^^^ be memory instead of I/O? Thanks, Ben Kaduk

Re: svn commit: r210065 - head/usr.bin/gcore

2010-07-14 Thread Ben Kaduk
and the fallouts can +be easily controlled.  .It Fl s  Stop the process while gathering the core image, and resume it  when done. Still has the style bug of not starting new sentences on new lines. Also, fallout should be singular, here. -Ben Kaduk ___ svn-src

Re: svn commit: r207709 - head/sys/dev/iwn

2010-05-06 Thread Ben Kaduk
to active scans. Basicly disable it by increasing the amount packets to be received to an amount which can't be reached during dwell times. Is this expected to fix the firmware errors that have cropped up periodically for me? (Sorry for the lack of useful bug reports, etc.) Thanks, Ben Kaduk