Re: svn commit: r366949 - head/usr.sbin/nfsd

2020-10-22 Thread Benjamin Kaduk
On Thu, Oct 22, 2020 at 12:25 PM Gordon Bergling wrote: > Author: gbe (doc committer) > Date: Thu Oct 22 19:25:01 2020 > New Revision: 366949 > URL: https://svnweb.freebsd.org/changeset/base/366949 > > Log: > stablerestart(5): Fix some issues reported by mandoc > > - New sentence, new line >

Re: svn commit: r365643 - head/bin/cp

2020-09-26 Thread Benjamin Kaduk
On Sat, Sep 26, 2020 at 12:35 PM Warner Losh wrote: > > > On Sat, Sep 26, 2020 at 12:58 PM Benjamin Kaduk wrote: > >> On Sat, Sep 26, 2020 at 11:55 AM Warner Losh wrote: >> >>> And there's the rub: how did this file come to exist? I'm certain it

Re: svn commit: r365643 - head/bin/cp

2020-09-26 Thread Benjamin Kaduk
On Sat, Sep 26, 2020 at 11:55 AM Warner Losh wrote: > And there's the rub: how did this file come to exist? I'm certain it isn't > booting or shutting down the system based on when devfs is mounted (before > init) and unmounted (it's not done by the shutdown scripts). Now, it's > always possible

Re: svn commit: r365052 - head/usr.bin/script

2020-09-01 Thread Benjamin Kaduk
On Tue, Sep 1, 2020 at 9:11 AM Warner Losh wrote: > Author: imp > Date: Tue Sep 1 16:11:23 2020 > New Revision: 365052 > URL: https://svnweb.freebsd.org/changeset/base/365052 > > Log: > Have script accept and ignore -e for Linux compat > > In the util-linux version of script, it will always

Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm

2020-08-27 Thread Benjamin Kaduk
On Thu, Aug 27, 2020 at 1:25 PM John Baldwin wrote: > On 8/26/20 9:55 AM, Jung-uk Kim wrote: > > Author: jkim > > Date: Wed Aug 26 16:55:28 2020 > > New Revision: 364822 > > URL: https://svnweb.freebsd.org/changeset/base/364822 > > > > Log: > > Fix Clang version detection. > > > > We prepend

Re: svn commit: r362620 - head/secure/lib/libcrypto

2020-06-25 Thread Benjamin Kaduk
On Thu, Jun 25, 2020 at 12:35 PM Gordon Tetlow wrote: > Author: gordon > Date: Thu Jun 25 19:35:37 2020 > New Revision: 362620 > URL: https://svnweb.freebsd.org/changeset/base/362620 > > Log: > Revert OPENSSL_NO_SSL3_METHOD to keep ABI compatibility. > > This define caused a couple of symbols

svn commit: r361839 - head/usr.bin/killall

2020-06-05 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Fri Jun 5 16:59:14 2020 New Revision: 361839 URL: https://svnweb.freebsd.org/changeset/base/361839 Log: Belatedly bump .Dd for r361783 Reported by: lwhsu Pointy hat to:bjk Modified: head/usr.bin/killall/killall.1 Modified: head/usr.bin/killa

Re: svn commit: r361783 - head/usr.bin/killall

2020-06-05 Thread Benjamin Kaduk
It seems Conrad dropped me from his reply, so I can't include it directly, but... On Thu, Jun 04, 2020 at 06:12:05AM -0700, Rodney W. Grimes wrote: > > 04.06.2020 11:29, Benjamin Kaduk wrote: > > > > > Author: bjk (doc committer) > > > Date: Thu Jun 4 04:29

svn commit: r361783 - head/usr.bin/killall

2020-06-03 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Jun 4 04:29:43 2020 New Revision: 361783 URL: https://svnweb.freebsd.org/changeset/base/361783 Log: Add EXAMPLES to killall(1) Submitted by: fernape Differential Revision:https://reviews.freebsd.org/D25002 Modified: head/usr.bin/killall/ki

Re: svn commit: r358417 - head/sys/cam

2020-02-27 Thread Benjamin Kaduk
On Thu, Feb 27, 2020 at 5:18 PM Warner Losh wrote: > Author: imp > Date: Fri Feb 28 01:18:11 2020 > New Revision: 358417 > URL: https://svnweb.freebsd.org/changeset/base/358417 > > Log: > This is a FALLTHROUGH for sure. no need for xxx comment. > > Modified: > head/sys/cam/cam_xpt.c > > Modif

Re: svn commit: r355696 - head/lib/libtacplus

2019-12-12 Thread Benjamin Kaduk
On Thu, Dec 12, 2019 at 9:11 PM Conrad Meyer wrote: > Author: cem > Date: Fri Dec 13 05:11:34 2019 > New Revision: 355696 > URL: https://svnweb.freebsd.org/changeset/base/355696 > > Log: > libtacplus: Remove bogus srandomdev+random > > Replace with arc4random. > > TACAS+ is a 1993 Cisco ext

svn commit: r350325 - in head: lib/libc/sys share/man/man9

2019-07-25 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Jul 25 15:43:15 2019 New Revision: 350325 URL: https://svnweb.freebsd.org/changeset/base/350325 Log: Fix grammar nit in copy_file_range docs Bytes are countable, so we have fewer of them, not less of them. Modified: head/lib/libc/sys/copy_file_range.

Re: svn commit: r349589 - in head: sbin/mount sys/sys sys/ufs/ffs

2019-07-02 Thread Benjamin Kaduk
On Mon, Jul 1, 2019 at 8:33 PM Kirk McKusick via svn-src-all < svn-src-...@freebsd.org> wrote: > Author: mckusick > Date: Mon Jul 1 23:22:26 2019 > New Revision: 349589 > URL: https://svnweb.freebsd.org/changeset/base/349589 > > Log: > Add a new "untrusted" option to the mount command. Its purp

Re: svn commit: r349133 - head/share/man/man4

2019-06-17 Thread Benjamin Kaduk
On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising wrote: > Author: zeising (doc,ports committer) > Date: Mon Jun 17 05:41:47 2019 > New Revision: 349133 > URL: https://svnweb.freebsd.org/changeset/base/349133 > > Log: > pci(4): Document PCIOCATTACHED > > Document the PCIOCATTACHED ioctl(2) in t

Re: svn commit: r348421 - head/sys/kern

2019-05-30 Thread Benjamin Kaduk
On Thu, May 30, 2019 at 8:04 AM Konstantin Belousov wrote: > Author: kib > Date: Thu May 30 15:04:09 2019 > New Revision: 348421 > URL: https://svnweb.freebsd.org/changeset/base/348421 > > Log: > Silence witness warning about duplicated mutex type. > > The order is correct, it is nullfs vnode

Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common

2019-02-26 Thread Benjamin Kaduk
On Tue, Feb 26, 2019 at 11:19 AM John Baldwin wrote: > On 2/26/19 8:59 AM, Rodney W. Grimes wrote: > >> On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert > > >> wrote: > >> > >>> On February 26, 2019 7:48:27 AM PST, Cy Schubert < > >>> cy.schub...@cschubert.com> wrote: > On February 26, 2019 12:

Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common

2019-02-26 Thread Benjamin Kaduk
On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert wrote: > On February 26, 2019 7:48:27 AM PST, Cy Schubert < > cy.schub...@cschubert.com> wrote: > >On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > > wrote: > [trimming the unneeded pile of commit body] > >This broke my systems, many files

Re: svn commit: r339565 - in head: share/man/man4 share/man/man4/man4.i386 sys/conf sys/dev/aha sys/kern sys/modules sys/modules/aha sys/sparc64/conf

2018-10-21 Thread Benjamin Kaduk
On Sun, Oct 21, 2018 at 9:53 PM Warner Losh wrote: > > > On Sun, Oct 21, 2018 at 8:47 PM Benjamin Kaduk wrote: > >> On Sun, Oct 21, 2018 at 9:35 PM Warner Losh wrote: >> >>> Author: imp >>> Date: Mon Oct 22 02:34:25 2018 >>> New Revision: 3

Re: svn commit: r339565 - in head: share/man/man4 share/man/man4/man4.i386 sys/conf sys/dev/aha sys/kern sys/modules sys/modules/aha sys/sparc64/conf

2018-10-21 Thread Benjamin Kaduk
On Sun, Oct 21, 2018 at 9:35 PM Warner Losh wrote: > Author: imp > Date: Mon Oct 22 02:34:25 2018 > New Revision: 339565 > URL: https://svnweb.freebsd.org/changeset/base/339565 > > Log: > Remove aha(4) from the tree. > > The documentation build is now failing, as there's an entity reference to

Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs

2018-08-17 Thread Benjamin Kaduk
On Fri, Aug 17, 2018 at 11:04 AM, Conrad Meyer wrote: > On Thu, Aug 16, 2018 at 10:03 PM, Cy Schubert > wrote: > > In message <201808170023.w7h0np0h027...@repo.freebsd.org>, Conrad Meyer > > writes: > >> Author: cem > >> Date: Fri Aug 17 00:23:50 2018 > >> New Revision: 337936 > >> URL: https://

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Benjamin Kaduk
On Thu, Aug 9, 2018 at 11:03 AM, Conrad Meyer wrote: > On Thu, Aug 9, 2018 at 5:52 AM, Benjamin Kaduk wrote: > > On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala < > tr...@freebsd.org> > > wrote: > >> Use NULLs instead of casted zeroes, for consistency.

Re: svn commit: r337535 - head/sbin/init

2018-08-09 Thread Benjamin Kaduk
On Thu, Aug 9, 2018 at 7:17 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Thu Aug 9 12:17:03 2018 > New Revision: 337535 > URL: https://svnweb.freebsd.org/changeset/base/337535 > > Log: > Use NULLs instead of casted zeroes, for consistency. > It's probably helpful to note explici

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Benjamin Kaduk
On Wed, Jun 20, 2018 at 1:21 AM, Simon J. Gerraty wrote: > Conrad Meyer wrote: > > > There's absolutely no reason to use sha1 or ripemd in new designs. > > These should be removed. > > Sorry I disagree - not with ripem (we never supported that or any of the > non-NIST approved hashes), but sha1

Re: svn commit: r334702 - head/sys/sys

2018-06-06 Thread Benjamin Kaduk
On Wed, Jun 6, 2018 at 6:35 AM, Ravi Pokala wrote: > Hi Mateusz, > > -Original Message- > From: on behalf of Mateusz Guzik > > Date: 2018-06-06, Wednesday at 01:08 > To: , , < > svn-src-head@freebsd.org> > Subject: svn commit: r334702 - head/sys/sys > > > ... > > #ifdef _KERNEL > > #

Re: Deorbiting i386

2018-05-26 Thread Benjamin Kaduk
So, when do we get to reprise this thread on -arch instead of svn-src-head? -Ben ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r334073 - head

2018-05-23 Thread Benjamin Kaduk
On Tue, May 22, 2018 at 11:09 PM, Eitan Adler wrote: > Author: eadler > Date: Wed May 23 04:09:01 2018 > New Revision: 334073 > URL: https://svnweb.freebsd.org/changeset/base/334073 > > Log: > README: Reduce the textdump; describe the project > > Rework the README to make it a little easier f

svn commit: r333306 - head/usr.bin/fetch

2018-05-06 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sun May 6 15:59:03 2018 New Revision: 06 URL: https://svnweb.freebsd.org/changeset/base/06 Log: Fix spelling of --output long option in fetch.1 PR: 228017 Reported by: rff1...@yahoo.com Modified: head/usr.bin/fetch/fetch.1 Modified

Re: svn commit: r332512 - head/sys/conf

2018-04-15 Thread Benjamin Kaduk
On Sun, Apr 15, 2018 at 10:13 AM, Brooks Davis wrote: > On Sun, Apr 15, 2018 at 03:06:07PM +, Brooks Davis wrote: > > Author: brooks > > Date: Sun Apr 15 15:06:07 2018 > > New Revision: 332512 > > URL: https://svnweb.freebsd.org/changeset/base/332512 > > > > Log: > > Remove device cm which

svn commit: r331892 - head/share/man/man4

2018-04-02 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Mon Apr 2 22:59:33 2018 New Revision: 331892 URL: https://svnweb.freebsd.org/changeset/base/331892 Log: Fix formatting in snd_hda.4 Submitted by: 0mp Reviewed by: skreuzer Differential Revision:https://reviews.freebsd.org/D14922 Modified: h

Re: svn commit: r331618 - head/share/man/man7

2018-03-27 Thread Benjamin Kaduk
On Tue, Mar 27, 2018 at 9:57 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: trasz > > Date: Tue Mar 27 14:51:19 2018 > > New Revision: 331618 > > URL: https://svnweb.freebsd.org/changeset/base/331618 > > > > Log: > > Use https:// instead of http://. > > > > MFC after

Re: svn commit: r331510 - in head: share/man/man4 sys/conf sys/dev/vmware/vmci sys/modules/vmware sys/modules/vmware/vmci

2018-03-25 Thread Benjamin Kaduk
I am surprised that no one has yet quoted the commit message from r325966 when the first SPDX tags appear to have been added to base: We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts.

Re: svn commit: r330602 - head/sys/compat/cloudabi

2018-03-07 Thread Benjamin Kaduk
On Wed, Mar 7, 2018 at 9:44 AM, Ed Maste wrote: > On 7 March 2018 at 09:47, Eitan Adler wrote: > > Author: eadler > > Date: Wed Mar 7 14:47:43 2018 > > New Revision: 330602 > > URL: https://svnweb.freebsd.org/changeset/base/330602 > > > > Log: > > sys/cloudabi: Avoid relying on GNU specific e

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Benjamin Kaduk
On Thu, Jan 18, 2018 at 10:49 PM, Conrad Meyer wrote: > No. It is the only logical result of a logical right shift larger > than the left operand. The C standard may claim that is undefined, > but that does not change the only logical result (zero). > > My point is that the compiler does not ar

Re: svn commit: r328159 - head/sys/modules

2018-01-18 Thread Benjamin Kaduk
On Thu, Jan 18, 2018 at 10:34 PM, Conrad Meyer wrote: > Author: cem > Date: Fri Jan 19 04:34:06 2018 > New Revision: 328159 > URL: https://svnweb.freebsd.org/changeset/base/328159 > > Log: > Unbreak i386 build > > The logical result of a right shift >= the width of a type is zero, but > our >

svn commit: r326651 - in head/bin: cat date kenv setfacl sh

2017-12-06 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Dec 7 01:57:27 2017 New Revision: 326651 URL: https://svnweb.freebsd.org/changeset/base/326651 Log: Fix mandoc -Tlint warnings in bin/ Many style-level issues are still reported. Submitted by: Yuri Pankov Reviewed by: jilles (previous revision

svn commit: r326650 - head/lib/libc/sys

2017-12-06 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Dec 7 01:50:17 2017 New Revision: 326650 URL: https://svnweb.freebsd.org/changeset/base/326650 Log: Note that old sys/event.h required manual sys/types.h inclusion ed fixed this in r313704 but older versions are still affected. Modified: head/lib/li

Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests

2017-11-20 Thread Benjamin Kaduk
On Mon, Nov 20, 2017 at 7:36 PM, Alan Somers wrote: > > > Are there any automated tools that care about the "Differential > Revision" field? If so, they should be able to tell the difference > between GitHub revisions and Phabricator revisions based on the URL. > Yes, Phabricator itself uses th

Re: svn commit: r318751 - in head/sys: kern sys

2017-10-23 Thread Benjamin Kaduk
On Mon, Oct 23, 2017 at 8:31 AM, Steve Wills wrote: > > Note too that security.bsd.see_jail_proc is partially a work around for > the fact that security.bsd.see_other_* doesn't work as you might expect. > It's literally the UID/GID, rather than the username, so > security.bsd.see_other_* has no i

Re: svn commit: r324732 - head/usr.sbin/jail

2017-10-19 Thread Benjamin Kaduk
ut from the installer when sysinstall was replaced. > -Nathan > > On 10/18/17 15:56, Benjamin Kaduk wrote: > > Author: bjk (doc committer) > > Date: Wed Oct 18 22:56:46 2017 > > New Revision: 324732 > > URL: https://svnweb.freebsd.org/changeset/base/324732 > > > &g

svn commit: r324732 - head/usr.sbin/jail

2017-10-18 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Wed Oct 18 22:56:46 2017 New Revision: 324732 URL: https://svnweb.freebsd.org/changeset/base/324732 Log: Adopt jail.8 to our brave new bsdinstall world Submitted by: Steve Kargl MFC after:3 days Modified: head/usr.sbin/jail/jail.8 Modified: head/u

svn commit: r324458 - head/share/man/man4

2017-10-09 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Tue Oct 10 00:26:44 2017 New Revision: 324458 URL: https://svnweb.freebsd.org/changeset/base/324458 Log: Add Asus USB-N13, rev. B1 to the rtwn_usb hardware list Reported by: Patrik Horst Modified: head/share/man/man4/rtwn_usb.4 Modified: head/share/ma

Re: svn commit: r324249 - head/lib/libc/net

2017-10-04 Thread Benjamin Kaduk
On Wed, Oct 4, 2017 at 10:10 AM, Ngie Cooper wrote: > > > On Oct 3, 2017, at 23:06, Cy Schubert wrote: > > > > @@ -189,19 +189,18 @@ function > > may be used to request the use of a connected > > .Tn TCP > > socket for queries. > > -If the > > +Queries will by defaulat use > > +.Tn UDP > > +data

svn commit: r324277 - head/lib/libc/net

2017-10-04 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Wed Oct 4 12:58:30 2017 New Revision: 324277 URL: https://svnweb.freebsd.org/changeset/base/324277 Log: mdoc style: start new sentence on new line Modified: head/lib/libc/net/gethostbyname.3 Modified: head/lib/libc/net/gethostbyname.3 ==

svn commit: r323122 - head/usr.sbin/autofs

2017-09-01 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Fri Sep 1 22:04:45 2017 New Revision: 323122 URL: https://svnweb.freebsd.org/changeset/base/323122 Log: Fix mdoc typo in auto_master.5 There needs to be a space after the no-space macro in order for it to be interpreted. PR: 221986 Submi

Re: svn commit: r318699 - head/lib/libc/gen

2017-05-23 Thread Benjamin Kaduk
On Tue, May 23, 2017 at 1:55 AM, Ngie Cooper wrote: > Author: ngie > Date: Tue May 23 06:55:51 2017 > New Revision: 318699 > URL: https://svnweb.freebsd.org/changeset/base/318699 > > Log: > directory(3): delete trailing whitespace and rewrite `E.g.` as `e.g.` > FWIW, it is better-still writte

Re: svn commit: r318643 - head/usr.sbin/efivar

2017-05-22 Thread Benjamin Kaduk
On Mon, May 22, 2017 at 8:56 AM, Glen Barber wrote: > Author: gjb > Date: Mon May 22 13:55:59 2017 > New Revision: 318643 > URL: https://svnweb.freebsd.org/changeset/base/318643 > > Log: > Correct the "first appeared in" version for efivar(8). > Hmm, I guess I should have put an MFC note for r

svn commit: r318599 - head/usr.sbin/efivar

2017-05-21 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sun May 21 22:10:08 2017 New Revision: 318599 URL: https://svnweb.freebsd.org/changeset/base/318599 Log: Updates for efivar.8 Fix spelling [1], appease igor and mandoc -Tlint, and adopt the language style to be more consistent with our corpus. PR:

Re: svn commit: r305177 - head/sys/net

2017-05-18 Thread Benjamin Kaduk
On Thu, May 18, 2017 at 10:00 AM, Oleg Bulyzhin wrote: > On Thu, May 18, 2017 at 04:25:01PM +0200, Hans Petter Selasky wrote: > > > > Can you explain a bit more what is wrong? > > > > > If you care about readability it should be: > > > pri) & 7) << 13) | (((cfi) & 1) << 12) | ((vlid) & EVL_VL

svn commit: r317910 - head/share/man/man9

2017-05-07 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sun May 7 19:01:08 2017 New Revision: 317910 URL: https://svnweb.freebsd.org/changeset/base/317910 Log: Bring VOP_GETPAGES.9 more up-to-date Attempt to catch up to the KPI changes from r292373, and perform some other tidying while in the area. Revie

Re: svn commit: r317809 - head/share/man/man7

2017-05-05 Thread Benjamin Kaduk
On Fri, May 5, 2017 at 8:39 AM, Bruce Evans wrote: > On Fri, 5 May 2017, Konstantin Belousov wrote: > > >> So the phrase is correct, and the below reformulation really removes the >> content. >> > > "integrity" isn't correct since it has nothing to do with integers. > "mechanisms" doesn't make mu

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin wrote: > > I do think that when referring to a Git hash the citation should also > include > something to identify which repository it came from. It doesn't have to > be a > URL per se (we just use 'NetBSD' for makefs, not a full URL to NetBSD's > cv

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 2:07 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > > > On the contrary, a git SHA1 seems like an eminently stable and unique > > search parameter! > > I agree that a commit log should inline some summary of

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: glebius > > Date: Tue Apr 25 15:56:46 2017 > > New Revision: 317409 > > URL: https://svnweb.freebsd.org/changeset/base/317409 > > > > Log: > > Che

svn commit: r315528 - in head/share/man: man5 man9

2017-03-18 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sun Mar 19 01:24:18 2017 New Revision: 315528 URL: https://svnweb.freebsd.org/changeset/base/315528 Log: Tidy up mdoc formatting for "etc.)" at end of line man(1) has some logic to use two spaces after a full stop, which is useful for spotting sentence br

Re: svn commit: r315318 - in head/sys: kern vm

2017-03-15 Thread Benjamin Kaduk
Should __FreeBSD_version be bumped, e.g., for out-of-tree filesystems that have custom vop_advise? -Ben On Wed, Mar 15, 2017 at 12:43 PM, Alan Cox wrote: > Author: alc > Date: Wed Mar 15 17:43:45 2017 > New Revision: 315318 > URL: https://svnweb.freebsd.org/changeset/base/315318 > > Log: > Re

Re: svn commit: r315165 - head/sys/kern

2017-03-12 Thread Benjamin Kaduk
On Sun, Mar 12, 2017 at 12:43 PM, Ian Lepore wrote: > Author: ian > Date: Sun Mar 12 17:43:45 2017 > New Revision: 315165 > URL: https://svnweb.freebsd.org/changeset/base/315165 > > Log: > Correct the abbreviations for microseconds (us, not ms), and for Hz (not > HZ). > > Modified: > head/sys

Re: svn commit: r314373 - in head: . etc/defaults etc/rc.d lib/libc/regex share/man/man4/man4.i386 share/man/man5 sys/amd64/conf sys/boot/forth sys/compat/svr4 sys/conf sys/dev/streams sys/i386/conf s

2017-02-28 Thread Benjamin Kaduk
On Tue, Feb 28, 2017 at 3:30 PM, Gleb Smirnoff wrote: > On Tue, Feb 28, 2017 at 01:39:12PM -0600, Benjamin Kaduk wrote: > B> > I don't think this deserves UPDATING entry, since it doesn't require > B> > any action from a person who updates from sources. > B>

Re: svn commit: r314373 - in head: . etc/defaults etc/rc.d lib/libc/regex share/man/man4/man4.i386 share/man/man5 sys/amd64/conf sys/boot/forth sys/compat/svr4 sys/conf sys/dev/streams sys/i386/conf s

2017-02-28 Thread Benjamin Kaduk
On Tue, Feb 28, 2017 at 1:36 PM, Gleb Smirnoff wrote: > Ravi, > > this should go into Relnotes, my failure that I didn't put the tag. > > I don't think this deserves UPDATING entry, since it doesn't require > any action from a person who updates from sources. > > I don't think this requires _

Re: svn commit: r314142 - head/sys/dev/ce

2017-02-23 Thread Benjamin Kaduk
On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an obviou

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Benjamin Kaduk
On Tue, Jan 17, 2017 at 10:57 AM, Ian Lepore wrote: > In my experience, enums are a superior way to define integer constants > (compared to #define), but they are pure poison as variable types in > APIs and structures because their size is a compiler implementation > choice. > Well, to some exte

Re: svn commit: r312234 - in head: sbin/camcontrol share/man/man4 share/man/man9 sys/arm/arm sys/arm/freescale/imx sys/arm/mv sys/cam sys/dev/bhnd sys/dev/fdt sys/dev/isp sys/dev/mmc sys/dev/mpt sys/d

2017-01-15 Thread Benjamin Kaduk
On Sun, Jan 15, 2017 at 11:54 AM, Conrad E. Meyer wrote: > Author: cem > Date: Sun Jan 15 17:54:01 2017 > New Revision: 312234 > URL: https://svnweb.freebsd.org/changeset/base/312234 > > Log: > "Buses" is the preferred plural of "bus" > > Replace archaic "busses" with modern form "buses." > >

svn commit: r311171 - head/share/man/man9

2017-01-03 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Tue Jan 3 21:11:30 2017 New Revision: 311171 URL: https://svnweb.freebsd.org/changeset/base/311171 Log: Fix typo Modified: head/share/man/man9/atomic.9 Modified: head/share/man/man9/atomic.9 ==

Re: svn commit: r309109 - head/lib/libutil

2016-11-24 Thread Benjamin Kaduk
I'm happy to have a comment noting the extreme subtleties in play and calling you out as the domain expert to contact. However, I don't think that the "UNDER PAIN OF DEATH" is appropriate, even jocularly; there are other ways to express the needed sentiment that do not cause one to think about the

svn commit: r307539 - head/release/doc/en_US.ISO8859-1/hardware

2016-10-17 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Mon Oct 17 22:48:29 2016 New Revision: 307539 URL: https://svnweb.freebsd.org/changeset/base/307539 Log: Fix relnotes build of supported hardware list after r307529 urtwn is merged into rtwn, so there is not a separate hardware list to include anymore. M

Re: svn commit: r304928 - in head/lib/libc: amd64/sys i386/sys sys

2016-08-29 Thread Benjamin Kaduk
On Mon, Aug 29, 2016 at 2:10 PM, Konstantin Belousov wrote: > On Mon, Aug 29, 2016 at 09:16:29PM +0300, Andrey Chernov wrote: > > Previous text is documented everywhere and describing usual good > > practice, so it should remains in place, in that means r304928 should be > > reverted, because rep

svn commit: r304560 - head/release/doc/en_US.ISO8859-1/hardware

2016-08-21 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sun Aug 21 15:39:46 2016 New Revision: 304560 URL: https://svnweb.freebsd.org/changeset/base/304560 Log: Remove the ie(4) hardware list from the release documentation The driver was removed by jhb in r304513, and the &hwlist.ie; entity is no longer genera

Re: svn commit: r304505 - head/release/doc/en_US.ISO8859-1/hardware

2016-08-20 Thread Benjamin Kaduk
On Fri, Aug 19, 2016 at 5:13 PM, John Baldwin wrote: > Author: jhb > Date: Fri Aug 19 22:13:01 2016 > New Revision: 304505 > URL: https://svnweb.freebsd.org/changeset/base/304505 > > Log: > Remove mentions of the mcd(4), scd(4), and si(4) drivers. > Hmm, looks like ie(4) also needs removal (in

Re: svn commit: r303801 - head/share/man/man3

2016-08-06 Thread Benjamin Kaduk
d TAILQ_SWAP both need > the "entry" parameter. > > Best, > Conrad > > On Sat, Aug 6, 2016 at 10:27 AM, Benjamin Kaduk wrote: > > Author: bjk (doc committer) > > Date: Sat Aug 6 17:27:07 2016 > > New Revision: 303801 > > URL: https://sv

svn commit: r303805 - head/share/man/man3

2016-08-06 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sat Aug 6 19:12:23 2016 New Revision: 303805 URL: https://svnweb.freebsd.org/changeset/base/303805 Log: Re-correct the documentation for the 'type' parameter of the _SWAP macros from sys/queue.h -- only the singly-linked forms do not need the 'field' argume

svn commit: r303801 - head/share/man/man3

2016-08-06 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sat Aug 6 17:27:07 2016 New Revision: 303801 URL: https://svnweb.freebsd.org/changeset/base/303801 Log: Correct the documentation of the 'type' parameter for the _SWAP macros from sys/queue.h Submitted by: akshay1994.leo_gmail.com (for STAILQ) Differen

Re: svn commit: r303755 - head/sys/kern

2016-08-05 Thread Benjamin Kaduk
On Fri, Aug 5, 2016 at 8:06 AM, John Baldwin wrote: > > It would be possible if both used the same versioning. Looks like > base on my desktop (10.3) is not using versioning, so if the version > map is provided by openssl we could in theory just use their version > map when building base openssl

Re: svn commit: r303716 - head/crypto/openssh

2016-08-03 Thread Benjamin Kaduk
On Wed, Aug 3, 2016 at 11:08 AM, Dag-Erling Smørgrav wrote: > Author: des > Date: Wed Aug 3 16:08:21 2016 > New Revision: 303716 > URL: https://svnweb.freebsd.org/changeset/base/303716 > > Log: > Remove DSA from default cipher list and disable SSH1. > > Upstream did this a long time ago, but

Re: svn commit: r303484 - head/usr.bin/indent

2016-07-29 Thread Benjamin Kaduk
On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Jul 29 16:17:54 2016 > New Revision: 303484 > URL: https://svnweb.freebsd.org/changeset/base/303484 > > Log: > indent(1): Fix breakage caused by single comment following "else". > > indent(1) simply wasn't tau

Re: svn commit: r303484 - head/usr.bin/indent

2016-07-29 Thread Benjamin Kaduk
On Fri, Jul 29, 2016 at 11:20 AM, Benjamin Kaduk wrote: > On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni > wrote: > >> Author: pfg >> Date: Fri Jul 29 16:17:54 2016 >> New Revision: 303484 >> URL: https://svnweb.freebsd.org/changeset/base/303484 >&g

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Benjamin Kaduk
On Tue, Jul 26, 2016 at 3:11 PM, Ed Schouten wrote: > Author: ed > Date: Tue Jul 26 20:11:29 2016 > New Revision: 303342 > URL: https://svnweb.freebsd.org/changeset/base/303342 > > Log: > Fix typing of srandom() and initstate(). > > POSIX requires that these functions have an unsigned int for

Re: svn commit: r302252 - head/sys/kern

2016-07-03 Thread Benjamin Kaduk
On Sat, Jul 2, 2016 at 3:04 AM, Bruce Evans wrote: > + .th_counter = &dummy_timecounter, >> + .th_scale = (uint64_t)-1 / 100, >> + .th_offset = {1, 0}, >> > > Is there a syntax for avoiding the explicit 0 in a nested initializer? > Something like th_offset.tv_sec = 1. C99

Re: svn commit: r298537 - head/etc/rc.d

2016-06-26 Thread Benjamin Kaduk
On Sun, Apr 24, 2016 at 12:01 PM, Jan Beich wrote: > Jens Schweikhardt writes: > > > - parenthesize the "case" string for symmetry and improved > >search for matching paren (e.g. with vi's %) > [...] > > case "${state}" in > > - [oO][nN]) >

Re: svn commit: r302210 - head/sys/fs/nfsclient

2016-06-26 Thread Benjamin Kaduk
On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov wrote: > Author: kib > Date: Sun Jun 26 14:18:28 2016 > New Revision: 302210 > URL: https://svnweb.freebsd.org/changeset/base/302210 > > Log: > Clean other flags in ncl_inactive, only. Add comment explaining why > other > flags should be u

Re: svn commit: r299831 - head/usr.sbin/bsnmpd/bsnmpd

2016-05-14 Thread Benjamin Kaduk
On Sat, May 14, 2016 at 10:38 PM, Garrett Cooper wrote: > Author: ngie > Date: Sun May 15 03:38:40 2016 > New Revision: 299831 > URL: https://svnweb.freebsd.org/changeset/base/299831 > > Log: > Remove NO_WERROR and add WARNS?= 6 > I thought WARNS=6 was already the default. -Ben __

Re: svn commit: r299218 - head/usr.bin/sdiff

2016-05-07 Thread Benjamin Kaduk
On Sat, May 7, 2016 at 1:48 PM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat May 7 18:48:48 2016 > New Revision: 299218 > URL: https://svnweb.freebsd.org/changeset/base/299218 > > Log: > Only use EDITOR as a variable to specify which text editor to use > > Why? VISUAL can still be ter

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Benjamin Kaduk
On Mon, 2 May 2016, Bjoern A. Zeeb wrote: > > > On 02 May 2016, at 16:08 , Conrad Meyer wrote: > > > > On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk wrote: > >> On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: > >>>> On 02 May 2016, at 15:

Re: svn commit: r298924 - head/usr.bin/sdiff

2016-05-02 Thread Benjamin Kaduk
On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb wrote: > > > On 02 May 2016, at 15:32 , Conrad Meyer wrote: > > > > Clang should really catch this too. Why didn’t it? > > It was only powerpc; sparc64 and mips were good as well. > > 'char' being signed vs. unsigned? -Ben __

Re: svn commit: r298036 - head/sys/cam

2016-04-15 Thread Benjamin Kaduk
On Fri, Apr 15, 2016 at 8:26 AM, Warner Losh wrote: > On Fri, Apr 15, 2016 at 12:05 AM, Howard Su wrote: > > >> I suggest to remove NETFLIX from the name. > > > > It's the Netflix I/O scheduler as opposed to the default one. So the > name is appropriate. It's better than CAM_WARNER_AWESOME_IOSCH

Re: svn commit: r297481 - head/sys/kern

2016-04-01 Thread Benjamin Kaduk
On Fri, Apr 1, 2016 at 1:12 AM, Mateusz Guzik wrote: > Author: mjg > Date: Wed Apr 1 08:10:00 2016 > New Revision: 280963 > Next year should probably update the "New Revision" line... > URL: https://svnweb.freebsd.org/changeset/base/297481 > > Log: > Increase responsiveness under load by be

Re: svn commit: r297201 - in head: share/man/man4 sys/dev/filemon

2016-03-22 Thread Benjamin Kaduk
On Tue, Mar 22, 2016 at 9:11 PM, Bryan Drewery wrote: > > > > The manpage for close(2) does document some errors, one being ENOSPC. The > close(2) behavior of returning write(2), really VOP_WRITE(9), errors though > is specific to filemon since all of the writes are hidden and this is the > only

Re: svn commit: r297025 - head/sbin/ping

2016-03-19 Thread Benjamin Kaduk
On Fri, Mar 18, 2016 at 10:07 AM, Maxim Konovalov wrote: > Author: maxim > Date: Fri Mar 18 15:07:43 2016 > New Revision: 297025 > URL: https://svnweb.freebsd.org/changeset/base/297025 > > Log: > o Kill EoL whitespaces. > > Modified: > head/sbin/ping/ping.c > > Modified: head/sbin/ping/ping.c

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-19 Thread Benjamin Kaduk
On Fri, Feb 19, 2016 at 6:50 PM, Conrad Meyer wrote: > On Fri, Feb 19, 2016 at 3:14 PM, Benjamin Kaduk wrote: > > On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff > wrote: > >> Isn't zero filling part of the standard? I don't see why lack of > >> expl

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-19 Thread Benjamin Kaduk
On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote: > On Fri, Feb 19, 2016 at 08:49:43AM -0700, Alan Somers wrote: > A> On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov > wrote: > A> Yeah, it was being implicitly zeroized before. But Clang complained > A> about the structures being only part

svn commit: r295765 - head/lib/libc/sys

2016-02-18 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Feb 18 18:50:03 2016 New Revision: 295765 URL: https://svnweb.freebsd.org/changeset/base/295765 Log: Bump .Dd for r295764 Also fix a spelling and grammar nit while here. Modified: head/lib/libc/sys/lseek.2 Modified: head/lib/libc/sys/lseek.2 ===

Re: svn commit: r295566 - head/share/man/man4

2016-02-12 Thread Benjamin Kaduk
On Fri, 12 Feb 2016, Ian Lepore wrote: > On Fri, 2016-02-12 at 17:03 +0000, Benjamin Kaduk wrote: > > Author: bjk (doc committer) > > Date: Fri Feb 12 17:03:24 2016 > > New Revision: 295566 > > URL: https://svnweb.freebsd.org/changeset/base/295566 > > >

svn commit: r295566 - head/share/man/man4

2016-02-12 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Fri Feb 12 17:03:24 2016 New Revision: 295566 URL: https://svnweb.freebsd.org/changeset/base/295566 Log: Update .Dd for r295565 Modified: head/share/man/man4/ds3231.4 Modified: head/share/man/man4/ds3231.4

Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys

2016-02-11 Thread Benjamin Kaduk
On Thu, Feb 11, 2016 at 10:47 AM, Warner Losh wrote: > On Wed, Feb 10, 2016 at 8:08 AM, Pedro Giffuni wrote: > > > If it is faster, is there any good reason to maintain both qsort and > mergesort > in the kernel then? > qsort is not stable; mergesort is. (It's a shame that glibc didn't pick up

Re: svn commit: r295169 - head/usr.sbin/sysrc

2016-02-02 Thread Benjamin Kaduk
On Tue, Feb 2, 2016 at 5:50 PM, Devin Teske wrote: > On Tue, 2016-02-02 at 16:03 -0600, Benjamin Kaduk wrote: > > On Tue, Feb 2, 2016 at 3:58 PM, Devin Teske wrote: > > Author: dteske > Date: Tue Feb 2 21:58:17 2016 > New Revision: 295169 > URL: https://svnweb.freebsd.o

Re: svn commit: r295169 - head/usr.sbin/sysrc

2016-02-02 Thread Benjamin Kaduk
On Tue, Feb 2, 2016 at 3:58 PM, Devin Teske wrote: > Author: dteske > Date: Tue Feb 2 21:58:17 2016 > New Revision: 295169 > URL: https://svnweb.freebsd.org/changeset/base/295169 > > Log: > Replace (Qo \ Qc) with (Qo (space) Qc) > > When using col(1) piped to vim(1) as pager for man(1), the

svn commit: r294638 - head/share/man/man9

2016-01-23 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Sat Jan 23 20:01:46 2016 New Revision: 294638 URL: https://svnweb.freebsd.org/changeset/base/294638 Log: Document that hashinit(9) can wait for memory to be available Also tweak nearby grammar while here. Submitted by: Daniel O'Connor (original version

svn commit: r294579 - head/usr.bin/whois

2016-01-22 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Fri Jan 22 17:17:27 2016 New Revision: 294579 URL: https://svnweb.freebsd.org/changeset/base/294579 Log: Bump .Dd after r294575 Modified: head/usr.bin/whois/whois.1 Modified: head/usr.bin/whois/whois.1

svn commit: r294023 - head/share/man/man4

2016-01-14 Thread Benjamin Kaduk
Author: bjk (doc committer) Date: Thu Jan 14 17:16:47 2016 New Revision: 294023 URL: https://svnweb.freebsd.org/changeset/base/294023 Log: Update .Dd, missed in r294011 Modified: head/share/man/man4/ddb.4 Modified: head/share/man/man4/ddb.4 ===

Re: svn commit: r292120 - in head/contrib/elftoolchain: addr2line common elfcopy libelf readelf

2015-12-13 Thread Benjamin Kaduk
On Sun, Dec 13, 2015 at 3:13 AM, Dimitry Andric wrote: > On 13 Dec 2015, at 09:43, Kai Wang wrote: > > > > 2015-12-13 7:04 GMT+01:00 Adrian Chadd : > > cc1: warnings being treated as errors > > > /usr/home/adrian/work/freebsd/head-embedded/src/usr.bin/readelf/../../contrib/elftoolchain/readelf/r

Re: svn commit: r291860 - in head/tools/tools/nanobsd: . embedded

2015-12-05 Thread Benjamin Kaduk
On Sat, Dec 5, 2015 at 10:28 AM, Warner Losh wrote: > Author: imp > Date: Sat Dec 5 16:28:14 2015 > New Revision: 291860 > URL: https://svnweb.freebsd.org/changeset/base/291860 > > Log: > Stupid last minute changes: Add missing } and fi > > Pointed out by: Howard Su > > Modified: > head/to

Re: svn commit: r291637 - head/cddl/contrib/opensolaris/cmd/plockstat

2015-12-01 Thread Benjamin Kaduk
On Tue, Dec 1, 2015 at 10:18 PM, Craig Rodrigues wrote: > On Tue, Dec 1, 2015 at 6:11 PM, Bryan Drewery > wrote: > > > - (void) snprintf(buf, size, "%#lx", addr); > > + (void) snprintf(buf, size, "%#lx", (unsigned long)addr); > > return (0); > > > > In

  1   2   3   >