Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Jonathan Hull via swift-dev
There is something interesting here. I like that ‘Bool?’ really represents what we need from the relation on Float. I think it solves the objection that Xiaodi mentioned with a PartialEq protocol. If everyone just switches to using PartialEq in generic contexts because they want it to work wi

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Jonathan Hull via swift-dev
One possibility which might be easier would be to just depreciate Float’s Equatable conformance and provide a warning/fixit (suggesting how to use the new ‘~’ relation). > On Oct 25, 2017, at 2:35 AM, Jonathan Hull wrote: > > There is something interesting here. I like that ‘Bool?’ really rep

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread David Zarzycki via swift-dev
> On Oct 25, 2017, at 02:34, Xiaodi Wu via swift-dev > wrote: > > Please see earlier replies summarizing core team members' persuasive > arguments as to why not multiple protocol hierarchies like this. Hi Xiaodi, The above line is does it help your argument. Even if a person was motivated t

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread David Zarzycki via swift-dev
> On Oct 25, 2017, at 08:29, David Zarzycki via swift-dev > wrote: > > > >> On Oct 25, 2017, at 02:34, Xiaodi Wu via swift-dev > > wrote: >> >> Please see earlier replies summarizing core team members' persuasive >> arguments as to why not multiple protocol hier

Re: [swift-dev] Looking for documentation/insight on .swiftdoc

2017-10-25 Thread George King via swift-dev
Thanks for the pointers. Doug, I take it from your initial comment that there is no matching “readDocFromStream”? (I don’t see one in Deserialization.cpp). If not, then what consumes the swiftdoc files? > On Oct 24, 2017, at 6:09 PM, Douglas Gregor wrote: > > > >> On Oct 24, 2017, at 3:05 P

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #572

2017-10-25 Thread Xi Ge via swift-dev
Not sure why this failed, but the next build is successful. > On Oct 24, 2017, at 11:41 PM, no-re...@swift.org wrote: > > [FAILURE] swift-master-source-compat-suite [#572] > > Build URL:https://ci.swift.org/job/swift-master-source-compat-suite/572/ >

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread David Sweeris via swift-dev
> On Oct 25, 2017, at 5:29 AM, David Zarzycki via swift-dev > wrote: > > > >> On Oct 25, 2017, at 02:34, Xiaodi Wu via swift-dev > > wrote: >> >> Please see earlier replies summarizing core team members' persuasive >> arguments as to why not multiple protocol hie

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread David Zarzycki via swift-dev
> On Oct 25, 2017, at 12:01, David Sweeris wrote: > > >> On Oct 25, 2017, at 5:29 AM, David Zarzycki via swift-dev >> mailto:swift-dev@swift.org>> wrote: >> >> >> >>> On Oct 25, 2017, at 02:34, Xiaodi Wu via swift-dev >> > wrote: >>> >>> Please see earlier repl

[swift-dev] How does a standard collection know when its storage has to die?

2017-10-25 Thread Daryle Walker via swift-dev
OK, so the standard collections (Array, Set, Dictionary) are value types with remote storage. Since they don’t have de-initializers, how would any reference count get any notification to eventually de-allocate ? Or is the memory leaked? Or is some sort of secret system-provided de-initalizer add

Re: [swift-dev] How does a standard collection know when its storage has to die?

2017-10-25 Thread Slava Pestov via swift-dev
These types are essentially single-field structs. The underlying storage is referenced from this field, which has a reference type. While structs cannot have user-defined destructors, the compiler knows when a value of struct type goes out of scope and destroys its fields, which for reference ty

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Xiaodi Wu via swift-dev
On Wed, Oct 25, 2017 at 12:06 PM, David Zarzycki wrote: > > > On Oct 25, 2017, at 12:01, David Sweeris wrote: > > > On Oct 25, 2017, at 5:29 AM, David Zarzycki via swift-dev < > swift-dev@swift.org> wrote: > > > > On Oct 25, 2017, at 02:34, Xiaodi Wu via swift-dev > wrote: > > Please see earlie

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.1) #44

2017-10-25 Thread no-reply--- via swift-dev
Title: Report [FAILURE] oss-swift-4.1-package-osx [#44] Build URL:https://ci.swift.org/job/oss-swift-4.1-package-osx/44/ Project:oss-swift-4.1-package-osx Date of build:Wed, 25 Oct 2017 16:41:01 -0500 Build duration:3 hr 16 min Changes Commit 3fe2

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #517

2017-10-25 Thread no-reply--- via swift-dev
Title: Report [FAILURE] oss-swift-4.0-package-osx [#517] Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/517/ Project:oss-swift-4.0-package-osx Date of build:Wed, 25 Oct 2017 17:03:05 -0500 Build duration:2 hr 58 min Changes Commit ef

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.1) #44

2017-10-25 Thread Mishal Shah via swift-dev
Fixed. Thanks, Mishal Shah > On Oct 25, 2017, at 5:56 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.1-package-osx [#44] > > Build URL:https://ci.swift.org/job/oss-swift-4.1-package-osx/44/ > > Project: oss-swift-4.1-p

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #517

2017-10-25 Thread Mishal Shah via swift-dev
Fixed. Thanks, Mishal Shah > On Oct 25, 2017, at 5:59 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.0-package-osx [#517] > > Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/517/ > > Project: oss-swift-4.

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Jonathan Hull via swift-dev
> On Oct 25, 2017, at 9:01 AM, David Sweeris via swift-dev > wrote: > > That said, I fully acknowledge that this is all above my pay grade (also I > hadn't realized that the issue was as settled as it apparently is). If > splitting the protocols is a no-go from the get go, I'll go back to tryi

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Xiaodi Wu via swift-dev
On Wed, Oct 25, 2017 at 8:26 PM, Jonathan Hull wrote: > > On Oct 25, 2017, at 9:01 AM, David Sweeris via swift-dev < > swift-dev@swift.org> wrote: > > > > That said, I fully acknowledge that this is all above my pay grade (also > I hadn't realized that the issue was as settled as it apparently is

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread David Zarzycki via swift-dev
> On Oct 25, 2017, at 19:25, Xiaodi Wu wrote: > > I was proposing something different where Float and Int are both Equatable > and Substitutable, but neither Equatable nor Substitutable inherit from the > other. The former is mathematical and the latter is not (which allows it to > deal with

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.10 (swift 4.0) #516

2017-10-25 Thread Ankit Aggarwal via swift-dev
WARNING: Your password has expired. Password change required but no TTY available. > On 25-Oct-2017, at 4:58 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.0-package-linux-ubuntu-16_10 [#516] > > Build URL: > https://ci.swift.org/job/oss-swift-4.0-package-linux-ubuntu-16_10/516/ >

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.10 (swift 4.0) #516

2017-10-25 Thread Mishal Shah via swift-dev
Fixed. Thanks, Mishal Shah > On Oct 25, 2017, at 7:13 PM, Ankit Aggarwal wrote: > > WARNING: Your password has expired. > Password change required but no TTY available. > > >> On 25-Oct-2017, at 4:58 PM, no-re...@swift.org >> wrote: >> >> [FAILURE] oss-swift-4.0

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Jonathan Hull via swift-dev
As someone mentioned earlier, we are trying to square a circle here. We can’t have everything at once… we will have to prioritize. I feel like the precedent in Swift is to prioritize safety/correctness with an option ignore safety and regain speed. I think the 3 point solution I proposed is a

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Xiaodi Wu via swift-dev
On Wed, Oct 25, 2017 at 9:05 PM, David Zarzycki wrote: > > > On Oct 25, 2017, at 19:25, Xiaodi Wu wrote: > > I was proposing something different where Float and Int are both Equatable >> and Substitutable, but neither Equatable nor Substitutable inherit from the >> other. The former is mathemati

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

2017-10-25 Thread Xiaodi Wu via swift-dev
On Wed, Oct 25, 2017 at 11:46 PM, Jonathan Hull wrote: > As someone mentioned earlier, we are trying to square a circle here. We > can’t have everything at once… we will have to prioritize. I feel like the > precedent in Swift is to prioritize safety/correctness with an option > ignore safety an