Thanks Alexander. Will make the fix.
Regards,
Vivi
On 10/9/2014 2:52 AM, Alexander Zvegintsev wrote:
Hello Vivi
We can move Hashset creation to btnsInGroup's declaration, thus the
following lines can be removed
460 if (btnsInGroup == null)
461 btnsInGroup =
The fix looks good to me.
Thanks,
Alexandr.
On 10/9/2014 4:07 PM, Alexey Ivanov wrote:
Hello Swing team,
A small update to the test: I explicitly set look-and-feel to
MetalLookAndFeel.
Updated webrev:
http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/
Thanks,
Alexey.
On 0
Hello Alexey
The fix looks good
Thanks
alexp
On 10/9/2014 4:07 PM, Alexey Ivanov wrote:
Hello Swing team,
A small update to the test: I explicitly set look-and-feel to
MetalLookAndFeel.
Updated webrev:
http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/
Thanks,
Alexey.
On 08.10.
Hello Swing team,
A small update to the test: I explicitly set look-and-feel to
MetalLookAndFeel.
Updated webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/
Thanks,
Alexey.
On 08.10.2014 15:57, Alexey Ivanov wrote:
Hello Swing team,
Could you please review the fix for the b
Hello Dmitry
Looks good!
Thanks
alexp
On 10/9/2014 12:08 PM, dmitry markov wrote:
I ran related JCK and regression tests and did not observe any failures.
Thanks,
Dmitry
On 08/10/2014 16:04, Alexander Scherbatiy wrote:
The fix looks good to me.
Could you also test the fix with the JCK
Hello Vivi
We can move Hashset creation to btnsInGroup's declaration, thus the
following lines can be removed
460 if (btnsInGroup == null)
461 btnsInGroup = new HashSet();
Otherwise the fix looks good to me.
Thanks,
Alexander.
On 10/09/2014 09:53 AM, Vivi An
I ran related JCK and regression tests and did not observe any failures.
Thanks,
Dmitry
On 08/10/2014 16:04, Alexander Scherbatiy wrote:
The fix looks good to me.
Could you also test the fix with the JCK and regression tests?
Thanks,
Alexandr.
On 10/8/2014 2:08 PM, dmitry markov wrot