Re: [9] Review request for 8033699: Incorrect radio button behavior

2014-10-09 Thread Vivi An
Thanks Alexander. Will make the fix. Regards, Vivi On 10/9/2014 2:52 AM, Alexander Zvegintsev wrote: Hello Vivi We can move Hashset creation to btnsInGroup's declaration, thus the following lines can be removed 460 if (btnsInGroup == null) 461 btnsInGroup =

Re: [9] Review request for JDK-7170310: ScrollBar doesn't become active when tabs are created more than frame size

2014-10-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/9/2014 4:07 PM, Alexey Ivanov wrote: Hello Swing team, A small update to the test: I explicitly set look-and-feel to MetalLookAndFeel. Updated webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/ Thanks, Alexey. On 0

Re: [9] Review request for JDK-7170310: ScrollBar doesn't become active when tabs are created more than frame size

2014-10-09 Thread Alexander Potochkin
Hello Alexey The fix looks good Thanks alexp On 10/9/2014 4:07 PM, Alexey Ivanov wrote: Hello Swing team, A small update to the test: I explicitly set look-and-feel to MetalLookAndFeel. Updated webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/ Thanks, Alexey. On 08.10.

Re: [9] Review request for JDK-7170310: ScrollBar doesn't become active when tabs are created more than frame size

2014-10-09 Thread Alexey Ivanov
Hello Swing team, A small update to the test: I explicitly set look-and-feel to MetalLookAndFeel. Updated webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.1/ Thanks, Alexey. On 08.10.2014 15:57, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix for the b

Re: [9] Review request for 8058120: Rendering / caret errors with HTMLDocument

2014-10-09 Thread Alexander Potochkin
Hello Dmitry Looks good! Thanks alexp On 10/9/2014 12:08 PM, dmitry markov wrote: I ran related JCK and regression tests and did not observe any failures. Thanks, Dmitry On 08/10/2014 16:04, Alexander Scherbatiy wrote: The fix looks good to me. Could you also test the fix with the JCK

Re: [9] Review request for 8033699: Incorrect radio button behavior

2014-10-09 Thread Alexander Zvegintsev
Hello Vivi We can move Hashset creation to btnsInGroup's declaration, thus the following lines can be removed 460 if (btnsInGroup == null) 461 btnsInGroup = new HashSet(); Otherwise the fix looks good to me. Thanks, Alexander. On 10/09/2014 09:53 AM, Vivi An

Re: [9] Review request for 8058120: Rendering / caret errors with HTMLDocument

2014-10-09 Thread dmitry markov
I ran related JCK and regression tests and did not observe any failures. Thanks, Dmitry On 08/10/2014 16:04, Alexander Scherbatiy wrote: The fix looks good to me. Could you also test the fix with the JCK and regression tests? Thanks, Alexandr. On 10/8/2014 2:08 PM, dmitry markov wrot