Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread pooja chopra
Hello, Please review a fix for issue: 8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8079428 The webrev is : http://cr.openjdk.java.net/~pchopra/8079428/webrev.00/ Thanks, Pooja

Re: Swing Dev [9] Review Request: 6206437 Typo in JInternalFrame setDefaultCloseOperation() doc (WindowClosing -- internalFrameClosing)

2015-05-06 Thread Alexander Zvegintsev
Hello Sergey, the fix looks fine to me. Thanks, Alexander. On 05/05/2015 07:16 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a small typo. Bug: https://bugs.openjdk.java.net/browse/JDK-6206437 Webrev can be found at: http://cr.openjdk.java.net/~serb/6206437/webrev.00

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexander Zvegintsev
Hello Pooja, the fix looks fine to me. Thanks, Alexander. On 05/06/2015 09:18 AM, pooja chopra wrote: Hello, Please review a fix for issue: 8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8079428 The webrev is :

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Sergey Bylokhov
Hello, It seems that this is a bug in the jtreg because according its specification: If no |@run| tags are present in a defining file, a default is assumed depending upon the file's filename extension File type Default Notes .java |@run main name| name is the name of the

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Yuri Nesterenko
I guess the @build instruction here adds some degree of uncertainty: jtreg may not be able to determine which class to run. -yan On 05/06/2015 04:45 PM, Alexey Ivanov wrote: Hello, I faced this problem too, and only with JDK 9. If there's no @run tag in the java file, the main method of the

Swing Dev [9] Review request for 8033069: mouse wheel scroll closes combobox popup

2015-05-06 Thread Alexey Ivanov
Hello Swing team, Could you please review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033069 webrev: http://cr.openjdk.java.net/~aivanov/8033069/jdk9/webrev.00/ Description: If you rotate mouse wheel when combo box popup is open, the popup gets closed. The fix is to

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexey Ivanov
Hello, I faced this problem too, and only with JDK 9. If there's no @run tag in the java file, the main method of the test is not run. However in my case, the test reported success where I expected failure. Regards, Alexey On 06.05.2015 15:29, Sergey Bylokhov wrote: Hello, It seems that

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Alexander Scherbatiy
This is the known issue in jtreg: CODETOOLS-7901378 Test result error when @build used without @run main https://bugs.openjdk.java.net/browse/CODETOOLS-7901378 It is closed as not an issue but I would argue against it. It definitely worked in jtreg 4.1 fcs b05. Why tests which pass

Re: Swing Dev Proposal for change to javax.swing.DefaultCellEditor

2015-05-06 Thread Alexander Scherbatiy
Could you file an enhancement on your proposal in http://bugreport.java.com/bugreport Thanks, Alexandr. On 5/5/2015 1:40 PM, Doychin Bondzhev wrote: Hi, guys. i can't check in the archive was this ever discussed before but here is my proposal: Right now DefaultCellEditor has 3

Re: Swing Dev [9] Review request for 8033069: mouse wheel scroll closes combobox popup

2015-05-06 Thread Sergey Bylokhov
Hi, Alexey. The changes in the BasicPopupMenuUI does not look clear, I am not sure but probably it will be better to implement it in the same way as for MOUSE_PRESSED(via UIManager property)? It will add an additional configuration possibility. Can you also confirm that the case when the user

Swing Dev [9] Review Request: 8013820 JavaDoc for JSpinner contains errors

2015-05-06 Thread Sergey Bylokhov
Hello. Please review the fix for a typo in jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8013820 Webrev can be found at: http://cr.openjdk.java.net/~serb/8013820/webrev.00 -- Best regards, Sergey.

Swing Dev [9] Review Request: 8078149 [macosx] The text of the TextArea is not wrapped at word boundaries

2015-05-06 Thread Sergey Bylokhov
Hello. Please review the fix for a small fix. This is the problem in lwawt, which was fixed in xawt already: https://bugs.openjdk.java.net/browse/JDK-4992455 1. About line wrapping property. JTextArea has a bound property for line wrapping that controls whether or not it will wrap lines.

Re: Swing Dev [9] Review Request: 6206437 Typo in JInternalFrame setDefaultCloseOperation() doc (WindowClosing -- internalFrameClosing)

2015-05-06 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/6/2015 12:00 PM, Alexander Zvegintsev wrote: Hello Sergey, the fix looks fine to me. Thanks, Alexander. On 05/05/2015 07:16 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a small typo. Bug:

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-06 Thread Sergey Bylokhov
After discussion we confirm that the problem in the tests. This fix looks fine. On 06.05.15 17:11, Alexander Scherbatiy wrote: This is the known issue in jtreg: CODETOOLS-7901378 Test result error when @build used without @run main https://bugs.openjdk.java.net/browse/CODETOOLS-7901378