Re: Swing Dev [9] Review Request for 6260348: GTK+ LF JTextComponent not respecting desktop caret blink rate

2015-05-08 Thread Semyon Sadetsky
Hi Alexander, gboolean and gint are equivalent. --Semyon On 4/27/2015 5:31 PM, Alexander Scherbatiy wrote: On 4/23/2015 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: web rev: http://cr.openjdk.java.net/~ssadetsky/6260348/webrev.00/ bug:

Swing Dev [9] Review Request for 8079640: GroupLayout incorrect layout with large JTextArea

2015-05-08 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8079640 webrev: http://cr.openjdk.java.net/~ssadetsky/8079640/webrev.00/ *THE ROOT CAUSE Component minimum size is limited to Short.MAX_VALUE in GroupLayout. JDK turtorial

Re: Swing Dev [9] Review Request for 6260348: GTK+ LF JTextComponent not respecting desktop caret blink rate

2015-05-08 Thread Alexander Zvegintsev
Hi Semyon, the fix itself looks good to me, but the test doesn't work. 1. FileWriter is replacing the .gtkrc-2.0 file (FileWriter(file, true /*append*/) should be used) ; 2. settings from .gtkrc-2.0 doesn't taken into account on my system. there are at least two system tools which allows to

Re: Swing Dev [9] Review Request: JDK-8079428 [TEST_BUG] Test javax/swing/plaf/windows/6921687/bug6921687.java fails

2015-05-08 Thread Jonathan Gibbons
There is no issue here and the tests that used to work with jtreg b05 didn't do what you thought they did. Just look at the .jtr file and see what jtreg actually did before. First, you need to realize that @build is a shorthand for @run build.The section on shorthands is in the very next

Swing Dev [9] Review Request: 6368321 MetalRootPaneUI calls to deprecated code

2015-05-08 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. I do not plan to backport it to jdk8. Usage of deprecated methods(xxxMenuBar()) were removed as suggested in the bug comments. The fix is a part of https://bugs.openjdk.java.net/browse/JDK-8066622 efforts. Bug:

Re: Swing Dev [9] Review Request for 6260348: GTK+ LF JTextComponent not respecting desktop caret blink rate

2015-05-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/8/2015 11:51 AM, Semyon Sadetsky wrote: Hi Alexander, gboolean and gint are equivalent. --Semyon On 4/27/2015 5:31 PM, Alexander Scherbatiy wrote: On 4/23/2015 5:23 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: web

Re: Swing Dev [9] Review Request for 8079640: GroupLayout incorrect layout with large JTextArea

2015-05-08 Thread Sergey Bylokhov
Hi, Semyon. It will be good to dig into the history of GroupLayout and understand why this was constrained, note that tutorial should be updated also. On 08.05.15 11:47, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8079640 webrev:

Re: Swing Dev JDK-8023043 : Clipboard.getAvailableDataFlavors: Comparison method violates contract

2015-05-08 Thread Alexander Scherbatiy
Hi Jason, Please, file it as a new issue in http://bugreport.java.com/bugreport Thanks, Alexandr. On 5/7/2015 11:08 PM, Jason Mehrens wrote: Anton, I finally caught this error in production. I patched our code to launch a JVM (with mergesort) using your test case, modifed to

Re: Swing Dev JDK-8023043 : Clipboard.getAvailableDataFlavors: Comparison method violates contract

2015-05-08 Thread Anton Nashatyrev
Hi Alexander, I've updated the existing issue filed by Jason with the new information. So it seems no need to create a new one. Thanks! Anton. On 08.05.2015 15:38, Alexander Scherbatiy wrote: Hi Jason, Please, file it as a new issue in http://bugreport.java.com/bugreport Thanks,

Re: Swing Dev [9] Review Request: 8013820 JavaDoc for JSpinner contains errors

2015-05-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/7/2015 3:06 PM, Alexander Zvegintsev wrote: looks fine. Thanks, Alexander. On 05/06/2015 10:52 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a typo in jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8013820 Webrev

Re: Swing Dev JDK-8023043 : Clipboard.getAvailableDataFlavors: Comparison method violates contract

2015-05-08 Thread Alexander Scherbatiy
On 5/8/2015 3:41 PM, Anton Nashatyrev wrote: Hi Alexander, I've updated the existing issue filed by Jason with the new information. So it seems no need to create a new one. I see. I have founds this one: https://bugs.openjdk.java.net/browse/JDK-8078376 Thanks, Alexandr.

Re: Swing Dev [9] Review Request: 5036022: JSpinner does not reflect new font on subsequent calls to setFont

2015-05-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/7/2015 3:48 PM, Alexander Zvegintsev wrote: looks fine to me. Thanks, Alexander. On 05/07/2015 02:46 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. All our UI components use a UIResource to store some lf related

Swing Dev [9] Review Request: 5109918 Wrong documentation for JSpinner.DateEditor constructor

2015-05-08 Thread Sergey Bylokhov
Hello. Please review one more small fix for a typo in jdk9. Description for constructor public JSpinner.DateEditor(JSpinner spinner) containes: This DateEditor becomes both a ChangeListener on the spinners model and a PropertyChangeListener on the new JFormattedTextField. In fact