swing-dev@openjdk.java.net

2015-09-08 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8134828 webrev: http://cr.openjdk.java.net/~ssadetsky/8134828/webrev.00/ This is a regression from the 8041642 which introduced a protection from shrinking of the painter image less then it stretching inset when 9

Re: [9-client] Review request for bug 8005914: [TEST_BUG] The last column header does not contain "..."

2015-09-08 Thread Sergey Bylokhov
Looks fine. On 08.09.15 16:08, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/8/2015 3:55 PM, shilpi rastogi wrote: Hi All, Please review the updated webrev http://cr.openjdk.java.net/~kshefov/8005914/webrev.000/

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Semyon Sadetsky
On 9/8/2015 2:10 PM, Alexander Scherbatiy wrote: On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On

Re: [9-client] Review request for bug 8005914: [TEST_BUG] The last column header does not contain "..."

2015-09-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2015 3:55 PM, shilpi rastogi wrote: Hi All, Please review the updated webrev http://cr.openjdk.java.net/~kshefov/8005914/webrev.000/ Thanks, Shilpi On 9/3/2015 8:12 PM, Ale

Re: [9-client] Review request for bug 8005914: [TEST_BUG] The last column header does not contain "..."

2015-09-08 Thread shilpi rastogi
Hi All, Please review the updated webrev http://cr.openjdk.java.net/~kshefov/8005914/webrev.000/ Thanks, Shilpi On 9/3/2015 8:12 PM, Alexander Scherbatiy wrote: On 9/3/2015 8:52 AM, shilpi rastogi wrote: Hi all, Please review a te

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Sergey Bylokhov
On 08.09.15 13:57, Sergey Bylokhov wrote: Hi, Prasanta. Just before the push of this fix I made small pit, and found a regression. Please run the SwingSet2, open JTable demo, and scroll the table. You will see some artifacts. When you will update the fix, please also add a new automated test,

Re: [9-client] Review request for bug JDK-8135176

2015-09-08 Thread Alexander Zvegintsev
looks fine. Thanks, Alexander. On 09/08/2015 02:24 PM, shilpi rastogi wrote: Hi all, Please review a bug fix Bug Link- https://bugs.openjdk.java.net/browse/JDK-8135176 http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev/ Thanks, Shilpi

Re: [9-client] Review request for bug JDK-8135176

2015-09-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2015 2:24 PM, shilpi rastogi wrote: Hi all, Please review a bug fix Bug Link- https://bugs.openjdk.java.net/browse/JDK-8135176 http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev/ Thanks, Shilpi

[9-client] Review request for bug JDK-8135176

2015-09-08 Thread shilpi rastogi
Hi all, Please review a bug fix Bug Link- https://bugs.openjdk.java.net/browse/JDK-8135176 http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev/ Thanks, Shilpi

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Alexander Scherbatiy
On 9/8/2015 2:06 PM, Semyon Sadetsky wrote: On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Semyon Sadetsky
On 9/8/2015 1:07 PM, Alexander Scherbatiy wrote: On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9/7/2015 5:08 PM, Semyon Sadetsky wrote: On

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Sergey Bylokhov
Hi, Prasanta. Just before the push of this fix I made small pit, and found a regression. Please run the SwingSet2, open JTable demo, and scroll the table. You will see some artifacts. On 08.09.15 13:13, prasanta sadhukhan wrote: Thanks Sergey for pointing this. I have taken care of this plus

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2015 1:26 PM, Sergey Bylokhov wrote: The fix looks good to me. On 08.09.15 13:13, prasanta sadhukhan wrote: Thanks Sergey for pointing this. I have taken care of this plus formatting in for loop. Please have a look http://cr.openjdk.j

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Sergey Bylokhov
The fix looks good to me. On 08.09.15 13:13, prasanta sadhukhan wrote: Thanks Sergey for pointing this. I have taken care of this plus formatting in for loop. Please have a look http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.04/ Regards Prasanta On 9/8/2015 3:32 PM, Sergey Bylokhov wrot

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread prasanta sadhukhan
Thanks Sergey for pointing this. I have taken care of this plus formatting in for loop. Please have a look http://cr.openjdk.java.net/~psadhukhan/8081491/webrev.04/ Regards Prasanta On 9/8/2015 3:32 PM, Sergey Bylokhov wrote: Hi, Prasanta. A few small notes: - BasicTableUI: typo "1850 // other

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Alexander Scherbatiy
On 9/8/2015 12:48 PM, Semyon Sadetsky wrote: On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9/7/2015 5:08 PM, Semyon Sadetsky wrote: On 9/7/2015 2:41 PM, Alexander Scherbatiy wrote: On 9

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Sergey Bylokhov
Hi, Prasanta. A few small notes: - BasicTableUI: typo "1850 // otherwise 1 extra rows are ptinted" - ImageableAreaTest: the test instructions have copy pasted numbers 1/2/2/2 etc. On 08.09.15 12:43, prasanta sadhukhan wrote: Thanks for your review. I need +1 for this. Alexander Z/Sergey,

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Semyon Sadetsky
On 9/8/2015 12:26 PM, Alexander Scherbatiy wrote: On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9/7/2015 5:08 PM, Semyon Sadetsky wrote: On 9/7/2015 2:41 PM, Alexander Scherbatiy wrote: On 9/4/2015 9:00 PM, Semyon Sadetsky wrote: On

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread prasanta sadhukhan
Thanks for your review. I need +1 for this. Alexander Z/Sergey, can you please approve this fix? Regards Prasanta On 9/8/2015 3:02 PM, Alexander Scherbatiy wrote: The fix looks good to me. But you need to properly format spaces in the 'for' loop on line TablePrintable:410 before the push

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread Alexander Scherbatiy
The fix looks good to me. But you need to properly format spaces in the 'for' loop on line TablePrintable:410 before the push. Thanks, Alexandr. On 9/8/2015 12:26 PM, prasanta sadhukhan wrote: On 9/7/2015 5:50 PM, Alexander Scherbatiy wrote: On 9/7/2015 9:23 AM, prasanta sadhukha

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Alexander Scherbatiy
On 9/8/2015 11:28 AM, Semyon Sadetsky wrote: On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9/7/2015 5:08 PM, Semyon Sadetsky wrote: On 9/7/2015 2:41 PM, Alexander Scherbatiy wrote: On 9/4/2015 9:00 PM, Semyon Sadetsky wrote: On 9/4/2015 6:11 PM, Alexander Scherbatiy wrote: On 9/3

Re: RFR: [9] [JDK-8081491] The case print incomplete.

2015-09-08 Thread prasanta sadhukhan
On 9/7/2015 5:50 PM, Alexander Scherbatiy wrote: On 9/7/2015 9:23 AM, prasanta sadhukhan wrote: I guess it will be same but anyways have modified to use visibleBounds.getLocation() to be on safeside as we are dealing with visible region for this fix. Please review the updated webrev http://c

Re: Request for review fo bug JDK-8032568 Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows virtual hosts

2015-09-08 Thread Rajeev Chamyal
Hello All, I need one more review for this fix. Can someone please review it. Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: Tuesday, September 08, 2015 2:27 PM To: Rajeev Chamyal Cc:

Re: Request for review fo bug JDK-8032568 Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows virtual hosts

2015-09-08 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2015 11:25 AM, Rajeev Chamyal wrote: Hello All, Please review the below webrev. http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: Mon

Re: [9] Review Request for 8030702: Deadlock between subclass of AbstractDocument and UndoManager

2015-09-08 Thread Semyon Sadetsky
On 9/7/2015 5:56 PM, Alexander Scherbatiy wrote: On 9/7/2015 5:08 PM, Semyon Sadetsky wrote: On 9/7/2015 2:41 PM, Alexander Scherbatiy wrote: On 9/4/2015 9:00 PM, Semyon Sadetsky wrote: On 9/4/2015 6:11 PM, Alexander Scherbatiy wrote: On 9/3/2015 10:01 PM, Semyon Sadetsky wrote: On 8

Re: Request for review fo bug JDK-8032568 Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows virtual hosts

2015-09-08 Thread Rajeev Chamyal
Hello All, Please review the below webrev. http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Alexander Scherbatiy Sent: Monday, September 07, 2015 6:21 PM To: Rajeev Chamyal Cc: Philip Race; Alexander Zvegintsev; swing-de