Re: JDK9 Review Request for 8067660: JFileChooser create new folder fails silently

2015-11-25 Thread Alexandr Scherbatiy
19.11.2015 13:09, Rajeev Chamyal ?: Hello All, Please review the following fix for Jdk9: Bug:https://bugs.openjdk.java.net/browse/JDK-8067660 Webrev:http://cr.openjdk.java.net/~rchamyal/8067660/webrev.00/ Issue: jFileChoose

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2015-11-25 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.02 The javadoc references for the #drawStringUnderlineCharAt and #getClippedString methods are moved after parameters description. Thanks, Alexandr. 14.09.2015 17:39, Alexander Scherbatiy пишет:

Re: Tool to display Swing control hierarchy

2015-11-25 Thread Sergey Bylokhov
Note that in jdk9 this option is disabled by default, to enable it you should pass -Dsun.awt.nativedebug=true to the java. On 25.11.15 10:03, Andrej Golovnin wrote: Hi Pete, start your Swing application from the console. When you application is started and has focus, then press CTRL-SHIFT-F1.

Re: JDK9 Review Request for 8067660: JFileChooser create new folder fails silently

2015-11-25 Thread Rajeev Chamyal
  Hello Alexandr,   Thanks for the review. I think other reason apart from access denied could be lack of space on device/drive. The API documentation for File.mkdirs is not very clear on reasons when the method will return false. Returns: true if and only if the directory was created, alo

Re: Tool to display Swing control hierarchy

2015-11-25 Thread Andrej Golovnin
On Wed, Nov 25, 2015 at 2:24 PM, Sergey Bylokhov wrote: > Note that in jdk9 this option is disabled by default, to enable it you > should pass -Dsun.awt.nativedebug=true to the java. Sergey, thank you for the hint! I didn't know that. Best regards, Andrej Golovnin

Re: Review request for 8133039 Provide public API to sun.swing.UIAction#isEnabled(Object)

2015-11-25 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 11/24/2015 04:54 PM, Sergey Bylokhov wrote: Looks fine. On 20.11.15 17:01, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8133039/webrev.02/ The description that accept() method must return false for