Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

Hi, Avik. Looks fine to me. It seems that the cast here is not necessary? if (o != (ComponentOrientation) e.getOldValue()) Can you confirm that this bug not affectes our other looks and feels? It will be good to update the test to prove that. On 17/12/15 10:21, Avik Niyogi wrote: Hi All, K

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

Hi, Rajeev. I still review the code, But I would like to clarify: should we do the similar fix for the maximize property as well, or it works? On 18/12/15 11:44, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-4769772

Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-4769772 Webrev: http://cr.openjdk.java.net/~rchamyal/4769772/webrev.00/ Issue: Iconifying a frame before adding it to desktop pane is not working. Cause: Setting setIcon property of a JI