Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-28 Thread Alexey Ivanov
Hi Rajeev, Thank you for updating the code and the test. Please see my comments inline. On 28.12.2015 10:37, Rajeev Chamyal wrote: Hello Alexey, Thanks for the review. I have updated the code as suggested. http://cr.openjdk.java.net/~rchamyal/4769772/webrev.02/ Please see response to

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-28 Thread Alexey Ivanov
Hi Rajeev, The updated version looks good to me. Regards, Alexey On 28.12.2015 16:25, Rajeev Chamyal wrote: Hello Alexey, Thanks for the review. I have updated the code. http://cr.openjdk.java.net/~rchamyal/4769772/webrev.03/ 1) I suggest moving these lines: if (c == null ||

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

2015-12-28 Thread Sergey Bylokhov
Hi, Avik On 21/12/15 07:17, Avik Niyogi wrote: Hi Sergey, I verified that the issue is only with Aqua Look and feel and not other look and feels. It will be better to prove it in the test, so the bug will not occur again in some other/new L The type cast for ComponentOrientation was done

Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state

2015-12-28 Thread Rajeev Chamyal
Hello Alexey, Thanks for the review. I have updated the code. http://cr.openjdk.java.net/~rchamyal/4769772/webrev.03/ 1) I suggest moving these lines: if (c == null || d == null) { return; } above calculations of desktopIcon position. Why shall we