Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

2015-12-30 Thread Rajeev Chamyal
Hello Sergey, I have updated the webrev. http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 29 December 2015 19:48 To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev@openjdk.java.net

Re: Review request for JDK-8145060 Minimizing a JInternal frame not shifting focus to frame below it

2015-12-30 Thread Sergey Bylokhov
Looks fine. On 30/12/15 11:03, Rajeev Chamyal wrote: Hello Sergey, I have updated the webrev. http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 29 December 2015 19:48 To: Rajeev Chamyal; Alexander

Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

2015-12-30 Thread Sergey Bylokhov
Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need