Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 3/21/2016 10:56 PM, Sergey Bylokhov wrote: On 21.03.16 22:30, Semyon Sadetsky wrote: On 3/21/2016 10:20 PM, Sergey Bylokhov wrote: On 21.03.16 22:00, Semyon Sadetsky wrote: But for example getEnabledGtkVersion() is called in the XDesktopPeer.java also. Note that XDesktopPeer and

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 21.03.16 22:30, Semyon Sadetsky wrote: On 3/21/2016 10:20 PM, Sergey Bylokhov wrote: On 21.03.16 22:00, Semyon Sadetsky wrote: But for example getEnabledGtkVersion() is called in the XDesktopPeer.java also. Note that XDesktopPeer and UnixToolkit synchronized differently but but tries to

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 3/21/2016 10:20 PM, Sergey Bylokhov wrote: On 21.03.16 22:00, Semyon Sadetsky wrote: But for example getEnabledGtkVersion() is called in the XDesktopPeer.java also. Note that XDesktopPeer and UnixToolkit synchronized differently but but tries to init gtk. It will be safer to remove this

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 21.03.16 22:00, Semyon Sadetsky wrote: But for example getEnabledGtkVersion() is called in the XDesktopPeer.java also. Note that XDesktopPeer and UnixToolkit synchronized differently but but tries to init gtk. It will be safer to remove this possible missconfiguration. XDesktopPeer loads GTK

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 3/21/2016 4:52 PM, Sergey Bylokhov wrote: On 21.03.16 16:26, Semyon Sadetsky wrote: On 3/19/2016 6:49 PM, Sergey Bylokhov wrote: On 18.03.16 15:37, Semyon Sadetsky wrote: On 3/17/2016 2:46 PM, Sergey Bylokhov wrote: Small notes: - It will be good to move the code which reads the

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

We could do that for our own filters, but any random custom filter could run into the same issue, so it might not make sense to upgrade the existing filter mechanism to always attempt to do MR filtering. We could either create a parallel set of MR-aware filter mechanisms (such as the

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

On 3/21/2016 8:09 PM, Sergey Bylokhov wrote: On 21.03.16 19:46, Semyon Sadetsky wrote: yes. This a generic code issue. It is failed on OSX even after the fix, please double check. This problem is unrelated to the current issue. I have filed a separate bug:

Re: CFV: New Swing Group Member: Semyon Sadetsky

Vote: yes -- Thanks, Alexander. On 21.03.2016 9:01, Alexander Scherbatiy wrote: I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

On 21.03.16 19:46, Semyon Sadetsky wrote: yes. This a generic code issue. It is failed on OSX even after the fix, please double check. On 3/17/2016 6:55 PM, Sergey Bylokhov wrote: Does the test is passed on all platforms? On 17.03.16 17:37, Semyon Sadetsky wrote: Hello, Please review

Re: [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

yes. This a generic code issue. On 3/17/2016 6:55 PM, Sergey Bylokhov wrote: Does the test is passed on all platforms? On 17.03.16 17:37, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8146301 webrev:

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

The one more thing is that image filters should also be updated to use them with multi-resolution images. For example, consider the case: -- Image mrImage = getMultiResolutionImage(); ImageProducer mriProducer = new FilteredImageSource(mrImage.getSource(), new

Re: [9] Review request for 8152159 LabelUI is not updated for TitledBorder

Looks good. --Semyon On 3/18/2016 9:29 PM, Alexander Scherbatiy wrote: On 18/03/16 19:40, Semyon Sadetsky wrote: Hi Alexander, Maybe it would be more optimal to update UI in a property change listener added to the UIManager? public void propertyChange(PropertyChangeEvent e) {

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi, Avik. How this test can fail? I do not see any raised exceptions? On 21.03.16 9:46, Avik Niyogi wrote: Hi Sergey, Please review the following code change. With Regards, Avik Niyogi On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy

Re: [9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

Should the test also cover the html based string(and cover the changes in HTMLDocument)? On 16.03.16 21:06, Alexander Scherbatiy wrote: The fix looks good to me. Just a small comment: if it is a new test it probably should not contain 1998 year in the copyright. Thanks, Alexandr. On

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi, Avik. How this test can fail? I do not see any raised exceptions. On 21.03.16 9:46, Avik Niyogi wrote: Hi Sergey, Please review the following code change. With Regards, Avik Niyogi On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

On 18/03/16 19:49, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.08/ - Public TextUIDrawing interface is added to the javax.swing.plaf package - TextUIDrawing methods description does not mention component properties

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

On 21.03.16 8:12, Avik Niyogi wrote: Hi Sergey, https://bugs.openjdk.java.net/browse/JDK-8151282 is open and in progress. How the this test(JProgressBarOrientationRobotTest) is related to JDK-8151282? With Regards, Avik Niyogi On 19-Mar-2016, at 4:52 pm, Sergey Bylokhov

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

The fix looks good to me. Thanks, Alexandr. On 21/03/16 18:02, Sergey Bylokhov wrote: Looks fine then. On 18.03.16 8:46, Avik Niyogi wrote: Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Looks fine then. On 18.03.16 8:46, Avik Niyogi wrote: Hi Sergey, I have tested the test cases as mentioned. 1) They are not related to the current fix 2) ScreenMenuBarInputTwice.java issue is not reproducible. 3) There is a test bug in ActionListenerCalledTwiceTest.java, hence a new test case

Re: Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

Hi, Prem. In the test the Swing components accessed on non-EDT thread. Probably the test can be simplified further? On 21.03.16 11:20, Prem Balakrishnan wrote: Hi*,* Please review fix for JDK 9, *Bug: *https://bugs.openjdk.java.net/browse/JDK-6439354 ** *Webrev:

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 21.03.16 16:26, Semyon Sadetsky wrote: On 3/19/2016 6:49 PM, Sergey Bylokhov wrote: On 18.03.16 15:37, Semyon Sadetsky wrote: On 3/17/2016 2:46 PM, Sergey Bylokhov wrote: Small notes: - It will be good to move the code which reads the system properties to the static init block,

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Please take a look to my comment below before pushing this fix. On 14.03.16 16:18, Sergey Bylokhov wrote: Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java

Re: Review-request for 8145547: JEP 283: [AWT/Swing] Conditional support for GTK 3 on Linux

On 3/19/2016 6:49 PM, Sergey Bylokhov wrote: On 18.03.16 15:37, Semyon Sadetsky wrote: On 3/17/2016 2:46 PM, Sergey Bylokhov wrote: Small notes: - It will be good to move the code which reads the system properties to the static init block, otherwise we can be in trouble if these properties

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Avik, Changes looks good to me. Regards, Manajit > On 21-Mar-2016, at 4:16 pm, Rajeev Chamyal wrote: > > Test code looks good to me. > > Regards, > Rajeev Chamyal > > From: Avik Niyogi > Sent: 21 March 2016 14:02 > To: Manajit Halder; Alexander Scherbatiy >

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Test code looks good to me.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 21 March 2016 14:02 To: Manajit Halder; Alexander Scherbatiy Cc: swing-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi All, Please review the below code changes as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/ With Regards, Avik Niyogi > On 21-Mar-2016, at 12:45 pm, Rajeev Chamyal wrote: >

Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

Hi, Please review fix for JDK 9, Bug: https://bugs.openjdk.java.net/browse/JDK-6439354 Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.00/ Issue: Win L: TitledBorder colors are not from desktop Cause: "TitledBorder.border" is set to EtchedBorder with default

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hello Avik,   I can’t comment on objective C code. As far as test is concerned below are my comments.   1)  UI should be created in Swing thread. 2)  Switch case in  actionPerformed should be refactored.   Regards, Rajeev Chamyal   From: Avik Niyogi Sent: 21 March 2016 12:20

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Manajit, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:20 pm, Avik Niyogi wrote: > > Hi Rajeev, > Please review the following code changes. > > With Regards, > Avik Niyogi >> On 21-Mar-2016, at 12:17 pm, Avik Niyogi

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Rajeev, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:17 pm, Avik Niyogi wrote: > > Hi Sergey, > > Please review the following code changes. > With Regards, > Avik Niyogi >> On 17-Mar-2016, at 7:03 pm, Alexander

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, Please review the following code changes. With Regards, Avik Niyogi > On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy > wrote: > > > The fix looks good to me. > > Just a small note: it is better to remove comment "527 //" since it > does

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi Sergey, Please review the following code change. With Regards, Avik Niyogi > On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy > wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 14/03/16 16:25, Avik Niyogi wrote: >> Hi All, >> Please review

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, This bug fix has been committed and resolved. Does not require a review. With Regards, Avik Niyogi > On 21-Mar-2016, at 10:42 am, Avik Niyogi wrote: > > Hi Sergey, > https://bugs.openjdk.java.net/browse/JDK-8151282 >

CFV: New Swing Group Member: Semyon Sadetsky

I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race condition improvement, UndoManager deadlock resolving, proposing and implementation a