Re: [9] Review Request for several test bugs: 8150535, 8151033, 8151037 etc.

Sergey, I'm sorry, filing JDK-8152693, I found an error in that version. A new one is http://cr.openjdk.java.net/~yan/8150535/webrev.02 The spawned processes were provided with addExports. Shame on me! -yan On 03/24/2016 05:34 PM, Sergey Bylokhov wrote: cc swing-dev On 24.03.16 17:17, Yuri

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

On 24.03.16 16:52, Alexander Scherbatiy wrote: On 24/03/16 10:36, Semyon Sadetsky wrote: Hi Alexander, Could you answer one question: Why did you choose default interface methods to implement TextUIDrawing and not implement them in DefaultTextUIDrawing having declarations only in the

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

On 24/03/16 10:36, Semyon Sadetsky wrote: Hi Alexander, Could you answer one question: Why did you choose default interface methods to implement TextUIDrawing and not implement them in DefaultTextUIDrawing having declarations only in the interface? AFAIK the common point of view is default

Re: Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

+1 thanks. On 22.03.16 11:56, Prem Balakrishnan wrote: Hi Sergey, Updated test as per the review comments. Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.01/ Regards, Prem -Original Message- From: Sergey Bylokhov Sent: Monday, March 21, 2016 7:31 PM To: Prem

Re: CFV: New Swing Group Member: Semyon Sadetsky

Vote: yes. Thanks, Alexandr. On 21/03/16 10:01, Alexander Scherbatiy wrote: I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to Membership in the Swing Group. Semyon is active member of Swing group and contributed a lot of fixes which include Swing TimerQueue race

[9] JDK-8049069 : JButton incorrect behaviour on button release

Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8049069 Issue : A JButton which is pressed using left mouse button gets released if right mouse button is pressed and released. Root cause : --- In file BasicButtonListener.java, mousePressed() and mouseReleased() methods check

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hi Rajeev, The fix looks fine to me. With Regards, Avik Niyogi -Original Message- From: Rajeev Chamyal Sent: 23 March 2016 14:45 To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Review request for JDK-8150225

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Looks good to me. Regards, Rajeev Chamyal From: Avik Niyogi Sent: 24 March 2016 12:54 To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs Hi

Re: Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Semyon Sadetsky Sent: 24 March 2016 11:45 To: Prem Balakrishnan; Sergey Bylokhov; Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Review Request for 6439354 : Win L: TitledBorder colors are

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Please review code changes as per inputs received. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.03 As SCROLL_TAB_LAYOUT is the default layout for Aqua LAF, with implementation within the derived

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hello Avik, x variable on line 2195 is not used anywhere. Do we need for loop also? Regards, Rajeev Chamyal From: Avik Niyogi Sent: 24 March 2016 12:19 To: Alexander Scherbatiy Cc: Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review Request of 8137169 :

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi All, Please review my code changes below as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8137169/webrev.02/ As SCROLL_TAB_LAYOUT is the default layout for Aqua LAF, with implementation within the derived

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Hi Alexander, Could you answer one question: Why did you choose default interface methods to implement TextUIDrawing and not implement them in DefaultTextUIDrawing having declarations only in the interface? AFAIK the common point of view is default methods should be used rarely because they

Re: Review Request for 6439354 : Win L: TitledBorder colors are not from desktop

Looks good. --Semyon On 3/22/2016 11:56 AM, Prem Balakrishnan wrote: Hi Sergey, Updated test as per the review comments. Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.01/ Regards, Prem -Original Message- From: Sergey Bylokhov Sent: Monday, March 21, 2016 7:31 PM