Hi Volker,
1) adding awt-dev. Semyon did the review on swing but really it should
always
(and mainly!) have been awt.
2) Yes, this ought to be pushed to 9-client, specifically not 9-dev.
Assuming it goes to 9-dev we may need to deal with conflicts.
Also if it causes any kind of problem with
Looks fine to me.
On 04.05.16 21:32, Volker Simonis wrote:
Hi,
can somebody please review this small change which fixes the AIX build
after change 8145547, but also fixes an incorrect usage pattern of
RTLD_NOLOAD in 8145547:
http://cr.openjdk.java.net/~simonis/webrevs/2016/8156020/
30 # @requires os.family == "linux"
That and the test is very linux centric. Does it need to run on Solaris too ?
Whilst that may only have gtk2 (not sure about S12) we should still test.
-phil.
On 05/05/2016 07:23 AM, Yuri Nesterenko wrote:
Colleagues,
could you please review the tests
Colleagues,
could you please review the tests for the new jdk.gtk.version property?
Webrev is http://cr.openjdk.java.net/~yan/8156128/webrev.00/
CR is https://bugs.openjdk.java.net/browse/JDK-8156128
A couple of interesting scenarios would require some system preparation
(read: hacks) and are
The code change looks fine, a few notes about the test:
- The empty catch block "catch (Exception e) {}, it will be better to
re-throw an exception.
- "frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE)" can cause a
test failure in some jtreg modes(see JDK-8154365)
- Is it necessary to
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.01/
Update: Added the check Icon install code in installDefaults to a private
method. Calling same method on propertychange.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey
On 05.05.16 14:11, Alexandr Scherbatiy wrote:
Note that the component GConfig is not necessary the config which is
used in drawing, and can be different from the GConfig of Graphics
passed to the paint() method.
This is still necessary change for the components size calculation
where
On 5/5/2016 12:55 PM, Sergey Bylokhov wrote:
On 05.05.16 8:42, Alexandr Scherbatiy wrote:
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8142966
webrev: http://cr.openjdk.java.net/~alexsch/8142966/webrev.02
This is the initial fix where graphics configuration
On 05.05.16 8:42, Alexandr Scherbatiy wrote:
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8142966
webrev: http://cr.openjdk.java.net/~alexsch/8142966/webrev.02
This is the initial fix where graphics configuration transform is
included into the Swing font
