Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

As I indicated in my previous message, that approach does not appear to work for my needs as the flag is only tested if the first attempt fails. My goal is to create by subclassing a particular factory instance that always creates heavy weight popups regardless of anything that an application

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

I use only heavy weight. > On May 10, 2016, at 12:46 PM, Alexandr Scherbatiy > wrote: > > > Do you need to use medium-weight popups in your application or > light/heavy-weight popups are enough? > > Thanks, > Alexandr. > > On 5/10/2016 10:23 PM, Alan Snyder

Re: [9] Review request for 8154431: Allow source and target based validation for the focus transfer between two JComponents.

On 04/22/2016 01:11 AM, Semyon Sadetsky wrote: Forget to attach the link: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.01/ --Semyon On 4/22/2016 11:08 AM, Semyon Sadetsky wrote: Please review the updated webrev: 32 * need to ensure that the components are in valid state before

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Hello All, Please let me know your thoughts on the below webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.02/ This approach is similar to Aqua as suggested by Sergey. Regards, Rajeev Chamyal -Original Message- From: Alexandr Scherbatiy Sent: 11 May 2016 01:16 To: Alan

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Do you need to use medium-weight popups in your application or light/heavy-weight popups are enough? Thanks, Alexandr. On 5/10/2016 10:23 PM, Alan Snyder wrote: On May 10, 2016, at 5:58 AM, Sergey Bylokhov wrote: Hi, Alan. Can you please take a look to the

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

> On May 10, 2016, at 5:58 AM, Sergey Bylokhov > wrote: > > Hi, Alan. > Can you please take a look to the proposed solutions? Thanks. > > Approach 2 matches what I currently do. The problem noted by Rajeev does not happen because my popup factory calls

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

On 10.05.16 17:36, Alexandr Scherbatiy wrote: Since both of these methods are public I am not sure how it will solve the initial requested problem: enable HW popup w/o possibility of change it by the user's code? I believe that a user can do something like: -- JPopupMenu

Re: [9] Review request for 8046031: UI of Java Web Start app isn't updated when changing Windows theme

On 4/28/2016 7:46 PM, Sergey Bylokhov wrote: On 28.04.16 19:30, Semyon Sadetsky wrote: ok, then just make the new field private and do not use the interned string as a key. Why do you think it should be private? This flag may be used as a sign of the upcoming global UI update. Because

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

I noticed following problem with the current webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.01/ If we don't override the BasicPopupMenuUI :: getPopup method and use the below code for displaying popup. JPopupMenu jpopup = new JPopupMenu(); PopupFactory popupFactory =

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

On 5/10/2016 3:05 PM, Sergey Bylokhov wrote: Since both of these methods are public I am not sure how it will solve the initial requested problem: enable HW popup w/o possibility of change it by the user's code? I believe that a user can do something like: -- JPopupMenu

Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

On 10.05.16 9:54, Alexandr Scherbatiy wrote: If a backbuffer has scale 1 on HiDPI display it will show a blurry text and some other artifacts like that. I believe it should have HiDPI scale. The fix only aligns the Swing font rendering context with the same transform scale. It will be

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Since both of these methods are public I am not sure how it will solve the initial requested problem: enable HW popup w/o possibility of change it by the user's code? On 10.05.16 14:49, Alexandr Scherbatiy wrote: What should be results of the PopupFactory.setHeavyWeightPopupEnabled(false)

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

On 5/10/2016 2:36 PM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.01/ Update : Implemented review comments. What should be results of the

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.01/ Update : Implemented review comments. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 10 May 2016 16:07 To: Rajeev Chamyal; Sergey Bylokhov;

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

On 5/10/2016 1:10 PM, Rajeev Chamyal wrote: Hello Alexandr, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.00/ Updates: Added a boolean field heavyWeightPopupEnabled

Re: RFR(S): 8156020: 8145547 breaks AIX and and uses RTLD_NOLOAD incorrectly

Hi Volker, I did not answer you because I was on leave. Thank you for your attention to the problem. It looks like that you found the issue we could not find. For some reason I thought that RTLD_NOLOAD and RTLD_LAZY flags are mutually excluded, and unfortunately the reviewers did not notice

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

Hi Semyon, On 05/10/2016 12:14 PM, Semyon Sadetsky wrote: Hi Yuri, When GTK3 is available but GTK2 not, what result do you expect from running the DemandGTK2.sh? Since it sets jdk.gtk.version to 2 it will never be successful without GTK2. If it is aimed to test the automatic GTK3 failover

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

Hello Alexandr, Thanks for the review. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.00/ Updates: Added a boolean field heavyWeightPopupEnabled and corresponding property methods. Applications can set this property to true for forcing popup to be

Re: [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

Hi Yuri, When GTK3 is available but GTK2 not, what result do you expect from running the DemandGTK2.sh? Since it sets jdk.gtk.version to 2 it will never be successful without GTK2. If it is aimed to test the automatic GTK3 failover the jdk.gtk.version preference should not be set.

Re: [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

On 5/5/2016 2:24 PM, Sergey Bylokhov wrote: On 05.05.16 14:11, Alexandr Scherbatiy wrote: Note that the component GConfig is not necessary the config which is used in drawing, and can be different from the GConfig of Graphics passed to the paint() method. This is still necessary change

Re: Review Request JDK-6421058: When calls JSpinner.setEditor() the font in a JSpinner become is a bold

The fix looks good to me. Thanks, Alexandr. On 5/9/2016 8:52 AM, Prem Balakrishnan wrote: Hi Sergey, Thankyou for the Review. http://cr.openjdk.java.net/~pkbalakr/6421058/webrev.01/ Updated patch as per review comments. [mainFrame.dispose(), by mistake I missed to uncomment which was

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

The first approach implies that a user should change all PopupFactory.getPopup(owner, contents, x, y) calls to OverridenPopupFactory.getPopup(owner, contents, x, y, true) to get a heavy-weight popup in his code. The second one looks better to me. It may have sense to restrict it only to 2