Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-16 Thread Alexandr Scherbatiy
On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: Hi, we have test machines without X server. On these many of the jdk jtreg tests fail with a headless exception. We grepped for this exception in the test output and identified about 450 tests. In these tests, we added with another script "@ke

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-06-16 Thread Alexandr Scherbatiy
On 6/16/2016 4:47 PM, Alexandr Scherbatiy wrote: I tried to look deeper in the code and it seems there is a rounding issue when float values are summed up. Suppose a transform with scale 1.5 is used and the 'a' char advance is 10 in a dev space. The 'a' char has advance 10 / 1.5 = 6.

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-16 Thread Volker Simonis
Hi Goetz, the change looks good. Thanks for doing this Sisyphean task! We should nevertheless wait for another review from somebody from the AWT/Swing team. Regards, Volker On Thu, Jun 16, 2016 at 4:40 PM, Lindenmaier, Goetz wrote: > Hi, > > > > we have test machines without X server. On thes

RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-16 Thread Lindenmaier, Goetz
Hi, we have test machines without X server. On these many of the jdk jtreg tests fail with a headless exception. We grepped for this exception in the test output and identified about 450 tests. In these tests, we added with another script "@key headful". So that the script generates better output

Re: [9] Fix for JDK-8041909 : Uncaught exceptions in JComboBox listeners cause listener not to receive events

2016-06-16 Thread Alexandr Scherbatiy
Just two small comments: - JComboBox line 1256 and 1257: the 'finally' keyword should be on the same line as open bracket - ActionListenerExceptionTest.test() method: all calls to Swing objects should be done on EDT Thanks, Alexandr. On 6/15/2016 10:05 AM, Ajit Ghaisas wrote: Hi, Bug :

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-06-16 Thread Alexandr Scherbatiy
I tried to look deeper in the code and it seems there is a rounding issue when float values are summed up. Suppose a transform with scale 1.5 is used and the 'a' char advance is 10 in a dev space. The 'a' char has advance 10 / 1.5 = 6.667 as double value and 6.665 when it is

Re: Background is painted taller than needed for superscripted text

2016-06-16 Thread Alexandr Scherbatiy
- Could you add the bug id to the email subject? - Before the fix the superscript background color was filled till the previous line. After the fix there is a gap between the line above and the superscripted text. See the screenshots: http://cr.openjdk.java.net/~alexsch/8017266/supersc