RfR JDK-8145207 [macosx] JList, VO can't access non-visible list items

2016-06-17 Thread Pete Brunet
Please review the following patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8145207 Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.00/ This fixes the following functionality that was not working with the JList of ListDemo of SwingSet2. - start VoiceOver - start SwingSet2 -

Re: [9] Fix for JDK-8041909 : Uncaught exceptions in JComboBox listeners cause listener not to receive events

2016-06-17 Thread Sergey Bylokhov
+1 On 17.06.16 15:55, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 6/17/2016 2:03 PM, Ajit Ghaisas wrote: Thanks Alex for the review. Here is the updated webrev : http://cr.openjdk.java.net/~aghaisas/8041909/webrev.01/ Request you to review. Regards, Ajit

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Lindenmaier, Goetz
Hi Sergey, Sorry, I pushed it just now! If you (or anybody else) has any objections I can revert this or do a follow-up to correct it. Please let me know. Best regards, Goetz. > -Original Message- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Freitag, 17.

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Sergey Bylokhov
I guess that 2d team should review it as well (cc) On 17.06.16 17:17, Lindenmaier, Goetz wrote: Hi Alexandr, Thanks for reviewing! Best regards, Goetz. -Original Message- From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com] Sent: Freitag, 17. Juni 2016 16:04 To:

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Lindenmaier, Goetz
Hi Alexandr, Thanks for reviewing! Best regards, Goetz. > -Original Message- > From: Alexandr Scherbatiy [mailto:alexandr.scherba...@oracle.com] > Sent: Freitag, 17. Juni 2016 16:04 > To: Volker Simonis > Cc: Lindenmaier, Goetz ;

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Volker Simonis
On Fri, Jun 17, 2016 at 3:40 PM, Alexandr Scherbatiy wrote: > On 6/17/2016 4:17 PM, Lindenmaier, Goetz wrote: >> >> Hi Alexandr, >> >> yes, you are right, the test you mention is missing in this change. >> There are others, too, and we still have lots of failures

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Alexandr Scherbatiy
On 6/17/2016 4:17 PM, Lindenmaier, Goetz wrote: Hi Alexandr, yes, you are right, the test you mention is missing in this change. There are others, too, and we still have lots of failures for other reasons. We are currently working on getting all the tests green in our test environment where we

Re: [9] Fix for JDK-8041909 : Uncaught exceptions in JComboBox listeners cause listener not to receive events

2016-06-17 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/17/2016 2:03 PM, Ajit Ghaisas wrote: Thanks Alex for the review. Here is the updated webrev : http://cr.openjdk.java.net/~aghaisas/8041909/webrev.01/ Request you to review. Regards, Ajit -Original Message- From: Alexandr Scherbatiy

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Alexandr Scherbatiy
On 6/17/2016 11:36 AM, Volker Simonis wrote: On Thu, Jun 16, 2016 at 5:55 PM, Alexandr Scherbatiy wrote: On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: Hi, we have test machines without X server. On these many of the jdk jtreg tests fail with a headless

Re: [9] Fix for JDK-8041909 : Uncaught exceptions in JComboBox listeners cause listener not to receive events

2016-06-17 Thread Ajit Ghaisas
Thanks Alex for the review. Here is the updated webrev : http://cr.openjdk.java.net/~aghaisas/8041909/webrev.01/ Request you to review. Regards, Ajit -Original Message- From: Alexandr Scherbatiy Sent: Thursday, June 16, 2016 7:54 PM To: Ajit Ghaisas; Rajeev Chamyal; Sergey Bylokhov;

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Lindenmaier, Goetz
Hi Alexandr, > What is a number of tests which passe in headless mode? Do you mean you want to know wheter there are awt/swing tests that are passing in headless mode and if yes, how many? javax/swing: 223 passing sun/java2d: 34 passing java/awt:312 pasing > I would expect that an

Re: RFR(L): 8159690: [TESTBUG] Mark headful tests with @key headful.

2016-06-17 Thread Volker Simonis
On Thu, Jun 16, 2016 at 5:55 PM, Alexandr Scherbatiy wrote: > On 6/16/2016 5:40 PM, Lindenmaier, Goetz wrote: > > Hi, > > > > we have test machines without X server. On these many of the jdk > > jtreg tests fail with a headless exception. > > We grepped for this

Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doesn't work for iconified InternalFrame

2016-06-17 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8159152 Webrev: http://cr.openjdk.java.net/~rchamyal/8159152/webrev.00/ Issue: Internal frame cache is not getting updated properly on iconifyFrame if there are less than 3 frames on the