The test does not pass if mac specific check is not done for backgroundcolor.
The check is required to get the same values from BufferedImage as they are the
same as found with Digital Color Meter.
This test case fixes that.
Please provide inputs if this fix will get a +1 or if not any positive
I imagine this was all done to maximise performance.
Is there any impact on SwingMark - try D3D both on & off ..
The change here :
http://cr.openjdk.java.net/~alexsch/8160986/webrev.00/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalScrollButton.java.sdiff.html
appears to handle only
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8160986
webrev: http://cr.openjdk.java.net/~alexsch/8160986/webrev.00
The proposed fix changes icon shapes drawn by lines to ovals and
polygons for JRadioButton, JComboBox and JScrollBar components for the
Hello,
I got approval for the backport to JDK8 from Rob McKenna (see
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-July/005686.html).
The backport can just be applied after reshuffling the patch. Test succeeds
after applying the patch.
Note that for the reshuffling, you need to add the
On 7/7/2016 6:30 PM, Yuri Nesterenko wrote:
On 07/07/2016 06:15 PM, Semyon Sadetsky wrote:
On 7/7/2016 5:58 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:35 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:04 PM, Semyon Sadetsky wrote:
On 07.07.2016 16:35, Avik Niyogi wrote:
Hi Semyon,
On 07/07/2016 06:15 PM, Semyon Sadetsky wrote:
On 7/7/2016 5:58 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:35 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:04 PM, Semyon Sadetsky wrote:
On 07.07.2016 16:35, Avik Niyogi wrote:
Hi Semyon,
Thank you for the review comment.
In Mac OS X,
On 7/7/2016 5:58 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:35 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:04 PM, Semyon Sadetsky wrote:
On 07.07.2016 16:35, Avik Niyogi wrote:
Hi Semyon,
Thank you for the review comment.
In Mac OS X, *System Preferences > Displays > Colors > Display
Hi,
This change is 'L' because there are changes to a lot of files, but the changes
are all similar, so it's rather easy to review.
Similar to 8159690 I added @key headful to another around 600 tests.
I used different patterns to grep for the headful exceptions.
These are now all I could find
On 07/07/2016 05:35 PM, Yuri Nesterenko wrote:
On 07/07/2016 05:04 PM, Semyon Sadetsky wrote:
On 07.07.2016 16:35, Avik Niyogi wrote:
Hi Semyon,
Thank you for the review comment.
In Mac OS X, *System Preferences > Displays > Colors > Display
Profile* section, the default value is *Color
On 07.07.2016 16:35, Avik Niyogi wrote:
Hi Semyon,
Thank you for the review comment.
In Mac OS X, *System Preferences > Displays > Colors > Display
Profile* section, the default value is *Color LCD*.
This causes a failure in some test cases which uses robot.The colour
configuration it
Hi Semyon,
Thank you for the review comment.
In Mac OS X, System Preferences > Displays > Colors > Display Profile section,
the default value is Color LCD.
This causes a failure in some test cases which uses robot.The colour
configuration it expects to use is the Generic RGB Profile.
That is
Hi Avik,
could you clarify what is "Non-generic display settings"? Is it known
bug on OS X?
And also please be more specific on "negative scenarios" why they are
necessary ?
Also could you replace labeled break with "return foundMatch; "
--Semyon
On 07.07.2016 15:11, Avik Niyogi wrote:
+1
--
Thanks,
Alexander.
On 07/07/2016 12:51 PM, Semyon Sadetsky wrote:
Looks good to me.
--Semyon
On 07.07.2016 12:33, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8160879
webrev:
Vote: yes
--
Thanks,
Alexander.
On 06/23/2016 09:21 AM, Alexandr Scherbatiy wrote:
I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to
Membership in the Swing Group.
Sergey is active member of Swing group and contributed a lot of fixes
which include Aqua L, Retina support on
Hi Ajit,
one more thing that I have just noticed:
/**
* Flag to indicate UI update is in progress
*/
private boolean updateInProgress;
I think the field must be transient. In Swing every component is
serializable. When updateInProgress is set to true and you
serialize/deserialize the
Hi,
Thanks Rajeev and Andrej for the suggestions.
I have incorporated them in following webrev.
http://cr.openjdk.java.net/~aghaisas/6567433/webrev.02/
Regards,
Ajit
From: Rajeev Chamyal
Sent: Thursday, July 07, 2016 3:30 PM
To: Alexander Scherbatiy; Ajit Ghaisas;
Hello Ajit,
The fix looks fine to me.
Regarding test: JTable and JTree tests exceed 80 char limit.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 07 July 2016 15:17
To: Ajit Ghaisas; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: [9] Fix for JDK-6567433 :
Looks good to me.
--Semyon
On 07.07.2016 12:33, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8160879
webrev: http://cr.openjdk.java.net/~alexsch/8160879/webrev.00
VALUE_TEXT_ANTIALIAS_OFF should be used for the null
The fix looks good to me.
Thanks,
Alexandr.
On 7/7/2016 12:44 PM, Ajit Ghaisas wrote:
Hi,
Thanks Alex for pointing out there might be more components
showing similar behavior.
Two more components are identified which may cause this recursion
in UpdateUI() method – JTree and
Hi,
Thanks Alex for pointing out there might be more components showing similar
behavior.
Two more components are identified which may cause this recursion in
UpdateUI() method - JTree and JTable.
Now, total 5 components ( JComboBox, JList, JTree, JTable and
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8160879
webrev: http://cr.openjdk.java.net/~alexsch/8160879/webrev.00
VALUE_TEXT_ANTIALIAS_OFF should be used for the null antialiased hint
instead of VALUE_ANTIALIAS_OFF.
Thanks,
Alexandr.
The fix looks good to me.
Thanks,
Alexandr.
On 7/6/2016 10:03 PM, Semyon Sadetsky wrote:
On 7/6/2016 6:03 PM, Alexandr Scherbatiy wrote:
On 7/6/2016 4:13 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8058742
webrev:
22 matches
Mail list logo
