Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

2016-09-19 Thread Sergey Bylokhov
Looks fine. On 15.09.16 12:31, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165234/webrev.02 The closeOnMouseClick property is renamed to doNotCloseOnMouseClick with the default false value. The client property is

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

2016-09-19 Thread Alexandr Scherbatiy
On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

2016-09-19 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/16/2016 5:34 PM, Semyon Sadetsky wrote: On 15.09.2016 16:11, Alexander Scherbatiy wrote: On 15/09/16 15:03, Semyon Sadetsky wrote: On 15.09.2016 12:49, Alexandr Scherbatiy wrote: On 9/15/2016 11:47 AM, Semyon Sadetsky wrote: On

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

2016-09-19 Thread Alexandr Scherbatiy
This is the known issue: JDK-8163175 PlainView.modelToView() method should return Rectangle2D It is included into the fix JDK-8156217 Selected text is shifted on HiDPI display. You can apply the fix [1] JDK-8156217 to the JDK and try the proposed sample. I get the results [2] for scale 2x