Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-14 Thread Shashidhara Veerabhadraiah
Thank you Krishna and Sergey for the review. -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 3:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice/Choi

Re: Swing Dev> [12] RFR JDK-8213514: com/sun/java/swing/plaf/windows/Test8173145.java fails on mach5

2018-11-14 Thread Prasanta Sadhukhan
On 15-Nov-18 12:36 AM, Sergey Bylokhov wrote: Hi, Prasanta Could you please clarify how this "ClassCastException" is related to the "Wrong focus owner" which is reported in the bug? It is not related. It is there to cater to the problem seen in JDK-8198334: which btw I am not able to reprod

Re: FYI: new javadoc tag to document system properties

2018-11-14 Thread Joseph D. Darcy
Hello, For future CSR requests involving system properties, please document the properties using these javadoc facilities. Thanks, -Joe On 11/14/2018 2:27 PM, Jonathan Gibbons wrote: This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (

FYI: new javadoc tag to document system properties

2018-11-14 Thread Jonathan Gibbons
This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (JDK-5076751). Currently, system properties are just documented using ad-hoc narrative text, which is fine if you know where to look for any given property. JDK 12 introduces a new inlin

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

2018-11-14 Thread Sergey Bylokhov
Looks fine. -- Best regards, Sergey.

Re: Swing Dev> [12] RFR JDK-8213514: com/sun/java/swing/plaf/windows/Test8173145.java fails on mach5

2018-11-14 Thread Sergey Bylokhov
Hi, Prasanta Could you please clarify how this "ClassCastException" is related to the "Wrong focus owner" which is reported in the bug? Note that HeadlessGraphicsEnvironment does not implement DisplayChangedListener so the additional check for HeadlessGraphicsEnvironment is not necessary. On 13

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-11-14 Thread Alexey Ivanov
Hi Shashi, First of all, I must emphasize that Swing has always been and is accessible by design. Phil replied to that part already. I just wanted to reiterate the same statement. Please see my other comments inline: On 08/11/2018 17:10, shashidhara.veerabhadra...@oracle.com wrote: Hi Alexey

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018-11-14 Thread Alexey Ivanov
Hi Shashi, I absolutely agree with Sergey: the component must be accessible even if it's not focusable. And I don't quite understand what you're talking about. The person who uses an accessibility tool will use the shortcuts of the tool to navigate controls in the window. Tab key, on the ot

Re: [12] RFR JDK-8213844: Typo in ProblemList updation under JDK-8213536

2018-11-14 Thread Jayathirth D V
Changes are fine +1. Thanks, Jay From: Pankaj Bansal Sent: Wednesday, November 14, 2018 6:11 PM To: swing-dev@openjdk.java.net Subject: [12] RFR JDK-8213844: Typo in ProblemList updation under JDK-8213536 Hi All, Please review a fix for Typo done in ProblemList updation under http

[12] RFR JDK-8213844: Typo in ProblemList updation under JDK-8213536

2018-11-14 Thread Pankaj Bansal
Hi All, Please review a fix for Typo done in ProblemList updation under https://bugs.openjdk.java.net/browse/JDK-8213536. A colon ":" was added at end of test case javax/swing/border/TestTitledBorderLeak.java. The colon needs to be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-821