Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

2020-11-24 Thread Tejpal Rebari
> Please review the following fix for jdk16. > > Issue : There is a JToggleButton that will post/take down a JPopupMenu when > the button is selected. If the button is selected and the menu is not posted > the action listener will post the menu. If the button is selected and the > menu is

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-24 Thread Alan Snyder
On Nov 24, 2020, at 7:21 PM, Prasanta Sadhukhan wrote: > > On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov > wrote: > >>> Tried to find and change tabpane background color for "selected" tab but >>> unable to do so. >>> Tried changing

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-24 Thread Prasanta Sadhukhan
On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov wrote: >> Tried to find and change tabpane background color for "selected" tab but >> unable to do so. >> Tried changing AquaLookAndFeel.tabBackgroundColor, TabbedPane.background >> color to no avail. Tried to set background by calling >>

Re: RFR: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2

2020-11-24 Thread Prasanta Sadhukhan
On Sun, 22 Nov 2020 08:59:48 GMT, Sergey Bylokhov wrote: > The problem became visible, when we draw a border across the component using > drawLine, and expected that fillRect will clear a border of the component. > This is incorrect because in the case of the scaled graphics(retina) some >

RFR: 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails

2020-11-24 Thread Sergey Bylokhov
Here is a fix for one of the annoying bug, which causes random test failures in the CI. We have a method Robot.waitForIdle(), which supposed to wait until the java and the native queue stabilized. The common use case is to click on the button or show the window, and call waitForIdle() which

Re: RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Sergey Bylokhov
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. Marked as reviewed by serb (Reviewer). - PR:

Re: RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Phil Race
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. I tried this myself a few weeks ago and it was fine. - Marked as reviewed

RFR: 8253753 Enable default constructor warning in client modules

2020-11-24 Thread Joe Darcy
With the default constructors warnings in java.desktop and jdk.accessibility now fixed, the warning should be enabled in the build for those modules. - Commit messages: - Merge branch 'JDK-8253753' of https://github.com/jddarcy/jdk into JDK-8253753 - Update build to enable default

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

2020-11-24 Thread Sergey Bylokhov
On Tue, 24 Nov 2020 08:48:36 GMT, Prasanta Sadhukhan wrote: >> Then try to dig into it a little bit, probably a good reason to ask about >> the current font color in the tab at the Apple forum. > > Tried to find and change tabpane background color for "selected" tab but > unable to do so. >

Re: taskbar icon badge issue

2020-11-24 Thread Sergey Bylokhov
On 20.11.2020 06:56, Alan Snyder wrote: I don’t believe there is any bug here. It was there, and it was reported to Apple ID-7261735. Looks like this bug has a few fixes and the last update was that it could work in 10.15.5 beta 3. I'll take a look. Setting a badge on the app icon requires

Re: RFR: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2

2020-11-24 Thread Sergey Bylokhov
On Tue, 24 Nov 2020 11:00:42 GMT, Prasanta Sadhukhan wrote: >> The bug in the motif was fixed by the JDK-8032219, the code in the >> BasicSliderUI is never used by the Metal L, I tested that code by the >> commented out the overridden code in the MetalSliderUI. > > If the code in

Re: RFR: 8256019: JLabel HTML text does not support translucent text colors [v3]

2020-11-24 Thread Prasanta Sadhukhan
> Issue is a JLabel with a translucent foreground color properly renders plain > text, but with HTML text, the alpha component is discarded and the text is > rendered using an opaque color. > As per https://www.w3schools.com/cssref/func_rgba.asp, CSS supports rgba() to > support alpha and

Re: RFR: 8256019: JLabel HTML text does not support translucent text colors [v3]

2020-11-24 Thread Prasanta Sadhukhan
On Tue, 24 Nov 2020 04:58:37 GMT, Sergey Bylokhov wrote: >> The problem is the alpha color not being present in c.getForeground() so we >> need to parse alpha here to pass the value to displayPropertiesToCSS(). I >> have already mentioned it below. > > As far as I understand the only place

Re: RFR: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2

2020-11-24 Thread Prasanta Sadhukhan
On Tue, 24 Nov 2020 00:09:03 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java >> line 1618: >> >>> 1616: } >>> 1617: } >>> 1618: g.setClip(clip); >> >> Since it is normally seen in Metal L, shouldn't we do the