Withdrawn: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Prasanta Sadhukhan
On Fri, 4 Dec 2020 17:30:11 GMT, Prasanta Sadhukhan wrote: > Issue is when using a JEditorPane to render HTML views with W3C_UNIT_LENGTHS > enabled, font-sizes set using CSS are much larger than the same font size > outside the HTML. > It's because CSS LengthUnit uses screen resolution to

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Sergey Bylokhov
On Tue, 26 Jan 2021 14:36:09 GMT, Alexey Ivanov wrote: > I believe we're talking about javadoc spec: its text has not changed. > CSS spec is updated. Since you follow the rules of CSS 2.2, it's better to > link to CSS 2.2. No, I did not mean the JavaDoc, my question was - "what part of the CSS

Re: RFR: 8260314: Replace border="1" on tables with CSS [v3]

2021-01-26 Thread Sergey Bylokhov
On Tue, 26 Jan 2021 17:32:54 GMT, Alexey Ivanov wrote: >> Replace presentational attribute `border="1"` on `` element with CSS >> styles: >> table {border: outset 1px} >> th, td {border: inset 1px} >> >> These declarations produce the same rendering as the default one in Firefox >> and Edge.

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 19:17:24 GMT, Jonathan Gibbons wrote: > In general, I recommend where possible using the styles provided in the > standard stylesheet, for overall visual consistency. I totally agree. I overlooked the standard styles for the tables. Thanks to @mrserb for pointing me in

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Jonathan Gibbons
On Tue, 26 Jan 2021 18:33:48 GMT, Alexey Ivanov wrote: >>> Probably we can import the CSS used by the javadoc itself? >> >> We do. For example, [AWT Modality in JDK >> 15](https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/java/awt/doc-files/Modality.html) >> has borders because

Project Lanai (New Metal Java 2D Rendering pipeline for macOS) FINAL planned EA build has been released

2021-01-26 Thread Philip Race
All, The Lanai project has reached the stage where we are aiming to move the JEP [1] to Proposed-To-Target [2] to JDK 17 very soon. We have made one final planned EA release which includes all the latest fixes. So please visit https://jdk.java.net/lanai/ and download the EA 9 build and

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 17:34:04 GMT, Matthias Perktold wrote: > > You can create the new PR with comments addressed and link to the old PR in > > the description. > > Is there anything special I need to do to have "comments addressed"? Should I > first apply your patches, and then proceed with

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 15:39:30 GMT, Alexey Ivanov wrote: >> Probably we can import the CSS used by the javadoc itself? > >> Probably we can import the CSS used by the javadoc itself? > > We do. For example, [AWT Modality in JDK >

Integrated: 8260343: Delete obsolete classes in the Windows L

2021-01-26 Thread Sergey Bylokhov
On Mon, 25 Jan 2021 07:08:33 GMT, Sergey Bylokhov wrote: > Obsolete/unused classes are removed. This pull request has now been integrated. Changeset: 42cef27f Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/42cef27f Stats: 151 lines in 3 files changed: 48

Re: RFR: 8260314: Replace border="1" on tables with CSS [v3]

2021-01-26 Thread Alexey Ivanov
> Replace presentational attribute `border="1"` on `` element with CSS > styles: > table {border: outset 1px} > th, td {border: inset 1px} > > These declarations produce the same rendering as the default one in Firefox > and Edge. > > Another option is to use `solid` in both cases. Alexey

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Matthias Perktold
On Tue, 26 Jan 2021 16:41:52 GMT, Alexey Ivanov wrote: > I see you opened the PR from master branch in your personal fork rather than > a new branch. > > Yes, I think you should go on as suggested: create a new PR from a new branch. OK, will do. If you don't mind, I have a couple of noob

Re: RFR: 8260314: Replace border="1" on tables with CSS [v2]

2021-01-26 Thread Alexey Ivanov
> Replace presentational attribute `border="1"` on `` element with CSS > styles: > table {border: outset 1px} > th, td {border: inset 1px} > > These declarations produce the same rendering as the default one in Firefox > and Edge. > > Another option is to use `solid` in both cases. Alexey

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 15:55:53 GMT, Matthias Perktold wrote: > > ⚠️ @mperktold a branch with the same name as the source branch for this > > pull request (`master`) is present in the [target > > repository](https://github.com/openjdk/jdk). If you eventually integrate > > this pull request then

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Matthias Perktold
On Tue, 26 Jan 2021 14:36:09 GMT, Alexey Ivanov wrote: >>> This is what I mean, the quoted text of the CSS spec is the same for both >>> versions. >> >> Oh right I misread that, I really thought it changed, but it didn't. >> In that case I can also leave the link as it was, should I revert

Re: RFR: 8260314: Replace border="1" on tables with CSS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 01:54:10 GMT, Sergey Bylokhov wrote: > Probably we can import the CSS used by the javadoc itself? We do. For example, [AWT Modality in JDK 15](https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/java/awt/doc-files/Modality.html) has borders because of

Re: RFR: 8231286: HTML font size too large with high-DPI scaling and W3C_UNIT_LENGTHS

2021-01-26 Thread Alexey Ivanov
On Tue, 26 Jan 2021 07:50:54 GMT, Matthias Perktold wrote: > > This is what I mean, the quoted text of the CSS spec is the same for both > > versions. > > Oh right I misread that, I really thought it changed, but it didn't. > In that case I can also leave the link as it was, should I revert