On Thu, 1 Apr 2021 23:43:25 GMT, Phil Race wrote:
>> Marked as reviewed by prr (Reviewer).
>
> The CSR still had forRemoval. I've updated it and generally tidied it, but
> you may want to check my work.
I have checked the CSR, made minor corrections.
Overall looks good, thanks for updating
On Thu, 1 Apr 2021 14:43:36 GMT, Tejpal Rebari wrote:
>> Please wait for the @prsadhuk approval as well.
>
> I have fixed the issue with JTree, JTooltip and JViewport same way.
> While fixing for JTooltip discovered that default value for JToolTip opaque
> property for Nimbus LookAndFeel is set
On Thu, 1 Apr 2021 23:33:28 GMT, Phil Race wrote:
>> Tejpal Rebari has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits
On Thu, 4 Mar 2021 05:50:18 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
On Tue, 23 Mar 2021 06:10:32 GMT, Prasanta Sadhukhan
wrote:
> Specification for method
> javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle)
> is not perfectly clear which method the call is delegated to.
>
> Updated
On Thu, 1 Apr 2021 16:14:14 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> Marked as reviewed by aivanov (Reviewer).
> This might have been overlooked. The overridden
On Thu, 1 Apr 2021 16:16:07 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
On Thu, 1 Apr 2021 16:08:48 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional
On Thu, 1 Apr 2021 15:50:28 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1260:
>
>> 1258: /**
>> 1259:
On Thu, 1 Apr 2021 15:52:49 GMT, Sergey Bylokhov wrote:
> The method was overridden to change the implementation without changing of
> specification.
This might have been overlooked. The overridden method changes the behaviour.
I'm for documenting the updated behaviour.
> This is exactly the
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- javadoc change
- javadoc change
On Thu, 1 Apr 2021 15:29:34 GMT, Jonathan Gibbons wrote:
>>>
>>> Starting in JDK 10, the default behavior of the standard doclet was changed
>>> so that if a method is just being overridden for implementation reasons,
>>> and there is no change in the public spec or signature, then the method
On Thu, 1 Apr 2021 15:48:53 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
On Thu, 1 Apr 2021 15:25:44 GMT, Prasanta Sadhukhan
wrote:
>> Starting in JDK 10, the default behavior of the standard doclet was
>> changed so that if a method is just being overridden for implementation
>> reasons, and there is no change in the public spec or signature, then
>> the method
On Thu, 1 Apr 2021 14:10:08 GMT, Jonathan Gibbons wrote:
>> @prsadhuk You could always add `@inheritDoc` like this:
>>
>> /**
>> * {@inheritDoc}
>> */
>
> Starting in JDK 10, the default behavior of the standard doclet was
> changed so that if a method is just being overridden for
On Thu, 1 Apr 2021 12:48:52 GMT, Andrey Turbanov
wrote:
>> Looks like this change goes beyond of simple replacement of StringBuffer
>> with StringBuilder. Please update the description of the bug and PR
>> description.
>
> I've updated PR description, but I don't have rights to update JIRA.
On Wed, 31 Mar 2021 20:34:51 GMT, Sergey Bylokhov wrote:
>> Tejpal Rebari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added default value check for opaque property
>
> Please wait for the @prsadhuk approval as well.
I have fixed
> Hi All,
> Please review the following fix for jdk17.
>
> Issue : LookAndFeel.installProperty(list, "opaque", false) is not able to set
> the opaque property for JList and JTable.
> LookAndFeel.installProperty calls the setUIProperty, and setUIProperty checks
> for OPAQUE_SET to change the
On Thu, 1 Apr 2021 12:45:52 GMT, Kevin Rushforth wrote:
>> I guess openjdk shows file history from 7u23 onwards IIRC so not sure why it
>> is showing "Initial load" and not who/what removed it. Maybe the spec
>> wordings actually was not there but some javadoc trickery was adding the
>>
On Wed, 31 Mar 2021 19:56:24 GMT, Sergey Bylokhov wrote:
> Ok, please file a similar bug for the windows platform.
I have created the bug for windows here
https://bugs.openjdk.java.net/browse/JDK-8264598.
I have also created the CSR for the current issue.
-
PR:
On Thu, 1 Apr 2021 12:49:06 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
>>
>>> 1267: *
>>> 1268: * @see java.awt.ComponentOrientation
>>> 1269: */
>>
>> Shall it just use `{@inheritDoc}`?
>> The javadoc generated in 7 and
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Add @inheritDoc
-
Changes:
On Thu, 1 Apr 2021 12:42:19 GMT, Alexey Ivanov wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
>
>> 1267: *
>> 1268:
On Thu, 1 Apr 2021 12:41:14 GMT, Prasanta Sadhukhan
wrote:
>> The method is also present in the Java 8:
>> https://docs.oracle.com/javase/8/docs/api/javax/swing/JMenu.html#setComponentOrientation-java.awt.ComponentOrientation-
>
> I guess openjdk shows file history from 7u23 onwards IIRC so not
On Fri, 26 Mar 2021 11:30:35 GMT, Prasanta Sadhukhan
wrote:
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
> 1267: *
> 1268: *
On Wed, 31 Mar 2021 21:12:37 GMT, Sergey Bylokhov wrote:
>> Submitted: https://bugs.openjdk.java.net/browse/JDK-8264428, please rename
>> PR to "8264428: Replace uses of StringBuffer with StringBuilder in
>> java.desktop".
>
> Looks like this change goes beyond of simple replacement of
On Thu, 1 Apr 2021 12:35:21 GMT, Alexey Ivanov wrote:
>> I could not see the spec in the last 14 years openjdk history of this file.
>> Shouldn't we need to add the spec even if it's javadoc bug?
>> Instead of blindly copying JComponent setComponentOrientation spec as was
>> done in jdk7 in
On Thu, 1 Apr 2021 11:26:55 GMT, Prasanta Sadhukhan
wrote:
>> Looks like the JavaDoc bug, the spec was there in jdk7:
>> https://docs.oracle.com/javase/7/docs/api/javax/swing/JMenu.html#setComponentOrientation(java.awt.ComponentOrientation)
>
> I could not see the spec in the last 14 years
The current spec for
javax/swing/plaf/BorderUIResource.BevelBorderUIResource.html(int,java.awt.Color,java.awt.Color)
does not clearly specify the usage of color for hightlight and shadow as there
are outer/inner hightlight and outer/inner shadow.
Updated spec to clarify the same.
-
> Create implementation of NSAccessibilitySlider protocol
> https://developer.apple.com/documentation/appkit/nsaccessibilityslider
>
> The implementation has the function performIncrement and performDecrement to
> increase/decrease the value of slider using the VoiceOver. To implement this
>
On Tue, 23 Mar 2021 06:10:32 GMT, Prasanta Sadhukhan
wrote:
> Specification for method
> javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle)
> is not perfectly clear which method the call is delegated to.
>
> Updated
On Sat, 27 Mar 2021 01:20:45 GMT, Sergey Bylokhov wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Looks like the JavaDoc bug, the spec was there in jdk7:
>
On Tue, 23 Mar 2021 10:26:42 GMT, Prasanta Sadhukhan
wrote:
> SonarCloud reports the potential issue with
> MetalHighContrastTheme.getControlHighlight where `controlHighlight ` field is
> not used and the getControlHighlight() uses secondary field.
> public ColorUIResource
35 matches
Mail list logo
